Re: [i2rs] [OPS-DIR] OPS-DIR review of draft-ietf-i2rs-yang-l3-topology-10
"Susan Hares" <shares@ndzh.com> Wed, 26 July 2017 17:24 UTC
Return-Path: <shares@ndzh.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E760C131D6D; Wed, 26 Jul 2017 10:24:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.945
X-Spam-Level:
X-Spam-Status: No, score=0.945 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UfMIovPOB8F9; Wed, 26 Jul 2017 10:24:37 -0700 (PDT)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B02AF131D31; Wed, 26 Jul 2017 10:24:36 -0700 (PDT)
X-Default-Received-SPF: pass (skip=loggedin (res=PASS)) x-ip-name=70.194.20.65;
From: Susan Hares <shares@ndzh.com>
To: 'Ignas Bagdonas' <ibagdona.ietf@gmail.com>, draft-ietf-i2rs-yang-l3-topology.all@ietf.org
Cc: i2rs@ietf.org, ops-dir@ietf.org
References: <f63f0a34-302b-5f5b-85f4-58d9c7692253@gmail.com>
In-Reply-To: <f63f0a34-302b-5f5b-85f4-58d9c7692253@gmail.com>
Date: Wed, 26 Jul 2017 13:01:13 -0400
Message-ID: <003801d30630$ca1188e0$5e349aa0$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQHZB+uxGLxotEeejat6jRtm5a2EzKJaUY2w
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/_g_XB79knyjErwA6CuqUxc_KKJg>
Subject: Re: [i2rs] [OPS-DIR] OPS-DIR review of draft-ietf-i2rs-yang-l3-topology-10
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 17:24:39 -0000
Ignas: Thank you for your review of the L3 Topology model. I appreciate that you are reviewing while many people are on vacation! Alex Clemm should be in touch with you shortly. Sue Hares -----Original Message----- From: OPS-DIR [mailto:ops-dir-bounces@ietf.org] On Behalf Of Ignas Bagdonas Sent: Wednesday, July 26, 2017 11:14 AM To: draft-ietf-i2rs-yang-l3-topology.all@ietf.org Cc: i2rs@ietf.org; ops-dir@ietf.org Subject: [OPS-DIR] OPS-DIR review of draft-ietf-i2rs-yang-l3-topology-10 Hi there, I have been selected as OPS-DIR reviewer for this document. Document: draft-ietf-i2rs-yang-l3-topology-10 Reviewer: Ignas Bagdonas Review result: Has issues. Major question that I get after reading this document is on how the proposed model would be used and provide practically useful topology abstraction interface, especially in the context of multitopology routing. The document covers multitopology as augmentation to L3 unicast topology model, and this exposes per-protocol MT specifics, which seems to fall exactly opposite to the intention of the document to provide abstracted topology view. MT topology view is a subset of protocol specific topology plus it can contain routes coming from other sources too, and the model approach specified in this document does not seem to allow for expressing such constructs. One practical use case is multicast RPF lookup control, typically that is an IGP MT view plus local override routes, typically statically injected. For this use case the model described would require the topology to be strictly coming from a single IGP source, either IS-IS or OSPF, with no ability to intermix both, and with no ability to represent routes external to IS-IS or OSPF topology sources. Having separate models for IS-IS and OPSF for augmenting the base L3 topology model does not allow for hiding the differences in representation of IS-IS and OSPF derived topology aspects, in particular the MT identifiers. For the user this would require to know which one of the IGPs is used instead of getting just the specific topology view regardless of what are the underlying topology sources. What is the intended use of this model then - is it on providing interface to protocol specific topology (which then raises a question on how it correlates to protocol specific models' operational part, and section 1 second paragraph mentions precisely that), or is it on providing routing information source independent interface to topology? As a summary, the document would benefit from operational considerations section that would explain the intended use of this model and how it correlates and interworks with IGP specific models. Without a clear answer where the model is positioned it is difficult to provide more detailed review on the model structure itself. Metrics being a single uint32 value - that may not be flexible enough to represent realistic scenarios where a topology instance may have different routing information sources with incompatible or incomparable metrics. At least two independent metric components would be needed for that. Nits: Title page has 6 authors listed. Are Xufeng's contact details correct? s/Netconf/NETCONF s/Parantheses/Parentheses NET-id, NET Id should all be NET ISIS model has a reference to OSPF MT RFC. ISIS model for multi-topology-id has max-elements "128" limit. MT TLV can be repeated and thus a larger number of topology ids can be signalled. s/paper/document Overall the document would benefit from grammar check. Abstract, Introduction, and Overview sections contain quite much of repetitive text. Thank you. Ignas _______________________________________________ OPS-DIR mailing list OPS-DIR@ietf.org https://www.ietf.org/mailman/listinfo/ops-dir
- [i2rs] OPS-DIR review of draft-ietf-i2rs-yang-l3-… Ignas Bagdonas
- Re: [i2rs] [OPS-DIR] OPS-DIR review of draft-ietf… Susan Hares
- Re: [i2rs] OPS-DIR review of draft-ietf-i2rs-yang… Hariharan Ananthakrishnan