Re: [i2rs] Suresh Krishnan's Discuss on draft-ietf-i2rs-rib-data-model-10: (with DISCUSS and COMMENT)
Martin Bjorklund <mbj@tail-f.com> Thu, 05 April 2018 14:05 UTC
Return-Path: <mbj@tail-f.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B3CC129C6B; Thu, 5 Apr 2018 07:05:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cTmH-OAt7y7C; Thu, 5 Apr 2018 07:05:44 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 290B6127599; Thu, 5 Apr 2018 07:05:44 -0700 (PDT)
Received: from localhost (unknown [173.38.220.45]) by mail.tail-f.com (Postfix) with ESMTPSA id C2CD11AE047B; Thu, 5 Apr 2018 16:05:41 +0200 (CEST)
Date: Thu, 05 Apr 2018 16:05:41 +0200
Message-Id: <20180405.160541.2135154939537620152.mbj@tail-f.com>
To: shares@ndzh.com
Cc: suresh@kaloom.com, iesg@ietf.org, i2rs@ietf.org, draft-ietf-i2rs-rib-data-model@ietf.org, i2rs-chairs@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <041501d3cce4$c7e59cc0$57b0d640$@ndzh.com>
References: <152281674476.24011.1275548255371559292.idtracker@ietfa.amsl.com> <041501d3cce4$c7e59cc0$57b0d640$@ndzh.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/i2rs/jdyXhQ47QiBlcywkOKfiQj-NlY0>
Subject: Re: [i2rs] Suresh Krishnan's Discuss on draft-ietf-i2rs-rib-data-model-10: (with DISCUSS and COMMENT)
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2018 14:05:46 -0000
Hi, There are standard types for IPv6 flow label and for MAC addresses defined in RFC 6991: inet:ipv6-flow-label yang:mac-address /martin "Susan Hares" <shares@ndzh.com> wrote: > Suresh: > > Thank you for catching these issues. I missed these as a Shepherd (as did > the other reviewers) and AD. See my answers below. > > Would you or Martin hold a discuss until these critical issues are resolved > and checked with the YANG doctors? I will work with the authors to resolve > these issues. This revision will take some time as we seek advice from the > YANG doctors and from the community on the IEEE MAC Address being an index > or a full MAC Address. > > Susan Hares > > -----Original Message----- > From: i2rs [mailto:i2rs-bounces@ietf.org] On Behalf Of Suresh Krishnan > Sent: Wednesday, April 4, 2018 12:39 AM > To: The IESG > Cc: i2rs@ietf.org; draft-ietf-i2rs-rib-data-model@ietf.org; > i2rs-chairs@ietf.org; shares@ndzh.com > Subject: [i2rs] Suresh Krishnan's Discuss on > draft-ietf-i2rs-rib-data-model-10: (with DISCUSS and COMMENT) > > Suresh Krishnan has entered the following ballot position for > draft-ietf-i2rs-rib-data-model-10: Discuss > > When responding, please keep the subject line intact and reply to all email > addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-i2rs-rib-data-model/ > > > > ---------------------------------------------------------------------- > DISCUSS: > ---------------------------------------------------------------------- > > This model tries to squeeze the 20 bit IPv6 flow label into a 16 bit field. > This will result in a loss of data and needs to be fixed before the document > is published. > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > * Section 3 > > => Under > > identity ipv6-decapsulation { > > it looks like the description is wrong ("IPv4 tunnel decapsulation.") > ---- > You are correct. It will be replaced with the following > ========= > identity ipv6-decapsulation { > base "tunnel-decapsulation-action"; > description > "IPv6 tunnel decapsulation."; > } > > => What use case is the ttl-action decrease-and-copy-to-inner used for? > ---- > Good catch! > This feature may be used for tunnels (7.2.1 of > draft-ietf-i2rs-rib-info-model) or nexthops chains (section 7.2.5 of > draft-ietf-i2rs-rib-info-model). Good catch in that it does not provide > enough detail in this version. > > We've had comments over the last years to put this level of detail in or out > of the YANG model. I believe the latest wisdom from NETMOD/NETCONF is to > put the level of detail back in > > => Under case egress-interface-mac-nexthop { > > It is not clear to me how you fit a MAC address into a 32 bit space ,or am I > misreading this somehow and this is some form of index? > > Good Catch. > > Early on it was a holding place for a the official IEEE:MAC table, and > should have been transferred to either the IEEE:MAC-ADDRESS (see page 17 > RIB-INFO draft). However, this definitely needs to get fixed. I need to > check with the YANG Doctors to determine which is the preferred fix for this > reference at this time. I'm sure implementers have been using a fully > qualified IEEE_MAC_ADDRESS or a reference to the Table. > > High level - case points to an outgoing interface, ieee-mac address - > > case egress-interface-mac-nexthop { > container egress-interface-mac-address { > leaf outgoing-interface { > type if:interface-ref; > mandatory true; > description > "Name of the outgoing interface."; > } > leaf ieee-mac-address { > type uint32; > mandatory true; > description > "The nexthop points to an interface with > a specific mac-address."; > } > description > "The egress interface must be an Ethernet > interface. Address resolution is not required > for this nexthop."; > } > } > > It is not clear to me how you fit a MAC address into a 32 bit space ,or am I > misreading this somehow and this is some form of index? > > " leaf ieee-mac-address { > type uint32;" > > > _______________________________________________ > i2rs mailing list > i2rs@ietf.org > https://www.ietf.org/mailman/listinfo/i2rs > > _______________________________________________ > i2rs mailing list > i2rs@ietf.org > https://www.ietf.org/mailman/listinfo/i2rs >
- [i2rs] Suresh Krishnan's Discuss on draft-ietf-i2… Suresh Krishnan
- Re: [i2rs] Suresh Krishnan's Discuss on draft-iet… Susan Hares
- Re: [i2rs] Suresh Krishnan's Discuss on draft-iet… Martin Bjorklund
- Re: [i2rs] Suresh Krishnan's Discuss on draft-iet… Susan Hares
- Re: [i2rs] Suresh Krishnan's Discuss on draft-iet… Mach Chen