Re: [i2rs] Shepherd review of draft-ietf-i2rs-traceability-04.txt

Joe Clarke <jclarke@cisco.com> Thu, 17 December 2015 20:09 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: i2rs@ietfa.amsl.com
Delivered-To: i2rs@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F1141B3073; Thu, 17 Dec 2015 12:09:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id geerNa6XiJoo; Thu, 17 Dec 2015 12:09:02 -0800 (PST)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 832911B3072; Thu, 17 Dec 2015 12:09:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4129; q=dns/txt; s=iport; t=1450382942; x=1451592542; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=nrgXl4ayYlkf5QGbbc/g52DnLWS9xHd0zoP1IM8lVFg=; b=ehgwGaoyD9ON83LJNnSN0PHJH09jBm5fAsstR9J+MiYLlaF0feJDocD/ uT9NgIA2HD8m4qLr7KC2OhmTOv0XWx9SF+O2H0QLMN8TCvbXHLF8IK6Fy Op8iyaqwY/yWNuogDbeL1EXt5Xf2EeIicv0Pk9+NhkEUt56RX0NhEcqhz o=;
X-IronPort-AV: E=Sophos;i="5.20,442,1444694400"; d="scan'208";a="217843974"
Received: from rcdn-core-11.cisco.com ([173.37.93.147]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2015 20:09:01 +0000
Received: from [10.117.46.165] (rtp-jclarke-8914.cisco.com [10.117.46.165]) by rcdn-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id tBHK91wd003619; Thu, 17 Dec 2015 20:09:01 GMT
To: Susan Hares <shares@ndzh.com>, i2rs@ietf.org, draft-ietf-i2rs-traceability@ietf.org
References: <012201d13905$47882720$d6987560$@ndzh.com>
From: Joe Clarke <jclarke@cisco.com>
Organization: Cisco Systems, Inc.
Message-ID: <5673165D.60509@cisco.com>
Date: Thu, 17 Dec 2015 15:09:01 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <012201d13905$47882720$d6987560$@ndzh.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/i2rs/vgTHg24qqW2dbYnNoy9CwwqYYvA>
Cc: "'Carlos Pignataro (cpignata)'" <cpignata@cisco.com>, "'Gonzalo Salgueiro (gsalguei)'" <gsalguei@cisco.com>
Subject: Re: [i2rs] Shepherd review of draft-ietf-i2rs-traceability-04.txt
X-BeenThere: i2rs@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Interface to The Internet Routing System \(IRS\)" <i2rs.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/i2rs>, <mailto:i2rs-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/i2rs/>
List-Post: <mailto:i2rs@ietf.org>
List-Help: <mailto:i2rs-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/i2rs>, <mailto:i2rs-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Dec 2015 20:09:04 -0000

On 12/17/15 14:58, Susan Hares wrote:
> Joe, Carlos, Gonzalo:
>
> The is a Shepherd’s review of your document.
>
> Status: Needs Minor Changes, mostly editorial. Details are below.
>
> Let me know if you have any questions.  If you could get to these minor
> editorial changes this week, I would like to see if I can get
> Directorate Reviews over the next 3 weeks.

Thanks, Sue.  We will work to have these done by tomorrow.

Joe

>
> Sue Hares
>
> ===============
>
> Technical changes:
>
> 1)Remove section 5.4 – I2RS trace Log Extensibility and Optional fields
>
> Reason: In the document it is a TBD. If we need to extend these we will
> revise the traceability requirements and framework.
>
> 2)Section 7.4.2/&.4.3 uses section 6.7 for notification pub/sub
>
> The sections in the I2RS architecture document have changed. Please
> change this document.
>
> 3)Section 7.4.3 – the draft [I-D.camwinget-i2rs-pubsub-sec] is no longer
> active.   Please determine if this work is included in the
> draft-ietf-i2rs-security-environment-reqs-00
> <https://datatracker.ietf.org/doc/draft-ietf-i2rs-security-environment-reqs/>
> or draft-ietf-i2rs-protocol-security-requirements
> <https://datatracker.ietf.org/doc/draft-ietf-i2rs-protocol-security-requirements>.
>
>
> If not, please determine if changes can be made to these documents, or
>
> If we need to re-investigate making draft-camwinget-i2rs-pubsub-sec
> document an I2RS document.
>
> *Editorial changes: *
>
> *1:  Page 4.*
>
> Lists in section 4 – I suggest for list below you use “;” instead of “.”
> for ease of reading and grammatical correctness.
>
>    o  Automated event correlation, trend analysis, and anomaly
>
>        detection.
>
>     o  Trace log storage for offline (manual or tools) analysis.
>
>     o  Improved accounting of routing system operations.
>
>     o  Standardized structured data format for writing common tools.
>
>     o  Common reference for automated testing and incident reporting.
>
>     o  Real-time monitoring and troubleshooting.
>
>     o  Enhanced network audit, management and forensic analysis
>
>        capabilities.
>
> 2) Section 5.1 paragraph 1
>
> s/highlighted herein/ to / in this section./
>
> *3) Figure 1: *
>
>    Operation +
>
>                  Op Data
>
>                    V
>
> The “V” seems to not lead anyplace.  Probably needs to be deleted or fixed.
>
> *4: Section 5.2 *
>
>      Request Timestamp:
>
>        The specific time, adhering to [RFC3339
> <https://tools.ietf.org/html/rfc3339>] format,
>
>        at which the I2RS operation was received by the Agent.
>
>     Result Timestamp:
>
>        The specific time, adhering to [RFC3339] format,
>
>        at which the I2RS operation was completed by the Agent.
>
> Proposed fix: Alternate for both timestamps
>
> The specific time at which the I2RS operation was received by the
> Agent.  The time is passed in the [RFC3339] format.
>
> *5: Change the RIB-Info model to draft-ietf-i2rs-rib-info-model in the
> text below. *
>
>        Result Code:   This field holds the result of the operation.  In the
>
>        case of RIB operations, this MUST be the return code as specified
>
>        in Section 4 of [I-D.nitinb-i2rs-rib-info-model].  The operation
>
>        may not complete with a result code in the case of a timeout.  If
>
>        the operation fails to complete, it MUST still log the attempted
>
>        operation with an appropriate result code (e.g., a result code
>
>        indicating a timeout).
>
> 6:  Section 7.2, p. 9
>
>  From
>
> /Another noteworthy consideration is that Client requests may not always
> be processed synchronously or within a bounded time/
>
> To:
>
> / Client requests may not always be processed synchronously or within a
> bounded time/
>
> 7. Section 7.2, p. 10, first full paragraph
>
>  From
>
> /Section 7.3 talks about rotating the trace log in order to/.
>
> To
>
> /Section 7.3 discusses rotating the trace log in order to/
>