Re: [Ice] Trickle ICE review

Peter Saint-Andre <stpeter@stpeter.im> Sun, 09 April 2017 21:42 UTC

Return-Path: <stpeter@stpeter.im>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC9A7129408 for <ice@ietfa.amsl.com>; Sun, 9 Apr 2017 14:42:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.72
X-Spam-Level:
X-Spam-Status: No, score=-2.72 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=stpeter.im header.b=KgphxzTJ; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=K3o2AdVF
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9QqRNAPP6vJM for <ice@ietfa.amsl.com>; Sun, 9 Apr 2017 14:42:15 -0700 (PDT)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 86464128DE5 for <ice@ietf.org>; Sun, 9 Apr 2017 14:42:14 -0700 (PDT)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id AC5B0206B7; Sun, 9 Apr 2017 17:42:12 -0400 (EDT)
Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Sun, 09 Apr 2017 17:42:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stpeter.im; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=VCdhExQeDUHbpDZM3G /IIdQSahEwPrWUext0dm+M8CY=; b=KgphxzTJv4TQ0QHjctIN8MZeYtX4+RGft+ 86h0joCKHt+H0+O+6l0D2h6TuuXvIvFhGpmRdn1ZugdCF5Yu7FiBvZHOD/BkcbQd Y5fXh7S81WOATbH+IS8peL/N+gTnRmTsZeynUprOS3qSY97eIJ7ojf044z6I8KcX 05dPoRI6uEOjy8Vht3opKVFmV+1xwS9aBaKsDlxrnRUSG+vMxux6w3x1h2qw54XC tMYDCoH2QOkAEHzvyR5NABzD+HkJ5aeeCbWmMRuaJL2RJDCLPdJqFDT56ftR6nd7 uts1IQCtJxWlRB01VE8Z5YA6+uOcGzghH3bVBAWKTcF2YAUH9Sjg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=VCdhExQeDUHbpDZM3G/IIdQSahEwPrWUext0dm+M8CY=; b=K3o2AdVF PBQoD5zw0pDQIsieGVWYHqYLKUU/yO2uha3Fy0MNd7t/4udaU4e4nZMkeWCQjABX AuXvbXOWzkwvAEPPaqEuaLhICVH0h2Dnn00UqZbS5yz3LjtX5wq+cYrAXuJeQ0By qDN4OYePHwpXu5M8HgPnN85otr9fD7LgoUPJ2UDrt9tDO9kGdIAPfAEU3z2WoWxU J/zn9qlsL1+CxfyzsoDRBxEe4+t9SpJlb04TNtJMmj/AjcoIU8cvsHJ5wsEAhI+m twlxbeEfGq/iO8WeIpFS+cyGN/4Q1CjnbuZCfTvCkowdnQhdSw5cCY9uGOZGyQ5Z Lnf5/7fTd4A1CQ==
X-ME-Sender: <xms:tKrqWKJIQmK5cj-piLCaeTRGk-yHc_DOwtrpvNDMRu1FTRKFBEQyGA>
X-Sasl-enc: 4yF4K0ns/F6Pzrqafgv8a21Owdz7JC8tv+nTZN8D4Ims 1491774132
Received: from aither.local (unknown [76.25.4.24]) by mail.messagingengine.com (Postfix) with ESMTPA id E1ECC7E31E; Sun, 9 Apr 2017 17:42:11 -0400 (EDT)
To: Peter Thatcher <pthatcher@google.com>, Taylor Brandstetter <deadbeef@google.com>, Christer Holmberg <christer.holmberg@ericsson.com>
References: <CAJrXDUHzNT3v5oMPBQu5_OsXwonY7cogDQgTt5QPxN0=6DWQkQ@mail.gmail.com> <7ebb3254-a882-6e05-3159-0ec56614831b@stpeter.im> <CAJrXDUEi0n7P5mDuuLGj285AmQqr9HDFUPGLtLnU+BuJpws6Tw@mail.gmail.com> <7e9e8188-2add-0497-e94f-14ee41afe02d@stpeter.im> <BFB0CDEF-4572-41D5-A5D2-A5D210A1E175@ericsson.com> <7594FB04B1934943A5C02806D1A2204B4CB330A0@ESESSMB109.ericsson.se> <CAJrXDUGy2VUKe33vLm-QOrQ+OSV+nFCKTsHXPt_VZ8sqrdpX0Q@mail.gmail.com> <7594FB04B1934943A5C02806D1A2204B4CB378CD@ESESSMB109.ericsson.se> <CAJrXDUFBO9Q4aHMjMr-0L505BMWPNSPkZ+sPGSNGu-JAXz2qww@mail.gmail.com> <0308af65-2cc9-c793-946d-6157d71db069@stpeter.im> <7594FB04B1934943A5C02806D1A2204B4CB38EBB@ESESSMB109.ericsson.se> <CAK35n0ZXaq0vj0xC0fS0fTKLFq+bogfwpr9-nwtXvztW+g7jYQ@mail.gmail.com> <CAJrXDUF838QJAm=cv_E2aOTBLiFXVk6mrfDXHV3p2JKjxMS5Cw@mail.gmail.com>
Cc: Ari Keränen <ari.keranen@ericsson.com>, "ice@ietf.org" <ice@ietf.org>
From: Peter Saint-Andre <stpeter@stpeter.im>
Message-ID: <19c7c1c6-fc7a-b10f-ffc0-1a3c9cf31dbe@stpeter.im>
Date: Sun, 09 Apr 2017 15:42:11 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAJrXDUF838QJAm=cv_E2aOTBLiFXVk6mrfDXHV3p2JKjxMS5Cw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/5wuTTcr9HpgVC8A9u4Cbtlub148>
Subject: Re: [Ice] Trickle ICE review
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Apr 2017 21:42:17 -0000

Agreed. The authors will submit a new version soon that addresses
Taylor's feedback.

On 3/31/17 4:03 PM, Peter Thatcher wrote:
> Ah, thanks for explaining this.  I like your idea of making the real
> intention explicit (pair and trickle in the same order).  I think that's
> much more clear and precise.
> 
> 
> 
> 
> 
> On Thu, Mar 30, 2017 at 8:45 PM Taylor Brandstetter <deadbeef@google.com
> <mailto:deadbeef@google.com>> wrote:
> 
>         In the phrase " A Trickle ICE agent MUST NOT pair a local
>         candidate until it has been trickled to the remote agent.", what
>         does "has been trickled" mean?
> 
> 
>     Sorry I'm late at responding to this, but I assumed the main
>     intention here was that candidates are paired in the same order that
>     they're trickled, because that was necessary for the unfreezing
>     logic to work. For example: suppose an endpoint already has remote
>     candidates, and then gathers RTP and RTCP candidates. It pairs them
>     in the order "RTCP, RTP" (maybe the STUN response for the RTCP
>     candidate came back first), resulting in an RTCP pair being unfrozen
>     first, but they're trickled in the order "RTP, RTCP" (as a result of
>     the restrictions of section 16), resulting in the remote endpoint
>     unfreezing the RTP pair first.
> 
>     Before, this would have resulted in things failing (as I recall).
>     But this isn't as much of a problem now; I'm looking at the current
>     section 8.1.1, and it would result in the local endpoint just
>     unfreezing /both/ pairs, so things would be able to proceed.
> 
>     But it still could result in extra pairs being unfrozen; is that
>     acceptable? If not, I'd suggest moving this note to section 16, and
>     making it more clear what the intention is. For example: "Candidates
>     MUST be paired, following the procedures in section 8.1.1, in the
>     same order that they're trickled."
> 
>     An important related question: There used to be a line that said
>     "When trickle updates are sent, each candidate MUST be delivered to
>     the receiving Trickle ICE implementation ... in the same order that
>     they were sent." But the "in the same order that they were sent"
>     part has been removed. Do we no longer require that the signaling
>     mechanism preserves ordering? If so, Section 16 doesn't make sense
>     any more; it requires a specific order of candidate trickling, but
>     that can't be guaranteed if the signaling mechanism doesn't preserve
>     ordering. All my ramblings above would be moot as well.
> 
>     On Thu, Mar 30, 2017 at 10:53 AM, Christer Holmberg
>     <christer.holmberg@ericsson.com
>     <mailto:christer.holmberg@ericsson.com>> wrote:
> 
>         Hi,
> 
>         Perhaps we could say something like "re-start or once all
>         candidates have been released", or something like that... We
>         seem to agree, so it's just about wording :)
> 
>         Regards,
> 
>         Christer
> 
>         -----Original Message-----
>         From: Peter Saint-Andre [mailto:stpeter@stpeter.im
>         <mailto:stpeter@stpeter.im>]
>         Sent: 30 March 2017 20:42
>         To: Peter Thatcher <pthatcher@google.com
>         <mailto:pthatcher@google.com>>; Christer Holmberg
>         <christer.holmberg@ericsson.com
>         <mailto:christer.holmberg@ericsson.com>>; Ari Keränen
>         <ari.keranen@ericsson.com <mailto:ari.keranen@ericsson.com>>
>         Cc: ice@ietf.org <mailto:ice@ietf.org>
>         Subject: Re: [Ice] Trickle ICE review
> 
>         On 3/30/17 9:45 AM, Peter Thatcher wrote:
>         > Ah, I see what you mean now.
>         >
>         > In that case, could we just define "ICE session" as the
>         something like
>         > "stuff until the next ICE restart or the termination of all ICE
>         > activity by this agent"?
> 
>         Right, there's no "ICE session termination" message, so that'll
>         have to do.
> 
>         Peter
> 
>         _______________________________________________
>         Ice mailing list
>         Ice@ietf.org <mailto:Ice@ietf.org>
>         https://www.ietf.org/mailman/listinfo/ice
>