Re: [Ice] Peter's review of ICEbis - Christer's input on the rest of Peter's comments

Peter Thatcher <pthatcher@google.com> Thu, 01 June 2017 01:25 UTC

Return-Path: <pthatcher@google.com>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4682C129ADD for <ice@ietfa.amsl.com>; Wed, 31 May 2017 18:25:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tYplpMHOq0GZ for <ice@ietfa.amsl.com>; Wed, 31 May 2017 18:25:44 -0700 (PDT)
Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 897D2129666 for <ice@ietf.org>; Wed, 31 May 2017 18:25:44 -0700 (PDT)
Received: by mail-oi0-x22c.google.com with SMTP id o65so12409222oif.1 for <ice@ietf.org>; Wed, 31 May 2017 18:25:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=pxF+xUfvpPz02IwNy5SheW9XyY+Y2Vm+1MvP2GKCYQg=; b=hSBcb6gFG0imaYpQxCIBPRD+yHeySiK9QO3Kp819oMxZMfBXyzWcuNT0X2k0elW/QG Xxm8JcZociPfEf1eZxdWFpPHvafat3H0Bei3YQxfyYAzhJmhYsyPRdquoeng5Z9sCmyI ETEuZQDWHbsmejRQU7K0kx9wp/j2DxoGRRgvDEp4rjkX+0gcyziiRQKYq+Bdke1W8fih xoPGUOs1/7cSwQnbP3SjypqeIvoTkkkuruos892xdWdcKiehQ40ltq23eLv6UWJZZYvm w2NDEnkvldCfb+Qrsb6+ikP5pSbwe+O4mwdJUBHILzB+upS12jxBO4VZXHSn7CiwxHKs 3vtQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=pxF+xUfvpPz02IwNy5SheW9XyY+Y2Vm+1MvP2GKCYQg=; b=NuuCVBkp9hYNrEeS70WM+s95OXk47Ipj5QrdLq5eyfHnkZ1UP/b3qhORjtYr6NOcEk UMyrT/LzpcU+BHcC8h+5Vokmj3S4T0PSnYuPWHRdD0ioMMfjfPjJL3unwaMRQSHC0pzn YCdx07Mpg0S6+9rpB4tw7O7znPSCi86BV8W14MZp9KnkDTUAGkW0uoWvbUiymTc/h8m3 FyM1oGYx9/3PQXJRNX1O6Ang67x4fqOQEfHF1fDmJ/DvBYIdi0j/0jbU9kFt6QOoygf1 2OfjEhc8n5Fl0NmPSMgUYju0EATL96eZPDLjznCPyhB3Q5n56xEsRf4YdrBNFl3/WuWG R4mA==
X-Gm-Message-State: AODbwcCif0dgQPrM67C1jAzjyw6MoI6VszEJ2cLbDD642impk3jjM3U+ WDMqdnz0k6sghzbzu+1z0sJROiFM8/dF
X-Received: by 10.202.206.193 with SMTP id e184mr12762955oig.91.1496280343867; Wed, 31 May 2017 18:25:43 -0700 (PDT)
MIME-Version: 1.0
References: <D551A3B4.1D3D4%christer.holmberg@ericsson.com>
In-Reply-To: <D551A3B4.1D3D4%christer.holmberg@ericsson.com>
From: Peter Thatcher <pthatcher@google.com>
Date: Thu, 01 Jun 2017 01:25:33 +0000
Message-ID: <CAJrXDUGdr_3-tg8tXyyFWuuxHD45O6QVuiH3nPkLc=O_VE982g@mail.gmail.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "ice@ietf.org" <ice@ietf.org>
Content-Type: multipart/alternative; boundary="001a113d2e7261f3ee0550dbea0f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/D-xVJmUIGRfQvngQJAtHesDRsdM>
Subject: Re: [Ice] Peter's review of ICEbis - Christer's input on the rest of Peter's comments
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 01:25:46 -0000

On Mon, May 29, 2017 at 12:08 AM Christer Holmberg <
christer.holmberg@ericsson.com> wrote:

> Hi,
>
> > - The spec says it's only defined for one TURN server and one STUN
> server but then it says what to do when more than one TURN server or STUN
> server is used.  I'm guessing we should remove the part about one TURN
> server rather than the other way around.
> > - Since we won't have aggressive nomination, do we still need the
> "three-second rule" for when candidates can be freed?
> > - The concept of using a Data Indication for a keepalive seems
> outdated.  In RTCWEB, consent freshness requires the use of binding
> requests, not data indications.    Should we change this?
> > - What does the phrase "through good box and software security on TURN
> servers." mean?
> > - Do we still need all the UNASF stuff?
>
> I have currently no input on the comments above.
>
> > - Should we keep this "send another candidate exchange when you're
> Complete" thing?  It looks like it's just there to
> > let signaling servers learn something, which I think should be out of
> scope for this document.  Let a SIP document specify that.
>
> Where is this text?
>

Search for "updated candidate".  It's referred to about 4 times.  It might
only be for the case where one media stream fails and is thus removed.  Or
it might also be for peer reflexive candidates.

I'm just not sure why it's in this doc at all and not in a using protocol
doc.


>
> > - The one example in the doc uses aggressive nomination, which no longer
> exists.
>
> We need to fix that.
>
> > - Do our "changes from 5245" section need to be updated?
>
> Yes...
>
> Regards,
>
> Christer
>
>
>