[Ice] Review of draft-holmberg-ice-pac-01

Qingsi Wang <qingsi@google.com> Sat, 30 March 2019 01:04 UTC

Return-Path: <qingsi@google.com>
X-Original-To: ice@ietfa.amsl.com
Delivered-To: ice@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8DB5120282 for <ice@ietfa.amsl.com>; Fri, 29 Mar 2019 18:04:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.501
X-Spam-Level:
X-Spam-Status: No, score=-17.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NJS7K9O7iWh9 for <ice@ietfa.amsl.com>; Fri, 29 Mar 2019 18:04:48 -0700 (PDT)
Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26ADB1200D7 for <ice@ietf.org>; Fri, 29 Mar 2019 18:04:48 -0700 (PDT)
Received: by mail-oi1-x22f.google.com with SMTP id l203so2464282oia.3 for <ice@ietf.org>; Fri, 29 Mar 2019 18:04:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=JqspP/jj6jcxa2H5hfpD+PjAxB9o/fEkPupTFpko1NA=; b=mVGjpyg2P6uLO8XpS4PtcznQRYarq7uLKd3ca5sik3rvC9QVNy7Xefju6TYBs8fNo4 496v276yw9QIdBtKtJMjfu06xDmBvCerrt0R9o8qfqUQTHXjT9UTmIcZpKs47i0OmmVn uq3s47oaUlWhoferY1D0MWL9N2WWItLFWXZiUJF8Gf6ku4kb1m0lefe2azxCtqKSPnr3 /H5BmuXoB2j+wwIomPxTCzEIvXDcJP6cYG06Jknt5WIktDgowWp+n6pchimOhFHB+xd8 4WHomIhqzBhrpZhgEfY3ITU4eg1W5QIRDBZE2i1jXGMq0q00RffS1oTDgPHLjcenIpwq +0Cg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JqspP/jj6jcxa2H5hfpD+PjAxB9o/fEkPupTFpko1NA=; b=hh2WrnoP547cF1evPIk0Bb8XXQv3IPpSwOuihH3+ux+CuSxnbkuCvvJ3KD4YCV6KGd TrI5BO3Vp724cutC7lr55FBHqYq6vOstsNK3mq6z/YkJdcvpXI05rrPaQHabZB5x16US 46nO4df5TTi0TQVa3rhkFGmqRwz5A48irDqb7ipFXXoUI7YXCXilsfhMObHjyHtG/rhd oHOYBiC+nE4yMGp9WDByVe7HDhjmoDKd3qHP1ieOjmdnvZO5JrUGOJq7dAT07RnaWAC2 0cqOqdrDajXNkmIjcr1+5r6k4/VErKFIwFquq544RSqSArGOt42JId/dcKYpSXR3GTJr y8zQ==
X-Gm-Message-State: APjAAAWOBfHx8k9CaSJDTYZOdXydNqfGmyEwP9LiLRUiu+kjgLxM+XW6 zLQ4O4WVyeEkyx4GsSdYWtajPtX0RYSsQyL9F8BccGeREFyQVg==
X-Google-Smtp-Source: APXvYqy7p16KvucFm3zWT4jqVlKywhuOL8B+sjzFzdB7mDTHFy1Wa/Ig8f5tOCw3C5U1w8COIXij96xP6QUDt4dydK4=
X-Received: by 2002:aca:c5cd:: with SMTP id v196mr5247046oif.90.1553907887280; Fri, 29 Mar 2019 18:04:47 -0700 (PDT)
MIME-Version: 1.0
From: Qingsi Wang <qingsi@google.com>
Date: Fri, 29 Mar 2019 18:04:36 -0700
Message-ID: <CA+m752J8G+U_HGxp-y=mconD-j+RfwyZWE6DYNLuP4NZd_ROnw@mail.gmail.com>
To: ice@ietf.org
Content-Type: multipart/alternative; boundary="000000000000a2facf0585455fd0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ice/EH-gN3VEehMX1t0qL86TwbeaRHI>
Subject: [Ice] Review of draft-holmberg-ice-pac-01
X-BeenThere: ice@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Interactive Connectivity Establishment \(ICE\)" <ice.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ice>, <mailto:ice-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ice/>
List-Post: <mailto:ice@ietf.org>
List-Help: <mailto:ice-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ice>, <mailto:ice-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2019 01:04:50 -0000

If all available candidate pairs have either performed triggered checks or
sent check response, but have timed out their checks however, should we
cancel the timer and conclude a failure? The rationale is to wait for
inbound checks, but if at least one round of checks are received, it's
unclear to me if the waiting would benefit compared to allowing the app
trigger an ICE restart after firing an failure.

The rest looks good to me.

Best,
Qingsi