Re: [Idr] Fwd: New Version Notification for draft-liang-idr-bgp-flowspec-time-00.txt

Jeffrey Haas <jhaas@pfrc.org> Mon, 19 October 2015 20:15 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3C091A90F3 for <idr@ietfa.amsl.com>; Mon, 19 Oct 2015 13:15:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.578
X-Spam-Level:
X-Spam-Status: No, score=-1.578 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, IP_NOT_FRIENDLY=0.334, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7vdgyBBHam7s for <idr@ietfa.amsl.com>; Mon, 19 Oct 2015 13:15:32 -0700 (PDT)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 41C1E1A90D5 for <idr@ietf.org>; Mon, 19 Oct 2015 13:15:32 -0700 (PDT)
Received: by slice.pfrc.org (Postfix, from userid 1001) id 38E7C1E4E7; Mon, 19 Oct 2015 16:19:47 -0400 (EDT)
Date: Mon, 19 Oct 2015 16:19:47 -0400
From: Jeffrey Haas <jhaas@pfrc.org>
To: Youjianjie <youjianjie@huawei.com>
Message-ID: <20151019201947.GL15569@pfrc.org>
References: <F6C28B32DA084644BB6C8D0BD65B669D1F8421@nkgeml509-mbs.china.huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <F6C28B32DA084644BB6C8D0BD65B669D1F8421@nkgeml509-mbs.china.huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <http://mailarchive.ietf.org/arch/msg/idr/4tNxgNRCi-4cMY9pX-xbSdCGk08>
Cc: "idr@ietf.org" <idr@ietf.org>
Subject: Re: [Idr] Fwd: New Version Notification for draft-liang-idr-bgp-flowspec-time-00.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2015 20:15:33 -0000

Jianjie,

On Mon, Oct 19, 2015 at 02:08:35AM +0000, Youjianjie wrote:
> This document proposes a new BGP path attribute called "Flow Extended Attribute", which carries expected valid period information for a FlowSpec rule.
> Could you please review? Your comments are welcome.

I've given some commentary on the time constraints later in the thread.

The description TLV is problematic for a few reasons:
0. Please use UTF-8 encoding for proposals rather than ASCII. :-)

1. They take space in the PDU.  In some cases we're getting close to packing
full BGP PDUs and I suspect the operational benefit of a description is low.
If you must use space for such things, consider some sort of 64-bit number
instead.  Community encoding may be more appropriate.

2. The scoping of this information is a bit too broad.  Especially in a DoS
mitigation context, do you *really* want to tell your downstreams the
information that's attached to the description?  The security ADs might call
this a privacy consideration.

-- Jeff