Re: [Idr] Suggestion to use a more generic name for Topology-Type and ISP-sub-TLV in draft-ietf-idr-sdwan-edge-discovery-05

Linda Dunbar <linda.dunbar@futurewei.com> Thu, 02 March 2023 04:19 UTC

Return-Path: <linda.dunbar@futurewei.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC545C14F748; Wed, 1 Mar 2023 20:19:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4cbWsM-Zl1yb; Wed, 1 Mar 2023 20:19:18 -0800 (PST)
Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2070b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eb2::70b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8A48C14CEE5; Wed, 1 Mar 2023 20:19:17 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzY8zzxtkTZUVedeVogRFZ7RJyxI6fFxnLvdrbbKx0K8lcKP30r7XiH36nfEMwqFqqQIrJxBJu3T31WFKC1cE8iaaNq3QI7D9qTEWv8HZ9frV4nnDPKU5kFm97/xS7MOul9HU1mTi5iyOZjAMYX2mnwtf3BvqgcULAyIxWIx9Lr9eQtigwTDgwq1Oani145DNU5JMe6dS9hlQ5MB/ydJjO22VIpCfTka4EQvuyRBOEQINR6ROaYgG4KwV59xIDiYybW5/t7n9QPU6mpMLKUt7WsCK061QVtrnvlc/n4ntBuNRLsQmYJtyzjnj+vHUGKOCpQESerHzoodTfjhuBqklg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1rQmFvIcP0FWoBgOc0F9Bqza2+xPFasiS0JV/YRLR6Q=; b=agoDhxfsTl04cUoXApLZbZYiZQrS5BGEEADz78DxeFVSNy9BcN8sKuXFsIiKZBhhFhXnDCCFKqnxKqm8PP0G/XuBha3IVMybrYF8m8c3QOt8wIaT9/TqnFBIguO7EILvNdte7yorij+6NZkukBpGINjz5QtYoRpQ8Raw5m3E1jF8NW3Ta1KRlWtBiBTlIytXCsk1rxzyVI+30ZfFl9Tg/wRdwoKNvMYbCgRmke699owFy7Dfv+l/EoTAY9vawbeMc9giTcff4kg9koIaYG60XJdVMbyXAMqKGCjqG+vRDg+8/qQFecVAcQQ9Z2tKTGRMi7Y8SzVoF/ibULn/+ivsSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rQmFvIcP0FWoBgOc0F9Bqza2+xPFasiS0JV/YRLR6Q=; b=uMZXWgqlF25ojNpC0jGyo6M1PMW6vasENkBF6fh9ZPBOVmqt8bcPkqd1/yhD8aBfz7T7QeNSVLBMNXjhIcFOYewkYtehONZ/snhiYJ6gCA1W1a9jzJ74rixUYK4WMEckvRRU7K03TDBmPhkBd2xTjpa75qa2/pUD+zZgKPTJBkY=
Received: from CO1PR13MB4920.namprd13.prod.outlook.com (2603:10b6:303:f7::17) by DM4PR13MB5932.namprd13.prod.outlook.com (2603:10b6:8:52::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Thu, 2 Mar 2023 04:19:13 +0000
Received: from CO1PR13MB4920.namprd13.prod.outlook.com ([fe80::779f:d1a3:1768:af82]) by CO1PR13MB4920.namprd13.prod.outlook.com ([fe80::779f:d1a3:1768:af82%9]) with mapi id 15.20.6156.018; Thu, 2 Mar 2023 04:19:13 +0000
From: Linda Dunbar <linda.dunbar@futurewei.com>
To: Shengcheng <shengcheng@huawei.com>, "draft-ietf-idr-sdwan-edge-discovery@ietf.org" <draft-ietf-idr-sdwan-edge-discovery@ietf.org>
CC: "idr@ietf.org" <idr@ietf.org>
Thread-Topic: Suggestion to use a more generic name for Topology-Type and ISP-sub-TLV in draft-ietf-idr-sdwan-edge-discovery-05
Thread-Index: AdlLU4u14jBZ+slBTy2fayHXrRpFMABYVe4A
Date: Thu, 02 Mar 2023 04:19:13 +0000
Message-ID: <CO1PR13MB4920FAD081009F0F8E87001685B29@CO1PR13MB4920.namprd13.prod.outlook.com>
References: <be7298a2ebbc4ab58fd52acd21e25920@huawei.com>
In-Reply-To: <be7298a2ebbc4ab58fd52acd21e25920@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=futurewei.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CO1PR13MB4920:EE_|DM4PR13MB5932:EE_
x-ms-office365-filtering-correlation-id: 76054879-160b-4c90-80e6-08db1ad54791
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: +M6grU2cqcVf6Un9visZjgSnRNYxkZ5MuXCYlMmsO+AOQJFnYRr1iXyd4XEg06lJUAvi1ZwzmRvfGAwBDZJ6H8OKLWapa3LiqE7QuFxAk72ABd9Z3Q1tpIeZZD2yd8uZuxaTUfSrOhLkAq2Uf4j84GC1X9M3axivKi/YsBeMOAcy2YR/RsPloap6M6CV5ys5Q4fmyHuNFvMIN0Wkyo0bTqoTtdLB+7GPWVuE3VGluUK184TRKxo9iPx12p0I2XsXY5dmjn7QxcqGskPZZlpqc2NMGg/hy6RJ+nN51DOJGS/xDHJmAZdZZZKr0D0E50fhuGb228elS1zjamJ98iOhRqQNLe3Lu29QYkThU5I38NFTsMq+DZMFw87Ne+ZqvJCcdbYOUi+P83MJr4s7simWS4ZEqASvLNfB5o7ebQXN0dcBqwZg1f01X02ALqWR6xQQ+W+NJTHqlkjiyCnne3jZhmMuIJ8dYagKEtPE50at8Qv+4YDmdT+zBjXm99fSfKezS0PH41E1pCjTu9s06rAPuXjfEzJmlpf+Ncb18Ucz78J+hsvYP3oAE16fbHgJ6BJJ1SNbsBGN5JDTzMrJo8GXI0lfsM8AtSUU5hMBV7Jg9f2MV2372YrGbrd+8TD3+bWh+gihb+GZ1TyNOKqleiY+ECIOD4hRYWMZz2WitzT66AlAqYMuIDhuEvVtkJrD0QEjP/QCnjE+Gqu43c4wRchaHNu1cfC0l8i3SCJ8HGXBwj8=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR13MB4920.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(346002)(136003)(396003)(376002)(39850400004)(451199018)(83380400001)(110136005)(76116006)(33656002)(122000001)(55016003)(64756008)(4326008)(38100700002)(8676002)(478600001)(66476007)(6506007)(186003)(9686003)(26005)(7696005)(66946007)(316002)(44832011)(71200400001)(53546011)(66446008)(5660300002)(86362001)(2906002)(41300700001)(8936002)(66556008)(38070700005)(52536014)(41533002); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: JC+6cXbotx0THj9qOTf+MmaPTbFHD/zWwosDUHdy5LV2PLJIwuzfl86LURPwyCuduxxpyY/DAr6Kwf5iav7986E9YIiMV+zri0NsXG6NqhfYKsEfo8VikaFeZjRTVr+oLc/GN91xfLrWSpqIltIp1DpEXgb3ymc5jUQRRg/HEhKMRvxz6tJkxiLAPQGQIXv1laVVL6jaA4eU4GZ8WtPbph9qSyPEN/5SzA6IOthVPHBz7jrMkRVU9h1S9uW9xHG9HFODcjezxkEfTO+lkMVNQS8ZHo8ImYrHkRb/p7/JMhw0oPMPXeqSh3LBK//OXo+Ih6dAb+pb/lLD82y1PRH07x8S8auGTt6qkekSuXVoIp+WTUah9f7jTqaylf1tC8e/6ZM92S7kAb5eC041Hwk7GJ56gpJxL7yQDGuNcfaEBIFWyAovLo2Ro4298RKdXRjORM/rFBrEzTsMsSIpXyOE/4eL8ItXoM6mQmdtFJKfFC8xJUZP49WXnmpMVtm+3a/014+dy8xOgMurRe0YB56hfeKE9V40KLFbzSG8j39+2nZGR/eV/7yhEPbSdbbAOE5rhq/H2VEoGqYHl5LWgeOPAojuf0vlhJ6zTpbodAzcLoZQ0fZZ9aoeYxp6RxXjkjCWUrS16ZovvxyiahoA3dsqAQf3OCK5iHcojTkgyNFYUWXaCed8Weqt3ruFhKOXLjyQLP9bOYc8Nbcs2z8fVmU3N6qXFuWhfXUNQzzZXQcsNjeEk+7RzTxuS6PMz7bgMwdMkvdsOxdMn5zqjTBeZ4wEqnQSURDFX5vscFku6YBJL5xi6tFW3J8buASMh3y11JYG8CCf2ZJEfHInALGcfPFo0I1Fs2D54/KxC7sGHNrMFUpn2ptz09+kaWeGkurpDiDFDDaIKLHwHayUYw5U+bBzmDXjOr8f28WsNoIi72Z9+AN5h6CwOEgt95jrD4VoiyRn/G5NjvtHcePzYA6MH49OqYG52oZ5AtYWdgOaIfRXwT9YhA8lcqy59AdaZibn9iXZ7uQ+5/89sPDFaB4+oKaJmlXnUMC+zAfRwEMsIxjT/4uZkD8ZMaLgz8PUx3OFWgwPriYHhzb7SUrLcZ0Oq6gCfmSPJApXW+/p+0anzQEKwkyS3N1qnpOcitoB/pP0H5jzCP9Qvy9WIDCXzrVnzOFHiMvofELp9/NjexIay921k+yRran3zLBUxa18+w8DpfpNhhMkgWg04YRSY+Uhj7AOlrCczYInNmBNgnRz5zO5pebU+TOOuS3Jy3sJM7wPbWGrmXp7KsGR7hy4ve1N6m4T4hV0dMo6LeSinHBUGGLPkvyT+Iq/4HkfXtynocgOgmcnfWmWiUUfiBh967J4iduh02+0m/PtJ5SFWyFd54kAxcXi8M3pOhQPtltEhwcOdNVAGFVOEtBk3pp044+5tckSP+Je5XY8iYn0ZwSasVj4VwjMC09pgrQ3Hyvh4e7qSh5IYhl2fhNAiZwAN0UyYAQTxJWNHrSoV5AWEXHzUupD+TtGLXjz4ZRPJc+KydLWhWDBf2deIuDgpfaDjOwQWA5AW4oYQjHsAAMNYDD3BJTAcdSUzBL2+tdAqLYBYCcOafoO
Content-Type: multipart/alternative; boundary="_000_CO1PR13MB4920FAD081009F0F8E87001685B29CO1PR13MB4920namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR13MB4920.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76054879-160b-4c90-80e6-08db1ad54791
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2023 04:19:13.3818 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L+VkvweI77J6y/yWJH5wDLkQXXIKgqNqSSA/O/oIuGs6Nm7KFxjUQhlIhG+08jKZH29plowwnUxF/8iuXzDUNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR13MB5932
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/FLXrawH8aC5argGpXuHDI79gsbM>
Subject: Re: [Idr] Suggestion to use a more generic name for Topology-Type and ISP-sub-TLV in draft-ietf-idr-sdwan-edge-discovery-05
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2023 04:19:23 -0000

Victo,

Thank you very much for the comments and the suggestions.
See my reply inserted below:

Thanks, Linda

From: Shengcheng <shengcheng@huawei.com>
Sent: Tuesday, February 28, 2023 3:08 AM
To: draft-ietf-idr-sdwan-edge-discovery@ietf.org
Cc: idr@ietf.org
Subject: Suggestion to use a more generic name for Topology-Type and ISP-sub-TLV in draft-ietf-idr-sdwan-edge-discovery-05

Dear authors,

I have two comments:


1.      Section 6.1 (NLRI for SDWAN Underlay Tunnel Update) has a two octets field called "Topology-Type".  We think it is better to use a more generic name for this type to make it easier for future expansion.  We think using a generic type, such as "NLRI Type" or "Route-Type" is much better than the "Topology-Type".
[Linda] That is a good suggestion. RFC9015 (BGP for SFC) uses "Route Type" field to indicate different types of encoding carried in the NLRI. Maybe we can follow the tradition.
If we don't hear any objections, we will change the field name to "Route Type".


2.      The ISP-sub-TLV in the Section 6.4(Extended Port Attribute Sub-TLV)  is used for future expansion. We think it is better to change the name to a generic one, such as Transport-sub-TLV.
[Linda] good suggestion. "ISP-sub-TLV" was meant to carry information about the underlay network characteristics, such as bandwidth, access types, etc. Again, if we don't hear any objections, we can change the field name to "Transport -subTLV.



Thank you for the consideration.


Regards
Victo Sheng