[Idr] Rtgdir telechat review of draft-ietf-idr-rfc5575bis-20

Ines Robles via Datatracker <noreply@ietf.org> Wed, 15 April 2020 16:36 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: idr@ietf.org
Delivered-To: idr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C53113A0CDA; Wed, 15 Apr 2020 09:36:05 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Ines Robles via Datatracker <noreply@ietf.org>
To: <rtg-dir@ietf.org>
Cc: idr@ietf.org, last-call@ietf.org, draft-ietf-idr-rfc5575bis.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.127.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <158696856575.24074.9062191460091207808@ietfa.amsl.com>
Reply-To: Ines Robles <mariainesrobles@googlemail.com>
Date: Wed, 15 Apr 2020 09:36:05 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/Nnzets_2CFvinftSQQZiJUe_YK8>
Subject: [Idr] Rtgdir telechat review of draft-ietf-idr-rfc5575bis-20
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2020 16:36:06 -0000

Reviewer: Ines Robles
Review result: Has Nits

Review type: rtgdir - Telechat review
Requested version for review: 20
Deadline: 2020-04-15
Reviewer: Ines Robles

Summary:

This document defines a Border Gateway Protocol Network Layer Reachability
Information (BGP NLRI) encoding format that can be used to distribute traffic
Flow Specifications. It also specifies BGP Extended Community encoding formats.
This document obsoletes both RFC5575 and RFC7674.

 I found the document clear and complete. Some minor nits are detailed below.

  Major issues: Not found

  Minor issues: Not found

  Nits:

1- In the Introduction, it would be nice to mention how this draft obsoletes
RFC7674 and point to appendix B when referring obsoleting RFC5575.

For example, This document obsoletes "Dissemination of Flow Specification
Rules" [RFC5575], whose differences can be found in Appendix B. This document
obsoletes also "Clarification of the Flowspec Redirect Extended
Community"[RFC7674] due to this document includes.....

- please expand iBGP --> Internal BGP  (iBGP)

2- Section 4.2.1.1

in "a -  AND bit:..."
2.1 - "the previous term" refers to a component?
2.2 -nit: "...unset and and MUST..." => "...unset and MUST..."

3-nit Section 5: "...this draft specifies..." if it becomes RFC it would be
nice to read "..this document specifies.."

Thanks for this document,

Ines.