Re: [Idr] [idr] draft-ietf-idr-ls-distribution

Veerendranatha Reddy Vallem <veerendranatharv@huawei.com> Fri, 18 December 2015 03:59 UTC

Return-Path: <veerendranatharv@huawei.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 595331B32AE for <idr@ietfa.amsl.com>; Thu, 17 Dec 2015 19:59:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.854
X-Spam-Level:
X-Spam-Status: No, score=-1.854 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FB_ROLLER_IS_T=1.357, GB_SUMOF=1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ElWSUM2U5a8T for <idr@ietfa.amsl.com>; Thu, 17 Dec 2015 19:59:13 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93C361B32AD for <idr@ietf.org>; Thu, 17 Dec 2015 19:59:12 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml406-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CBS84482; Fri, 18 Dec 2015 03:59:10 +0000 (GMT)
Received: from SZXEML433-HUB.china.huawei.com (10.82.67.210) by lhreml406-hub.china.huawei.com (10.201.5.243) with Microsoft SMTP Server (TLS) id 14.3.235.1; Fri, 18 Dec 2015 03:59:08 +0000
Received: from szxeml561-mbx.china.huawei.com ([169.254.5.2]) by szxeml433-hub.china.huawei.com ([10.82.67.210]) with mapi id 14.03.0235.001; Fri, 18 Dec 2015 11:59:02 +0800
From: Veerendranatha Reddy Vallem <veerendranatharv@huawei.com>
To: "Acee Lindem (acee)" <acee@cisco.com>, Hannes Gredler <hannes@gredler.at>, Adrian Farrel <afarrel@juniper.net>
Thread-Topic: [Idr] [idr] draft-ietf-idr-ls-distribution
Thread-Index: AQHROJoUmDplxAYqNUiWiiQi1EqvAp7OmaoAgAGFbcA=
Date: Fri, 18 Dec 2015 03:59:01 +0000
Message-ID: <73BFDDFFF499304EB26FE5FDEF20F7884FCED9DC@szxeml561-mbx.china.huawei.com>
References: <73BFDDFFF499304EB26FE5FDEF20F7884FCED6E6@szxeml561-mbx.china.huawei.com> <4E7D0E05-D904-4461-9DEE-84B94FCC8894@cisco.com> <56725FDD.50606@gredler.at> <D2981724.44A93%acee@cisco.com>
In-Reply-To: <D2981724.44A93%acee@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.18.206.180]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.5673848E.00D8, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.5.2, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 8261c394572d032f95d60dc5bc5d9fe5
Archived-At: <http://mailarchive.ietf.org/arch/msg/idr/Wz4B_wv-jIm8FWisk2k2SKmDnic>
Cc: "idr@ietf.org" <idr@ietf.org>, "draft-ietf-idr-ls-distribution@tools.ietf.org" <draft-ietf-idr-ls-distribution@tools.ietf.org>
Subject: Re: [Idr] [idr] draft-ietf-idr-ls-distribution
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2015 03:59:16 -0000

Hi Acee,
Thanks for the clarification.

Regards,
Veerendranath

-----Original Message-----
From: Acee Lindem (acee) [mailto:acee@cisco.com] 
Sent: 17 December 2015 20:43
To: Hannes Gredler; Veerendranatha Reddy Vallem; Adrian Farrel
Cc: idr@ietf.org; draft-ietf-idr-ls-distribution@tools.ietf.org
Subject: Re: [Idr] [idr] draft-ietf-idr-ls-distribution

Hi Hannes, Veerendranatha,

This seems sensible. In essence, the BGP Speaker validation is confined to assure the Link-State NLRI and nested TLVs are not malformed including validating the lengths of known TLVs. Validation and interpretations of any values is left to the consumers of the NLRI.

Thanks,
Acee 

On 12/17/15, 2:10 AM, "Hannes Gredler" <hannes@gredler.at> wrote:

>hi acee,
>
>the fixed length check is only applied when the TLV is known.
>
>and i agree, some clarification that this only applies to the 'known' 
>would not hurt.
>
>/hannes
>
>On 12/16/15 23:16, Acee Lindem (acee) wrote:
>> Hi Veerandraanath,
>>
>> Section 6.2.2 lists the mandatory checking.
>>
>>>     If an implementation of BGP-LS detects a malformed attribute, 
>>>then it
>>>     MUST use the 'Attribute Discard' action as per [RFC7606] Section 2.
>>>
>>>     An implementation of BGP-LS MUST perform the following syntactic
>>>     checks for determining if a message is malformed.
>>>
>>>     o  Does the sum of all TLVs found in the BGP LS attribute 
>>>correspond
>>>        to the BGP LS path attribute length?
>>>
>>>     o  Does the sum of all TLVs found in the BGP MP_REACH_NLRI 
>>>attribute
>>>        correspond to the BGP MP_REACH_NLRI length?
>>>
>>>     o  Does the sum of all TLVs found in the BGP MP_UNREACH_NLRI
>>>        attribute correspond to the BGP MP_UNREACH_NLRI length?
>>>
>>>     o  Does the sum of all TLVs found in a Node-, Link or Prefix
>>>        Descriptor NLRI attribute correspond to the Node-, Link- or 
>>>Prefix
>>>        Descriptors 'Total NLRI Length' field?
>>>
>>>     o  Does any fixed length TLV correspond to the TLV Length field in
>>>        this document?
>> The last one is questionable since it is TLV code-point specific. As 
>> we enhance BGP LS, we certainly don’t want BGP speakers to drop LS 
>> NLRI identifiers or attributes that they don’t understand. However, 
>> we are probably too late to remove this check... ;^) Authors?
>>
>> Thanks,
>> Acee
>>
>>
>>> On Dec 15, 2015, at 9:32 PM, Veerendranatha Reddy Vallem  
>>><veerendranatharv@huawei.com <mailto:veerendranatharv@huawei.com>>
>>>wrote:
>>>
>>> Hi,
>>> Can you please help me understanding processing ofBGP-LS messagesby 
>>> transit nodes.
>>> Once BGP speaker receives the Update message with BGP Link state (it 
>>> may be intermediate/transit node), Whether BGP speaker need to 
>>> validate each  sub TLVs present in LS NLRI and Attributes before 
>>> sending the update to neighbor peers, even the speaker is not using 
>>> that data for processing?
>>> Example Topology:
>>>
>>>                
>>>                           Controller
>>>                                 AS1
>>>                                          AS2                        |
>>> BGP speaker1--------------BGP speaker 2--------------------------BGP 
>>> speaker 3 Now BGP speaker will send update information to BGP 
>>> speaker 2, intern forward the Update to BGP speaker 3, BGP speaker 
>>> will send that information to controller.
>>> Whether SGP speaker2, and BGP speaker 3 need to validate the Sub 
>>> TLVs present in LS-MPNLRI and LS-Attributes (even they will not 
>>> process the data, the data is opaque for those ), before sending 
>>> update to its peer or Only controller is enough to validate the 
>>> data, since controller is the consumer for the data present in LS information.
>>> Regards,
>>> Veerendraanath
>>> This e-mail and any files transmitted with it are for the sole use 
>>> of the intended recipient(s) and may contain confidential and 
>>> privileged information. If you are not the intended recipient(s), 
>>> please reply to the sender and destroy all copies of the original 
>>> message. Any unauthorized review, use, disclosure, dissemination, 
>>> forwarding, printing or copying of this email, and/or any action 
>>> taken in reliance on the contents of this e-mail is strictly 
>>> prohibited and may be unlawful. Where permitted by applicable law, 
>>> this e-mail and other e-mail communications sent to and from 
>>> Cognizant e-mail addresses may be monitored.
>>> _______________________________________________
>>> Idr mailing list
>>> Idr@ietf.org <mailto:Idr@ietf.org>
>>> https://www.ietf.org/mailman/listinfo/idr
>>