Re: [Idr] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
Vijay Gurbani <vijay.gurbani@gmail.com> Sun, 14 August 2022 01:30 UTC
Return-Path: <vijay.gurbani@gmail.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 125BDC14F719; Sat, 13 Aug 2022 18:30:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.105
X-Spam-Level:
X-Spam-Status: No, score=-2.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cY_S3prHIxvI; Sat, 13 Aug 2022 18:30:54 -0700 (PDT)
Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 17B30C14F723; Sat, 13 Aug 2022 18:30:51 -0700 (PDT)
Received: by mail-qk1-x72f.google.com with SMTP id b2so3385704qkh.12; Sat, 13 Aug 2022 18:30:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=mBULn9AE4SRRwh6L63GHJVFWy3hT6W85b9kEaDHlXrA=; b=N1OqVy8SItUmYRcPd0Hwm/EdGqc/nO42VtUDomM6hxUXIHAvwgFlZlkM0x4CiIfEJw 8jzcuKiocKsFcYFC0ia6P6T7WcKKXd9SPjpTwMBIEZqUshBvZpDcLgAWxy11vZ9rAjHw wLQSqq86yMHaLlHsgx5l+4q6vvOqG1jKVmv1JjgM+ZL7JTg3e8Go9tdBZgaXyE30AkAA XsuYsl3YfU6rMISo5GMfxNPkutctb5GwCN0vdNm03qWTseVGVufCF47vpJXrVp4jLQuC oBi57QEXdCqWYLY4Qj4bLPsqFjxI0iCkX60uBuG2PsqCxC2xaHR/pWOuy7U35yar9VFe fiCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=mBULn9AE4SRRwh6L63GHJVFWy3hT6W85b9kEaDHlXrA=; b=giJ75xqrC9oWH5/A18esGNtlUH/1buA+FT4wgV6FAhYx9a46R6dDz2hVMSd5JoKwPF 1FRwtPvAzTRWQNVTYbdTxYBwSQVs5ocy6oEfxZN3mgV68v3NQBekxPRNQctaoCHeEXnr jIwT91PMRlDBJO76V1K/kNGg+ploGaHWR/7OxTuqzSNQk/SQxivmoJyNa0nbrzGJm2Af V4OalsNqIeJieIvA6pQ+zDbvcxtf0YDw8/CnEWoX4LkWDPMEjNMQdnIzVZIJNjFMJq6N 8Cygz6IAlL5UXfqeDunLi4/WGzgkFPGyb8cVG+W1orpL52PPIQfzVaNTsMaSV9ZVgSOQ owSQ==
X-Gm-Message-State: ACgBeo0oIZEKjXnRgimtQEfs8yYQ6kTtwxHMXJyLBn8xzQvwa2Vg2Hkz ECssvT0orh8kIVOi85NsHgOCMrKntnc7LwZDiU3+P5nQ
X-Google-Smtp-Source: AA6agR5Kdnsmkap6bHy1L9BLA7/tpILNAKc4wlnvK6uAtiq0VyG07QJSJfTv2fIxwGVhrsrdXDtHIHOGOep30wgROzg=
X-Received: by 2002:a05:620a:4147:b0:6b5:e55c:194f with SMTP id k7-20020a05620a414700b006b5e55c194fmr7374102qko.309.1660440649911; Sat, 13 Aug 2022 18:30:49 -0700 (PDT)
MIME-Version: 1.0
References: <166033385333.7724.14555622442470360665@ietfa.amsl.com> <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com>
In-Reply-To: <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com>
From: Vijay Gurbani <vijay.gurbani@gmail.com>
Date: Sat, 13 Aug 2022 20:30:32 -0500
Message-ID: <CAMMTW_KKuY2DphishuXNpnW=yKr0_N4tTRVE3X=Hf5WfvFNANA@mail.gmail.com>
To: Ketan Talaulikar <ketant.ietf@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001bd1f105e629773a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/a6Fx50fukj3dU2J81eOhRy3xdSQ>
Subject: Re: [Idr] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Aug 2022 01:30:58 -0000
Dear Ketan: Sounds good. Thank you for your time attending to my comments. - vijay On Sat, Aug 13, 2022 at 12:26 AM Ketan Talaulikar <ketant.ietf@gmail.com> wrote: > Hi Vijay, > > Thanks for your review and please check inline below for responses. > > The changes discussed below would reflect in the next update of the > document. > > On Sat, Aug 13, 2022 at 1:20 AM Vijay Gurbani via Datatracker < > noreply@ietf.org> wrote: > >> Reviewer: Vijay Gurbani >> Review result: Ready with Nits >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please treat these comments just >> like any other last call comments. >> >> For more information, please see the FAQ at >> >> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >> >> Document: draft-ietf-idr-bgp-ls-flex-algo-?? >> Reviewer: Vijay K. Gurbani >> Review Date: 2022-08-12 >> IETF LC End Date: 2022-08-17 >> IESG Telechat date: Not scheduled for a telechat >> >> Summary: Draft is ready with nits for a Proposed Standard. >> >> Major issues: 0 >> >> Minor issues: 1 (please see below) >> >> Nits/editorial comments: 4 (please see below) >> >> Minor: >> - Sec. 3.6: Note that Type is "TBD" here. Should this be 1046, as shown >> in >> Table 1? (Or is the use of 1046 still under discussion?) >> > > KT> This allocation is currently under "Expert Review" - at this point, it > is a suggested code point. This will hopefully be completed soon and we > will update the document once done. > > >> >> Nits: >> - I note that certain acronyms --- IGP, NLRI, ASLA --- are not defined. I >> suspect that these are well-known in the community, hence need no >> definition. >> Just in case they are not, you may consider expanding the rare ones on >> first >> use. > > > KT> Ack. Fixed some of these acronyms that are not well-known on their > first use. > > >> - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so >> called because/ > > > KT> Fixed > > >> - Sec. 2: s/Definition(s) (FAD) advertised by a node >> is/Definition(s) (FAD) advertised by a node is (are)/ >> Reason: symmetry in the sentence construction >> > > KT> Fixed > > >> - Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes? >> > > KT> Fixed. > > Thanks, > Ketan > > >> >> Thanks. >> >> >> >>
- [Idr] Genart last call review of draft-ietf-idr-b… Vijay Gurbani via Datatracker
- Re: [Idr] Genart last call review of draft-ietf-i… Ketan Talaulikar
- Re: [Idr] Genart last call review of draft-ietf-i… Vijay Gurbani
- Re: [Idr] Genart last call review of draft-ietf-i… Ketan Talaulikar
- Re: [Idr] Genart last call review of draft-ietf-i… Vijay Gurbani
- Re: [Idr] [Last-Call] Genart last call review of … Lars Eggert