Re: [Idr] [RTG-DIR] RtgDir Review: draft-ietf-idr-error-handling-16.txt

"John G. Scudder" <jgs@juniper.net> Fri, 12 December 2014 14:38 UTC

Return-Path: <jgs@juniper.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D8F51ACD86; Fri, 12 Dec 2014 06:38:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LBpElT6U-Mqc; Fri, 12 Dec 2014 06:38:22 -0800 (PST)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0746.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::1:746]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53FBC1ACD7C; Fri, 12 Dec 2014 06:38:22 -0800 (PST)
Received: from msims-sslvpn-nc.jnpr.net (66.129.241.13) by CO2PR05MB730.namprd05.prod.outlook.com (10.141.228.15) with Microsoft SMTP Server (TLS) id 15.1.31.17; Fri, 12 Dec 2014 14:37:56 +0000
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: "John G. Scudder" <jgs@juniper.net>
In-Reply-To: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE28B326E3D@SZXEMA510-MBX.china.huawei.com>
Date: Fri, 12 Dec 2014 09:37:46 -0500
Content-Transfer-Encoding: quoted-printable
Message-ID: <F69F913F-3008-4C99-8500-F4A4CF2B04C3@juniper.net>
References: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE28B326E3D@SZXEMA510-MBX.china.huawei.com>
To: Mach Chen <mach.chen@huawei.com>
X-Mailer: Apple Mail (2.1878.6)
X-Originating-IP: [66.129.241.13]
X-ClientProxiedBy: CO2PR04CA034.namprd04.prod.outlook.com (10.141.240.162) To CO2PR05MB730.namprd05.prod.outlook.com (10.141.228.15)
X-Microsoft-Antispam: UriScan:;
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CO2PR05MB730;
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601003); SRVR:CO2PR05MB730;
X-Forefront-PRVS: 04238CD941
X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(377454003)(199003)(189002)(51704005)(24454002)(33656002)(69596002)(97736003)(82746002)(92566001)(77156002)(89996001)(83716003)(105586002)(106356001)(62966003)(68736005)(101416001)(20776003)(1720100001)(50986999)(76176999)(110136001)(21056001)(19580405001)(36756003)(77096005)(23676002)(64706001)(81156004)(107046002)(40100003)(57306001)(42186005)(50466002)(122386002)(4396001)(86362001)(120916001)(87976001)(31966008)(230783001)(46102003)(66066001)(47776003)(53416004)(99396003)(50226001)(104396002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:CO2PR05MB730; H:msims-sslvpn-nc.jnpr.net; FPR:; SPF:None; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:CO2PR05MB730;
X-OriginatorOrg: juniper.net
Archived-At: http://mailarchive.ietf.org/arch/msg/idr/iUO3aW-2nNFAbxffbQlg4-mAXX8
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>, "draft-ietf-idr-error-handling@tools.ietf.org" <draft-ietf-idr-error-handling@tools.ietf.org>, "idr@ietf.org" <idr@ietf.org>
Subject: Re: [Idr] [RTG-DIR] RtgDir Review: draft-ietf-idr-error-handling-16.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Dec 2014 14:38:27 -0000

Hi Mach,

Thanks for your review and comments. I will make the changes and issue a new version. Good catch on the RFC 5549 issue.

Regards,

--John

On Dec 12, 2014, at 2:51 AM, Mach Chen <mach.chen@huawei.com> wrote:

> Hello, 
> 
> I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir 
> 
> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. 
> 
> Document: draft-ietf-idr-error-handling-16.txt 
> Reviewer: Mach Chen 
> Review Date: Nov. 12, 2014 
> Intended Status: Standards Track
> 
> Summary: 
> This document is well written and easy to understand. I found some nits and one minor issue that I think should be resolved before publication.
> 
> Comments: 
> None.
> 
> Major Issues: 
> No major issues found. 
> 
> Minor Issues: 
> Section 7.3
> "The attribute is considered malformed if its length is not 4 [RFC4271]."
> 
> If only according to RFC4271, this is the case, but seems that RFC5549 allows that the length of Nexthop attribute can be either 4 or 16.
> 
> Nits: 
> Section 2.
> s/to handling/to handle
> 
> in the last bullet of the 4 approaches.
> s/must not/MUST NOT
> 
> Best regards,
> Mach
>