Re: [Idr] AD Review of draft-ietf-idr-bfd-subcode-04

Jeffrey Haas <jhaas@pfrc.org> Tue, 27 December 2022 22:10 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 71584C14CE30; Tue, 27 Dec 2022 14:10:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ztxuHf1zEVEx; Tue, 27 Dec 2022 14:10:04 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id D240BC14CE28; Tue, 27 Dec 2022 14:10:04 -0800 (PST)
Received: by slice.pfrc.org (Postfix, from userid 1001) id 789961E383; Tue, 27 Dec 2022 17:10:04 -0500 (EST)
Date: Tue, 27 Dec 2022 17:10:04 -0500
From: Jeffrey Haas <jhaas@pfrc.org>
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: Jeff Haas <jhaas@juniper.net>, draft-ietf-idr-bfd-subcode@ietf.org, Keyur Patel <keyur@arrcus.com>, idr-chairs@ietf.org, idr@ietf.org
Message-ID: <20221227221004.GG2719@pfrc.org>
References: <CAMMESswSY52NiU8WeH0q1bb7EBvbmBoStAtJFMa5f7cMtyvC+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMMESswSY52NiU8WeH0q1bb7EBvbmBoStAtJFMa5f7cMtyvC+A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/tXvnaN5tV4fpUacCcBW3WfQC5j0>
Subject: Re: [Idr] AD Review of draft-ietf-idr-bfd-subcode-04
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Dec 2022 22:10:05 -0000

Alvaro,

On Tue, Oct 25, 2022 at 12:47:39PM -0700, Alvaro Retana wrote:
> 75	1.  Introduction
> ...
> 93	   If a BGP speaker desires to have its connections terminate faster
> 94	   than the negotiated BGP Hold Timer can accommodate upon loss of
> 95	   connectivity with a neighbor, the BGP speakers can rely upon BFD is
> 96	   used to supply that faster detection.  When the BFD session state
> 97	   changes to Down, the BGP speaker terminates the connection with a
> 98	   NOTIFICATION message sent to the neighbor, if possible, and then
> 99	   close the TCP connection for the connection.
> 
> [nit] s/the BGP speakers can rely upon BFD is used to supply/it can
> rely upon BFD to supply

Edit covered by other response.  Please see next published version.

> [nit] s/close the TCP connection for the connection/closes the TCP
> connection for the session
> 
> Yes, I know "connection" is technically ok -- it just sounds redundant
> and maybe even confusing.  Just a nit.

Fixed.

-- Jeff