[Idr] Re: Jeff's review on draft-ietf-idr-vpn-prefix-orf-12
Wei Wang <weiwang94@foxmail.com> Fri, 23 May 2025 08:49 UTC
Return-Path: <weiwang94@foxmail.com>
X-Original-To: idr@mail2.ietf.org
Delivered-To: idr@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 397E12C31B72; Fri, 23 May 2025 01:49:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: 1.09
X-Spam-Level: *
X-Spam-Status: No, score=1.09 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.001, HELO_DYNAMIC_IPADDR=1.951, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (1024-bit key) header.d=foxmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzGcPKhl4Dtj; Fri, 23 May 2025 01:49:20 -0700 (PDT)
Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 6CF562C31B20; Fri, 23 May 2025 01:49:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1747990150; bh=zhT0iHVOCEJ/KoKvPcmgtHmTdG6UZnRvVn2aDJxro7k=; h=From:To:Cc:Subject:Date:References:In-Reply-To; b=kC6XQwIprHsQbemQDwKEWCuMucej+VGqSaep/vs3hVS8hVMiJXV4NKgR1yOR5WXwG WeircjTFNIxw6ZBILesPNmBODzLsTzfUgfh3v1OCE2EEI29dhM0WnHL/fr4FqG4RO3 g6Y7pgbJBR7FMWx38aXZz/66qphAaxtFAF9YdRmM=
X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg=
X-QQ-XMAILINFO: MDPfhejMR4aIkIpqMNSpOdZUqeRo72rDg7RpvocXk1Aqj8k9JU2hvmpFFcS3ab jREFOVmIzQDFxkPjWmZwkaIXmLbFxDzFbwZyUDN9hRe+ceGIVXvQQHdEQ3iVWHMXH2ah8U1MuQM8+ B+A97mEldE65D60VaBMiwfoK9zhMjLXcCYpxpaXqG05HtE+7AE0pHYOdgTPNvi03Kkp8Enh3w3vKe sH4JKAeI6cHlIfKO58x/BCAX71A1zpQzQhVWxvb6pCu06ndfjRArunKqUKfB5G8UZ8hRCecoul1+s xfPew23m9wsVm9JBGTK7jraI9IIzVKMbvcr5k3uVM8qPTqzZMOo2AJU4c50xtasf2d5AGbuX7GNr9 XgDfb9Fjwwz9PKWYkuwsBU+n/x9FRp+sIFFGFtBSEzkdS1mkgCs6wizqfHxi7w7wwC8ELSsK2DTvO 3uADPW0s76BQmVtlkde9w1KdNSM9aQpMrGV6A4kAhhKdM1ZZs8nHaW0srxSp420WOstBN09hTGjXP ojhZ8Nriu6Hj9Ppa8Oa0FBUmMNqWZehuyNmZ0MDldXoMCxavJbfqdYB7T8moDf+93tvxW81GLcu5A CUfv6JWdylIIfxXbUpfwv7VccwTBRJIbfXtPUFPA8Axz3xiBryJliC4jsf/SAxN/7ldG1vyFA3a6B 1toVzCvB01yFGajKwc7U2LNPNuVzGeDf+0dWy/rt7gZm1lg4Qz1+emkZphWbpq5Q7Z7vxaLDlAGiv 9fmzBMWj5pvQHpTgRmqP5X7Z1gc9NODSP/aPWo4O+uKJccBUT4WaCbIhq1jL0D4nB7j7q8NtajBqP 92kMtTD32R6Ee0nHwicWvLagsknuMysIE7OkZGf7DADNMiqOeV7i5x1WM55Lus4otFH/AFsAFtUrq pJghPE6w3BqqwOkCmF7/FCWuxLYkSq8P29qGWB33Tdoj/2168J/h1Uq6PD91kKPqfZxsnOVfUUH8f AqRQyk24zRek7VsmE/wVncTGLgZG+a5SKGYWow9L2TJbE4VxGE9SVSynfxXcW74P5TmZhSUStXXTg h/Lzr
From: Wei Wang <weiwang94@foxmail.com>
To: Jeffrey Haas <jhaas@pfrc.org>
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_68303683_6D2D7DA0_00A0ADCB"
Content-Transfer-Encoding: 8bit
Date: Fri, 23 May 2025 16:49:07 +0800
X-Priority: 3
Message-ID: <tencent_641DBDAE39B3F970B68ECC9F28F2B6D5F607@qq.com>
X-QQ-MIME: TCMime 1.0 by Tencent
X-Mailer: QQMail 2.x
X-QQ-Mailer: QQMail 2.x
References: <C1485F71-7D3A-4779-AAA1-586D77CE0AAF@pfrc.org> <tencent_5DB4A88EB6BCF655BDA5B9BA790EB6C9CC07@qq.com> <AD1DB299-9F64-4E58-8F0A-058E343902B4@pfrc.org>
In-Reply-To: <AD1DB299-9F64-4E58-8F0A-058E343902B4@pfrc.org>
X-QQ-mid: xmseza31-0t1747990147t7q4c7w8y
Message-ID-Hash: 4HROQTPRCKESY6HEENELCOQQMFY6ECZM
X-Message-ID-Hash: 4HROQTPRCKESY6HEENELCOQQMFY6ECZM
X-MailFrom: weiwang94@foxmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-idr.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-idr-vpn-prefix-orf <draft-ietf-idr-vpn-prefix-orf@ietf.org>, idr <idr@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [Idr] Re: Jeff's review on draft-ietf-idr-vpn-prefix-orf-12
List-Id: Inter-Domain Routing <idr.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/u_rxOpRHQ4fktoRVB39nGKrtioI>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Owner: <mailto:idr-owner@ietf.org>
List-Post: <mailto:idr@ietf.org>
List-Subscribe: <mailto:idr-join@ietf.org>
List-Unsubscribe: <mailto:idr-leave@ietf.org>
Hi Jeffrey, Thanks for your comments. We updated -v14 of draft-ietf-idr-vpn-prefix-orf:https://datatracker.ietf.org/doc/html/draft-ietf-idr-vpn-prefix-orf-14 And please see my in-line replies with [WW] Best Regards, Wei Wang China Telecom 原始邮件 发件人:Jeffrey Haas <jhaas@pfrc.org> 发件时间:2025年5月22日 21:54 收件人:Wei Wang <weiwang94@foxmail.com> 抄送:draft-ietf-idr-vpn-prefix-orf <draft-ietf-idr-vpn-prefix-orf@ietf.org>, idr <idr@ietf.org> 主题:Re: Jeff's review on draft-ietf-idr-vpn-prefix-orf-12 Wei Wang, Thanks for addressing my comments to date. A few more comments in this reply; > On May 22, 2025, at 2:37 AM, Wei Wang <weiwang94@foxmail.com> wrote: > Note that this section also updates route reflection procedures. This potentially means needing to flag "updates RFC 4456". > [WW]: In the end of this Section, we added the sentence “This section updates route reflection procedures, which means RFC4456 need to be updated.” Normally this would mean the document's status would be "update rfc 4456" as part of the RFC header. However, this is a good start to note the consideration while we discuss how it is finally resolved. [WW]: Thank you. We have added this information in -v14. > VPN Prefix Limit is defined here. Later on in section 7 it's discussed that this value is checked. However, there's no normative procedure that defines how the receiver of the ORF is to calculate whether a route counts versus a given prefix limit. > > Prior IDR list discussion had gone back and forth on whether this is tracked per RD, or per route-target. Even knowing that, it's not clear to me in the draft how it works. > [WW]: The description of VRF Prefix Limit has been changed to “VRF Prefix Limit: carrying the prefix limit of the overflowed VRF. This value is calculated based on RT(s) of the VRF. The VPN Prefix ORF receiver SHOULD stop sending VPN routes with RT(s) that contains in the VPN Prefix ORF entry. For the Source PE of a VPN Prefix ORF entry, once the number of qualifying VPN routes sent by the receiver of the VPN Prefix ORF entry to the Source PE has reached the VPN Prefix Limit, the receiver shall stop sending additional qualifying VPN routes to that Source PE.” If I were to restate this, the desire here is that the prefix-limit is the counter of BGP Routes that match the ORF. Is this correct? If so, that is clear. [WW]: Yes. What remains a challenge is when those filters are matched. This again becomes a question as to whether the sequence number is used to sort the ORFs. If the ORFs are sorted by sequence number rather than order that they are received, things are clear. However, it also means that if ORFs are added or removed, it becomes necessary to re-calculate the prefix-limits matched for that RIB-OUT for that set of ORFs. Is this the desired procedure? [WW]: Actually, the VPN Prefix Limit is calculated by the sender of the VPN Prefix ORF entry. Then, it is carried in the ORF entry and sent to the receiver. So the receiver does not need to re-calculate its value. > For your type 3 Source PE Identifier TLV, what is your procedure if the reflector that attached the ORIGINATOR attribute did not also attach the extended community? > [WW]: In Section 5, we defined the following procedures: > “For the RR/ASBR, it should perform as following: > • Check the existence of the SPE EC. If it exists, does not change it. > • If SPE EC does not exist, check the existence of ORIGINATOR_ID. If it exists, put it into SPE EC. > • If ORIGINATOR_ID does not exist, put the router-id of source PE into SPE EC.” > Based on the above contents, if the RR did not attach the extended community, the ASBR will attach it. Thanks for pointing out that section. For this ORF feature, a BGP speaker receiving an VPN ORF with the Source PE TLV, it is necessary for that router to have the impacted routes in its RIB-OUT toward the originator of the ORF. If the Source PE community was not already attached to the routes, this is also the device that SHOULD attach them. Documenting this process as part of the route receive process when the device supports this ORF may be the best way to document this procedure. [WW]: If the SPE EC is not attached to the BGP Update message of the VPN prefixes, the receiver should use NEXT_HOP or ORIGINATOR_ID as the originator of VPN Prefix to match against the VPN Prefix ORF entry. This information is claimed in the section 7 of -v14 as follows:“If the SPE EC is not attached to the BGP Update message of the VPN prefixes, the receiver should use NEXT_HOP or ORIGINATOR_ID as the originator of VPN Prefix to match against the VPN Prefix ORF entry.” > I suspect the intent here is that it's also an order in which this ORF type is evaluated. Is that the case? If so, text needs to be added covering that detail. > [WW]: We added the following sentence to the description of Sequence in Section 6: > “Sequence: identifying the order in which VPN Prefix ORF is generated. It can uniquely identify a VPN Prefix ORF entry together with AFI/SAFI, ORF-Type, and Route Distinguisher.” This text still does not address evaluation issues. It does discuss how the ORF entry is "keyed" for purposes of add/delete. To give an example, consider this order of events. I understand this example does not have the sequence numbers monotonically increasing as the "order it is generated". So, this could be a bug for the ORF sender to do this, but the receiver will still need to deal with it. Further, the above example explains the motivation for my questions: If the ORFs are processed in the received order (perhaps the sequence numbers are in correct order as well), then routes containing both RT Y and PE a.b.c.d will be permitted because it matches first. If the ORFs are processed in the sequential order, routes containing both RT Y and PE a.b.c.d will be denied. This shows the consequence of ordering. Now, consider that an implementation always generated monotonically increasing sequence numbers: Add seq=1, RD1, RT=Y permit Add seq=2, RD1, RT=Y, Source PE=a.b.c.d deny In this circumstance, the intent to match both RT Y and Source PE=a.b.c.d cannot be hit because the first rule takes effect. Further, the only way to get the second rule to take effect would be to delete the rules and resend with next sequence numbers like: Delete seq=1, RD1, RT=Y permit Delete seq=2, RD1, RT=Y, Source PE=a.b.c.d deny Add seq=N, RD1, RT=Y, Source PE=a.b.c.d deny Add seq=N+1, RD1, RT=Y permit But this would also require that the prior rules < N did not interfere with this intent. [WW]: As our reply for the last comment, the permit action only used by the last entry to allow other allowed VPN prefixes pass the filter. So the situation in the examples will not occur. The issue above is common with firewall configurations. When firewalls use sequence numbers for such programming, it's common practice to leave gaps in the numbering to permit reordering. Alternatively, management mechanisms that allow for insert operations are used. However, this is signaled in BGP and the only way to manage such ordering is to be explicit about it in the protocol. [WW]: Thank you for your comments. The sequence numbers can be discontinuous to facilitate the insertion of new rules at a later stage. We also added these contents to the Section 6. --- One final point, ORFs are expected to allow or deny all routes that pass through them. How is the default "allow" for routes not covered by the ORF encoded? Or, was the intent for it to be a default part of the procedure? [WW]: The purpose of VPN Prefix ORF is to block unwanted VPN prefixes, then the "action" of one valid entry should be set to "DENY". In order to allow other allowed VPN prefixes pass the filter, one default, last resort entry should be installed in advance in the VPN Prefixes ORF table, with the RD is set to 0 and the corresponding Sequence are set to 0xFFFFFFFF. We also give some clarifications in Section 6. -- Jeff
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Wei Wang
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Jeffrey Haas
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Wei Wang
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Jeffrey Haas
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Jeffrey Haas
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Wei Wang
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Jeffrey Haas
- [Idr] Re: Jeff's review on draft-ietf-idr-vpn-pre… Wei Wang