Re: [Ietf-and-github] WGLC for draft-ietf-git-using-github

David Schinazi <dschinazi.ietf@gmail.com> Tue, 03 December 2019 19:41 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: ietf-and-github@ietfa.amsl.com
Delivered-To: ietf-and-github@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 17EF61200D8 for <ietf-and-github@ietfa.amsl.com>; Tue, 3 Dec 2019 11:41:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nH1JloqhuRqK for <ietf-and-github@ietfa.amsl.com>; Tue, 3 Dec 2019 11:41:00 -0800 (PST)
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D2AB41200B4 for <ietf-and-github@ietf.org>; Tue, 3 Dec 2019 11:40:59 -0800 (PST)
Received: by mail-lf1-x12f.google.com with SMTP id 203so3963526lfa.12 for <ietf-and-github@ietf.org>; Tue, 03 Dec 2019 11:40:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ujqMLegRNxhbGe4+89A9FYbgn+Mb7pvGUSvl7kGdM4s=; b=oCgr09ABiYDDxDmWyMwPUpXnieHPYztYo+Aqa4zdAGah11+c/8QEXUYpqu2EMbOnLW v3h454UuwRFNuEb6e8I0NgF0+ZiVziQQ9y8jx0RX58XayK3n5y7ID/g51ZsMlShrjEt5 XpJRNL9pOVydhNxwc+PbsVsoaz1xLgZeOqJnHTImOKn0E57tt9nammwihJXhMO/QZ21c qcvN/SNZTdXH+3mH17SuQwrKhejGHCNqOhaMH3XxK8SjUHQ6DC5/c0CTNTobNLW38HSY vWioJDzsPMunPkWsXGeK30CDeFyIzHfj1oqkzSUHRaPQtgQaeyNkVt9L6pF/eBwjFXL9 T6cQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ujqMLegRNxhbGe4+89A9FYbgn+Mb7pvGUSvl7kGdM4s=; b=NRnrzzi3uv9HJTAuZWxbJdWE+wkPHy9bnUZAKcpTmnGZMGH+5yd9Lg5iZc5G6vBju6 9cG4dnpqze/vEx/StY9J9kN5VRRa2Rglh4vBjmu0QGbJVBNNuB/4e0D/Bx2Sv4+xLJbM ztaZCC7WCtgxFcOmU4ig0PbenVuycRwAIiZXDAZ4nTV2qwZPPcVVCDuNZ6moh5p/AFN7 HM8ivA2uaw/MqqQS0V+Zfu4pZeLR+WwQbxzHeahkCY9PhhG3e/vHnRRexzkmi5MTpMlk 0GZm5UbKF6AcS/V/NLOCzCBrtx6d6sdvguh2sAuuBfXGyFJeBV1uXQ6m72F5Tjqp+zv4 ZwDA==
X-Gm-Message-State: APjAAAUSDvVxju5Cijbat9E6YX7bvyVtmmfbY9la26FxaYjfhtJ3v7K/ +8jEKEaEf2+FonHjtfXX+ND4Hd30KgPwKZ8djZ0=
X-Google-Smtp-Source: APXvYqwuueS2lHXLOtyDokrzKknrLPgHrWuAf7I3XASlY8rmAxnqL6vk9VD9iXC51dJn5kXmsaMbBMf9oIyRWl8UcHs=
X-Received: by 2002:a19:5f45:: with SMTP id a5mr3857544lfj.10.1575402057957; Tue, 03 Dec 2019 11:40:57 -0800 (PST)
MIME-Version: 1.0
References: <d61508a2-74c0-448b-94a0-52d8b0f64285@www.fastmail.com> <E192F154-C83A-46FE-AE4D-149F02C7D287@akamai.com>
In-Reply-To: <E192F154-C83A-46FE-AE4D-149F02C7D287@akamai.com>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Tue, 03 Dec 2019 11:40:47 -0800
Message-ID: <CAPDSy+4yE26hZg-BEy0fCsuAGVjvZj4Hgdeb4mF8A=oQrf3J_w@mail.gmail.com>
To: "Salz, Rich" <rsalz@akamai.com>
Cc: Christopher Wood <caw@heapingbits.net>, "ietf-and-github@ietf.org" <ietf-and-github@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000000b06fe0598d1e0d0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf-and-github/Kh0JL44X-dpa3ekBLAs8cH_MkdM>
Subject: Re: [Ietf-and-github] WGLC for draft-ietf-git-using-github
X-BeenThere: ietf-and-github@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of using GitHub in IETF activities, particularly for Working Groups" <ietf-and-github.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf-and-github/>
List-Post: <mailto:ietf-and-github@ietf.org>
List-Help: <mailto:ietf-and-github-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Dec 2019 19:41:03 -0000

Thanks for writing this document. I think it's helpful and support
publication if one issue is resolved:
any chance the authors could rewrite section 10 with less sarcasm? I'm all
for humor but I think this
joke has served its purpose and doesn't necessarily need to land in the
published BCP.

Thanks,
David

On Tue, Dec 3, 2019 at 10:56 AM Salz, Rich <rsalz@akamai.com> wrote:

> Some comments I'd like to see addressed before existing WGLC.
>
> I dislike the draft's use of the word "proven," and would prefer
> constructs like "demonstrably" or "shown to be" etc.  I could live with the
> others, but the use in the Introduction section really needs to be fixed.
> I guess my dislike is that it could be taken by some as being needless
> confrontational, and we've already proven (heh) that this topic has some
> controversy.
>
> The phrase "source control" in the Intro should be "version control"
>
>  Near the end of page 3 (pagination in text format, sorry not sorry :) the
> phrase "avoid issues" should be "help WG chairs avoid issues" I think.
>
> Sec 1.1 should explain why this is cool.  It allows several types of
> workflow to be used and changed. For example, authors collaborating,
> pushing changes to a WG repo, etc.
>
> Sec 1.3 "bitbuckey *and* gitlab"
>
> Sec 2.1, I prefer "ietf-wg-XXXX", top-down style, not intermixed.  Blue
> bikesheds rule. But it also follows the draft-ietf-<wg>- naming style.
>
> Sec 3.1, Last sentence, about link from README to CONTRIBUTING. Should
> that be a SHOULD and written in active-voice?
> At the end of 3.1, can you give an "anti-pattern" (we used to say
> counter-example I guess) of what would be something unfustifiably
> constraining?
>
> Sec 3.2, "draft-ietf-<wg>-" should that be "draft-ietf-<wgname>-" ? I
> think using one term throughout is better.
>
> Sec 3.3 "unless with prior..." reads better as "without prior" I think.
>
> Sec 4.1.2 if restrictions on closing are changed, is this a change in
> policy that must be communicated and the WG agree to? Or is this something
> to include in the initial policy and if so, is there guidance in this
> document for that?
>
> Sec 4.2  Should this mention that PR's can be updated by pushing new
> commits to the originating repo?  This lets PR's evolve in response to WG
> discussion.
>
> Sec 4.3 "requires *email* server infrastructure" ?
>
> Sec 5.2, near the end.  :communication about the work of the group from
> the *Working Group* mailing list." ?
>
> Sec 5.4.1, flip the design and editorial pragraphs?  Matches the structure
> of increasing difficulty?  Not a big deal, freel free to ignore.
>
> Sec 6, makes the document available "to a wider *IETF* audience" ?
>
> Sec 7, top of page 19.  "If permitted" maybe mention "by the Working Group
> policy" ?  Fine if you think that's redundant.
>
> Sec 8, "changes to a document" should be "repository" ? Add "These
> services are generally available at no cost" ?
>
> Sec 9 uses "you" language. Should that change to "Editor" language?
> "Create a new issue for them"  And add a comment pointing to the issue and
> directing discussion there?
>
> Sec 10.  Ha.
>
> Sec 13.  Gh-config appears both normative and non-nomative
>
> Sec A2 top of p 25  No "seem to lose" about it.  The lose sender info,
> which makes it useless.
>
> Appendix B needs to add authors for A3 and A4
>
>
>
> _______________________________________________
> Ietf-and-github mailing list
> Ietf-and-github@ietf.org
> https://www.ietf.org/mailman/listinfo/ietf-and-github
>