Re: [Ietf-and-github] Seeking feedback on draft-ietf-git-using-github and Git tutorial

Tommy Pauly <tpauly@apple.com> Fri, 04 October 2019 23:56 UTC

Return-Path: <tpauly@apple.com>
X-Original-To: ietf-and-github@ietfa.amsl.com
Delivered-To: ietf-and-github@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8658112006B for <ietf-and-github@ietfa.amsl.com>; Fri, 4 Oct 2019 16:56:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=apple.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ZQX2oOrR7gQ for <ietf-and-github@ietfa.amsl.com>; Fri, 4 Oct 2019 16:56:45 -0700 (PDT)
Received: from nwk-aaemail-lapp01.apple.com (nwk-aaemail-lapp01.apple.com [17.151.62.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C429412004D for <ietf-and-github@ietf.org>; Fri, 4 Oct 2019 16:56:45 -0700 (PDT)
Received: from pps.filterd (nwk-aaemail-lapp01.apple.com [127.0.0.1]) by nwk-aaemail-lapp01.apple.com (8.16.0.27/8.16.0.27) with SMTP id x94NqSwk047315; Fri, 4 Oct 2019 16:56:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=sender : content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=RB5UuJLXm72ubReYvAZnY3ANJI8LFQE8TcwYWAdz2XM=; b=EozXJBkdscVNXBXi1+Wb9uri8Bc0TR0gn/KY0+oYrYMZG6VGFcBHM/SqpU8hsIk09XBo 4IuVmzJXW5ePJp8VMGeYj5eZHyxUGLTqJbjNfcMjsqHzCMsfSY4T9eejI9x2Q7630Q2S r6zCoF9eTUkD9kgjraTqjNHeLw1nY6A9XmlCPmCfovx2CeZyJpXU7DtzjYpjJCa6f+wt dkU5NnScbjsjsnE5LcG+CjDZ56xu/OjUy4exrW+hXVGOjLPCZns0N4MahXoKEWnkbj8p GlaiXIS7iiIMBdZEBqxl8HiJPWRSTgrJFvPtbnhh8En/Bpr7Fil1MPf7MwBcOIY8oGAT Ew==
Received: from ma1-mtap-s03.corp.apple.com (ma1-mtap-s03.corp.apple.com [17.40.76.7]) by nwk-aaemail-lapp01.apple.com with ESMTP id 2va6f426kt-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 04 Oct 2019 16:56:42 -0700
Received: from nwk-mmpp-sz10.apple.com (nwk-mmpp-sz10.apple.com [17.128.115.122]) by ma1-mtap-s03.corp.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPS id <0PYV00B2OJUEJF70@ma1-mtap-s03.corp.apple.com>; Fri, 04 Oct 2019 16:56:40 -0700 (PDT)
Received: from process_milters-daemon.nwk-mmpp-sz10.apple.com by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) id <0PYV00G00JT1KA00@nwk-mmpp-sz10.apple.com>; Fri, 04 Oct 2019 16:56:39 -0700 (PDT)
X-Va-A:
X-Va-T-CD: 4e47a5d768d991b9320fecfde9b468c4
X-Va-E-CD: 3f3372be9695a48eaf3b8c2e95d396c3
X-Va-R-CD: ea3449823854b0d2f11557b2dd57fcde
X-Va-CD: 0
X-Va-ID: 6a72f977-ec2b-409e-9a3a-bfa22ef10288
X-V-A:
X-V-T-CD: 4e47a5d768d991b9320fecfde9b468c4
X-V-E-CD: 3f3372be9695a48eaf3b8c2e95d396c3
X-V-R-CD: ea3449823854b0d2f11557b2dd57fcde
X-V-CD: 0
X-V-ID: 941c6428-40ad-4aa2-be67-3fa93ae1d78a
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-04_14:,, signatures=0
Received: from [17.230.133.244] by nwk-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.4.20190507 64bit (built May 7 2019)) with ESMTPSA id <0PYV00JEXJUFSX70@nwk-mmpp-sz10.apple.com>; Fri, 04 Oct 2019 16:56:39 -0700 (PDT)
Sender: tpauly@apple.com
Content-type: text/plain; charset="us-ascii"
MIME-version: 1.0 (Mac OS X Mail 13.0 \(3594.4.17\))
From: Tommy Pauly <tpauly@apple.com>
In-reply-to: <81307dc9-b275-4305-84d8-3a602ab271f5@www.fastmail.com>
Date: Fri, 04 Oct 2019 16:56:35 -0700
Cc: ietf-and-github@ietf.org
Content-transfer-encoding: quoted-printable
Message-id: <BBCDB401-F370-419B-824D-74067EAD7F0F@apple.com>
References: <81307dc9-b275-4305-84d8-3a602ab271f5@www.fastmail.com>
To: Christopher Wood <caw@heapingbits.net>
X-Mailer: Apple Mail (2.3594.4.17)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-10-04_14:, , signatures=0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf-and-github/hkPuyoMnmALHdD_HzVSm5iQSPIo>
Subject: Re: [Ietf-and-github] Seeking feedback on draft-ietf-git-using-github and Git tutorial
X-BeenThere: ietf-and-github@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Discussion of using GitHub in IETF activities, particularly for Working Groups" <ietf-and-github.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf-and-github/>
List-Post: <mailto:ietf-and-github@ietf.org>
List-Help: <mailto:ietf-and-github-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf-and-github>, <mailto:ietf-and-github-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Oct 2019 23:56:49 -0000

The document looks good and reads well! I think the content all makes sense.

I did find a few nits in my review, which I've created a PR to fix here: https://github.com/ietf-gitwg/using-github/pull/18

The one content change I propose is to change:

"All repositories for working group documents MUST be public."

To:

"All repositories for Working Group documents within the Working Group
organization MUST be public."

The sentence previously seemed to also include a requirement on working group documents for working groups not officially using GitHub; I don't think we can make a requirement for people who happen to use a private GitHub repo to manage a working group document that's not officially using GitHub.

Thanks!
Tommy

> On Oct 4, 2019, at 1:32 PM, Christopher Wood <caw@heapingbits.net> wrote:
> 
> Hi folks,
> 
> As we approach Singapore, it would be quite useful to get more feedback on draft-ietf-git-using-github, especially with the changes merged in September. You can view the editor's copy here:
> 
>   https://ietf-gitwg.github.io/using-github/draft-ietf-git-using-github.html
> 
> (I'm sure an updated version in the datatracker will come shortly.)
> 
> To accompany this document, we also put together a tutorial for people new to Git(Hub) and its use for IETF draft development:
> 
>   https://ietf-gitwg.github.io
> 
> It aims to help IETF contributors get started with the system, Martin's excellent i-d-template toolchain, and GitHub for the purposes of supporting the different Modes of Interaction described in draft-ietf-git-using-github.
> 
> Please have a look at this material and provide feedback! We would like to finish draft-ietf-git-using-github in (or before) Singapore.
> 
> Thanks,
> Chris (chair hat on)
> 
> _______________________________________________
> Ietf-and-github mailing list
> Ietf-and-github@ietf.org
> https://www.ietf.org/mailman/listinfo/ietf-and-github