Re: Last Call: <draft-nottingham-rfc5988bis-05.txt> (Web Linking) to Proposed Standard

Mark Nottingham <mnot@mnot.net> Thu, 18 May 2017 06:30 UTC

Return-Path: <mnot@mnot.net>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60BDB12EBBD for <ietf@ietfa.amsl.com>; Wed, 17 May 2017 23:30:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.72
X-Spam-Level:
X-Spam-Status: No, score=-2.72 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mnot.net header.b=amdN20/7; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=aM9u33/a
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8tnXqefcPqxD for <ietf@ietfa.amsl.com>; Wed, 17 May 2017 23:30:09 -0700 (PDT)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1349B12947F for <ietf@ietf.org>; Wed, 17 May 2017 23:25:20 -0700 (PDT)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 776DDEE6; Thu, 18 May 2017 02:25:19 -0400 (EDT)
Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Thu, 18 May 2017 02:25:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mnot.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=koTB8/UNgLJG44jk80 n+beFiAtkr/MNn3nnfafFZe4U=; b=amdN20/72sYJ7ooPebCghHAkug/hZpFuO4 ANrS0RIBwAhb9dZBQBpauFvfFDECHPbkTNFgzodg+QBzvSKIMFGgHGvC4fKDn121 K98ySJiGhaXx7gWFlsuC8RWSN8ETdWfmNwaZXWOWzTAmEW9/tvx+TsRYo9P/xjud YoTaJeH1sXrjowFRzeyJ2AvQBxb+71Q04dTciquSmHqOky30jv9vG5Mkcm10Ru0w Os1DNfvUpL766T796dnANahk3wS/1nyFk+BRCAjqMGF+z/IhYNzKDfNZIJhgJsuE s11kA7t21XFTOr0eWcnPk35i+NFZfbXaPpYDzfZdV8DohimQkXTg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=koTB8/UNgLJG44jk80n+beFiAtkr/MNn3nnfafFZe4U=; b=aM9u33/a Jwuni1qhm1/aIQQy3CzxFWJf5VgQkj1ciUSVEkUjs+MKQhQ70htK4LqCjzi6eOoV RyPPqCOArJHvCJLOxJ0LxvnNUJK48F1Cw277PO1Rvo4j/16aRQMHtmiBo9jtD6zU drgS01cJg7bhBmvG54K6BHP43KBMvo9hePSzoQtLFHg6cjx2p7N0FGD0Jevg+7NB xS4OLP0eemYNVogPJsMtzs1NZNTEwHWWwP4uJn/HYhzg9LeBS9W2asdFuBgJIK9L CdQmegBhAk3e70ToOUVt/TS6xxtPCTvmR+LDohbl9n/amPXmiypii8Os+in6HrUO YBU7hDJpsyVt1g==
X-ME-Sender: <xms:Tj4dWec0tA323EK-OIVcbHxbQL3bNmDoVCqYuYeLyW6pOlRiRt-93g>
X-Sasl-enc: ityMd+1x35Q+u9vIUNV93B0AoeFfdIwWuCJE3+MH6SpK 1495088718
Received: from [192.168.1.18] (cpe-124-188-19-231.hdbq1.win.bigpond.net.au [124.188.19.231]) by mail.messagingengine.com (Postfix) with ESMTPA id 851277E6E5; Thu, 18 May 2017 02:25:17 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Last Call: <draft-nottingham-rfc5988bis-05.txt> (Web Linking) to Proposed Standard
From: Mark Nottingham <mnot@mnot.net>
In-Reply-To: <9f065b23-59bc-fb1d-6d2d-434d0253475c@gmx.de>
Date: Thu, 18 May 2017 16:25:16 +1000
Cc: IETF Discussion Mailing List <ietf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7BB9FE83-8009-405C-8F0B-CA867061DD24@mnot.net>
References: <588716b3-161c-62ac-e5a9-a04c86f13e86@gmx.de> <704BC987-1ED0-4E59-A803-0B4013A86F03@mnot.net> <c81eb293-f443-8d61-bd82-b7c2902e4426@gmx.de> <09EA3303-8F65-4FDE-8303-8C2AD9B8B897@mnot.net> <280366F3-ECDA-44A2-820A-33FD5965EAFD@mnot.net> <5b94ecb4-b317-38ec-aa10-dc166faac5d0@gmx.de> <77A93621-A2F2-4D15-AE00-EFB6CBDD5C3E@mnot.net> <9f065b23-59bc-fb1d-6d2d-434d0253475c@gmx.de>
To: "Julian F. Reschke" <julian.reschke@gmx.de>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/9LfLra7zB3nx7UcOZPC1YViZdyY>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 May 2017 06:30:12 -0000

See changes:
  https://github.com/mnot/I-D/commit/143403a2e7e37

In situ:
  https://mnot.github.io/I-D/rfc5988bis/


> On 18 May 2017, at 3:02 pm, Julian Reschke <julian.reschke@gmx.de> wrote:
> 
> On 2017-05-18 05:22, Mark Nottingham wrote:
>> 
>>> On 17 May 2017, at 8:41 pm, Julian Reschke <julian.reschke@gmx.de> wrote:
>>> 
>>> On 2017-05-16 04:37, Mark Nottingham wrote:
>>>> ...
>>>> This is what I currently have:
>>>> https://gist.github.com/mnot/2fb569e7303dbcdde8b27cb7a404a648
>>>> 
>>>> I need to get some more eyeballs onto it to make sure it's correct (or at least reasonable). Reviews appreciated.
>>>> ...
>>> 
>>> I think this goes into the right direction; it's mostly a parser based on a relaxed ABNF transformed to prose (which makes me wonder whether there's a tool to be written here :-).
>>> 
>>> Other comments:
>>> 
>>> 1)  "... If it is not present, context_string is the identity of the representation carrying the Link header ..." - similar prose is elsewhere in the spec - what is "the identity of a representation"?????
>> 
>> See the linked reference. Would it be better to use "URL" instead of "identity"?
> 
> URL (or URI).
> 
>>> 2) "Consume the contents up to but not including the first DQUOTE character that is not preceded by a "" character" - I assume there's a backslash missing here. That said: doesn't work, because it would fail for an input such as: "\\" - here, the DQUOTE is preceded by backslash, but it's not part of the quoted-pair.
>> 
>> I've updated to address this.
> 
> Goes into the right direction, but doesn't seem to be correct yet:
> 
>> 4. While input has content:
>> 
>>    i. If the first character is a backslash ("\"):
>> 
>>        1. Discard the first character.
>> 
>>        2. If there is no more input, return output.
>> 
>>        3. Else, consume the first character and append it to output.
>> 
>>    ii. Else, if the first character is DQUOTE, discard it and return output.
> 
> There seems to be missing a step between (i) and (ii) for non-quoted-pairs.
> 
> Best regards, Julian

--
Mark Nottingham   https://www.mnot.net/