RE: Review of draft-ietf-tram-turn-server-discovery-08

"Tirumaleswar Reddy (tireddy)" <tireddy@cisco.com> Wed, 07 September 2016 03:34 UTC

Return-Path: <tireddy@cisco.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C49A612B036; Tue, 6 Sep 2016 20:34:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.028
X-Spam-Level:
X-Spam-Status: No, score=-16.028 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.508, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rs2YiXf6K_dr; Tue, 6 Sep 2016 20:34:54 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9ECEF12B016; Tue, 6 Sep 2016 20:34:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=14236; q=dns/txt; s=iport; t=1473219294; x=1474428894; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=4H46taFBdziUoJ11+q5pG/z2hpwYBzqsDWyAGBF31q4=; b=bS0OHfau79rFhXj8tHUKHGk7dlS8aP8paGjtZ6kdKlwsTZv8yfyzdc42 NXE9WmeTvbKyw03wn4FQwD6BrMi1Qnh5BANU5eHwHi1d3Ci0HtgSjcsD5 Ubn8Dyz5wuI3w7e7/4uUAJYrrmydsFjo/nsLUzXLN8R0GyIr7L9kDD42D 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BUAQAIis9X/5pdJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBgnozAQEBAQEeV3wHjSieVocphQ2CAiiFdAIcgUY4FAECAQEBAQEBAV4nhGE?= =?us-ascii?q?BAQEEIwpMEAIBCA4DBAEBKAMCAgIfERQJCAIEAQ0FCAGIJwMXDq9wiRANgwwBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAQEBAQEBAQEchi+EToJDgWdMCIJEgloFjiaKezUBhiGGPoJ?= =?us-ascii?q?RgXVOhBCJD4hDCYQCg3kBHjaET3ABAYUxfwEBAQ?=
X-IronPort-AV: E=Sophos;i="5.30,295,1470700800"; d="scan'208,217";a="148996320"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2016 03:34:53 +0000
Received: from XCH-ALN-020.cisco.com (xch-aln-020.cisco.com [173.36.7.30]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u873YrmG005578 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 7 Sep 2016 03:34:53 GMT
Received: from xch-rcd-017.cisco.com (173.37.102.27) by XCH-ALN-020.cisco.com (173.36.7.30) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 6 Sep 2016 22:34:52 -0500
Received: from xch-rcd-017.cisco.com ([173.37.102.27]) by XCH-RCD-017.cisco.com ([173.37.102.27]) with mapi id 15.00.1210.000; Tue, 6 Sep 2016 22:34:53 -0500
From: "Tirumaleswar Reddy (tireddy)" <tireddy@cisco.com>
To: Ralph Droms <rdroms.ietf@gmail.com>, Jari Arkko <jari.arkko@piuha.net>
Subject: RE: Review of draft-ietf-tram-turn-server-discovery-08
Thread-Topic: Review of draft-ietf-tram-turn-server-discovery-08
Thread-Index: AQHR8oVKfQIfH+cg20y9OerS02OxwKBNCDGAgAE/gwD///Oi0IAWgrSAgAAyZACACJqX0A==
Date: Wed, 7 Sep 2016 03:34:52 +0000
Message-ID: <3f00a2b2173b4c3794c39349ba21aa84@XCH-RCD-017.cisco.com>
References: <7194DC7F-E802-42B2-AA6C-94D02167D89D@gmail.com> <89c07464407c404ea8543bcb3c3dc88e@XCH-RCD-017.cisco.com> <2EE5CFE0-F2A9-40AE-AAF2-D5DAFEA614CF@gmail.com> <8de72f2dba854efea00cd49d2b4d7923@XCH-RCD-017.cisco.com> <F08210DA-F45B-4AE7-8824-5E989310E855@piuha.net> <C4DE113C-E570-4E31-A660-765DC2406596@gmail.com>
In-Reply-To: <C4DE113C-E570-4E31-A660-765DC2406596@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.65.64.100]
Content-Type: multipart/alternative; boundary="_000_3f00a2b2173b4c3794c39349ba21aa84XCHRCD017ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/A171to6E79BAD-Fp690w3Y-QaNE>
Cc: "draft-ietf-tram-turn-server-discovery.all@ietf.org" <draft-ietf-tram-turn-server-discovery.all@ietf.org>, "Review Area gen-art@ietf.org Team" <gen-art@ietf.org>, IETF discussion list <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Sep 2016 03:34:57 -0000

Hi Ralph,

Please see inline [TR]

From: Ralph Droms [mailto:rdroms.ietf@gmail.com]
Sent: Thursday, September 1, 2016 4:36 PM
To: Jari Arkko <jari.arkko@piuha.net>
Cc: Tirumaleswar Reddy (tireddy) <tireddy@cisco.com>om>; draft-ietf-tram-turn-server-discovery.all@ietf.org; Review Area gen-art@ietf.org Team <gen-art@ietf.org>rg>; IETF discussion list <ietf@ietf.org>
Subject: Re: Review of draft-ietf-tram-turn-server-discovery-08

RI just completed a quick review of draft-ietf-tram-turn-server-discovery-08.  The DNS Service Discovery section is much improved.  I have a couple of comments on the revised text:


I suggest adding a reference to the IANa "Service Name and Transport Protocol Port Number Registry", http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=Turn, as the source of the service  names "turn" and "turns".

[TR] Will refer to RFC5766 which introduced the above service names.

While the example DNS records for "exampleco TURN Server" are technically correct, they would most likely be generated by the DNS-SD/mDNS library in a server, rather than appearing in a DNS server zone file somewhere.  For clarity, it might be better to use the unicast DNS versions of the DNS-SD records by substituting "example.com<http://example.com>" for "local".

[TR] May be I am missing something, https://tools.ietf.org/html/rfc6763#section-4.1.1 says the instance name will not be machine-generated and will be a user-friendly name.

In my opinion, the details in section 5.1 are redundant with and (possibly) not identical to the specification in RFC 6762 and RFC 6763.  Specifically, Figure 1 includes a typo; there should be separate A/AAAA query and reply messages.  More generally, DNS-SD/mDNS servers may return the SRV, TXT, A and AAAA records in the first reply, as an optimization.  I think it would be better, in this document, to specify simply that TURN servers and clients use the message exchanges specified in those RFCs for TURN server discovery.

[TR] Sure, will remove the figure.

Thanks and Regards,
-Tiru



- Ralph


On Sep 1, 2016, at 4:05 AM, Jari Arkko <jari.arkko@piuha.net<mailto:jari.arkko@piuha.net>> wrote:
Ralph, Tiru — thanks for the updates and the review. I’ve looked at the change draft and I think it is fine now.

Jari