Intdir early review of draft-ietf-tictoc-1588v2-yang-07

Dave Thaler <dthaler@microsoft.com> Thu, 14 June 2018 21:59 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Dave Thaler <dthaler@microsoft.com>
To: int-dir@ietf.org
Cc: draft-ietf-tictoc-1588v2-yang.all@ietf.org, ietf@ietf.org, tictoc@ietf.org
Subject: Intdir early review of draft-ietf-tictoc-1588v2-yang-07
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152901355790.26571.11611749129899888335@ietfa.amsl.com>
Date: Thu, 14 Jun 2018 14:59:17 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/RoX7s6l3K3eNotMADj-LHRvOVIc>

Reviewer: Dave Thaler
Review result: Ready with Nits

I have reviewed draft-ietf-tictoc-1588v2-yang-07 as assigned int-dir reviewer.
The draft was readable and technically good (though I am not an expert on
either YANG or IEEE 1588-2008. I do have a number of nits indicated in the
marked up copy at
https://www.microsoft.com/en-us/research/uploads/prod/2018/06/draft-ietf-tictoc-1588v2-yang-07.pdf

The most notable piece of feedback is that it's not clear what the units are
for several integer objects.

Dave

RE: Intdir early review of draft-ietf-tictoc-1588… Jiangyuanlong
Intdir early review of draft-ietf-tictoc-1588v2-y… Dave Thaler