Re: Gen-ART Review for draft-ietf-lisp-crypto-09

Dino Farinacci <farinacci@gmail.com> Fri, 14 October 2016 13:15 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E7BB127058; Fri, 14 Oct 2016 06:15:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9HZlBwP-IjD; Fri, 14 Oct 2016 06:15:49 -0700 (PDT)
Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26FB212963F; Fri, 14 Oct 2016 06:15:49 -0700 (PDT)
Received: by mail-lf0-x22c.google.com with SMTP id l131so153266182lfl.2; Fri, 14 Oct 2016 06:15:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fYUyTYmb7Ge1YYnpKe6WNBE5eHMFpF4LRO6o3pZtLK8=; b=x2jllyGujq3hmapT3Ij2QGJvgdpcDb1B4FhCQXRGzi0F41z6iywBTT4z2ftgEQt7aa NKy3qSYlQhEDsFXjEHsb4z2H65F/YArrz/3GlyfRkU41ytkaWX4GqEqHmM3y5W2q1oyk j+jhBMoyG5ThRPRmurEWuMqcNWUyEBtgCg6qUYCnSd5WEExHeM5HUT7tPgayA8J69nI+ mVoSWuLpvjBTM6UHe87gldLcmAHIDJ09akv5Aq1dsynblsZoNQVF24rRoLhUpFFjMmGB TVlhnCDQ+XZrPXfVgaRDkpw8Do08ELWC8IR97wRhMnLWbvUA7Myu0jqMdgiss4g6XuTX BTkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fYUyTYmb7Ge1YYnpKe6WNBE5eHMFpF4LRO6o3pZtLK8=; b=GPsWaoKnqC6fwD3KHgmTm9aPNyixxN/JIah6s0kSKiWD9LRZSqACYuE7FrjzAlhVlR 4v5bKUrlAxNDCUvHvhsPKP6RpAlUsGWbaoWpdsedcKFOVT3KpwUtbuLZ5TyfblJrXREs VJKk6JrnTkROYnF3KtDTuYvKXipHTwFBgAgbJ+YjQfJ477U+V4ldAEEusPIHBvwfEWdh F/N7cxjcLjpJqLh69f+3ePOdzZfGppCWxidjUiCxPeiRdmcE+H41bjGpT0rNYht2UgK/ cBBNymKyfIg9TX9rdtumDe79JelSQymcj9d+71hWQuN8yl6fQlBnXoMzZIPANymCENfh CvDQ==
X-Gm-Message-State: AA6/9RnoF1Q5B8sBB4YCW7TTomV08l3/Nopr8hdkM+mVjsfMdqbxUmN7B6rjGppJj7ZeXA==
X-Received: by 10.28.10.146 with SMTP id 140mr5647117wmk.129.1476450945902; Fri, 14 Oct 2016 06:15:45 -0700 (PDT)
Received: from [10.12.7.153] ([37.205.61.206]) by smtp.gmail.com with ESMTPSA id h3sm31843322wjp.45.2016.10.14.06.15.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2016 06:15:44 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Subject: Re: Gen-ART Review for draft-ietf-lisp-crypto-09
From: Dino Farinacci <farinacci@gmail.com>
In-Reply-To: <C05B7CF3-3D83-4E69-B67C-976C08BB3611@qti.qualcomm.com>
Date: Fri, 14 Oct 2016 06:15:44 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <90602BB0-5B19-4047-BD27-6D07134C43AB@gmail.com>
References: <C05B7CF3-3D83-4E69-B67C-976C08BB3611@qti.qualcomm.com>
To: Pete Resnick <presnick@qti.qualcomm.com>
X-Mailer: Apple Mail (2.3226)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/VfP1haoykxlFZ1wrKzxRyalFsLU>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-lisp-crypto.all@ietf.org, IETF discussion list <ietf@ietf.org>, lisp@ietf.org
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Oct 2016 13:15:51 -0000

> Summary: This draft is ready for publication as an Experimental RFC

Thanks for your review Pete. Brian and I appreciate it.

> Though this is not an area of expertise for me, the document is clearly written, I reviewed the data structures and they appear correct, and the document seems ready to go forward. (I do find it dicey that this is an Experimental document. I understand there is history here, but this is

The reason the document is Experimental is to be consistent with the rest of the LISP RFC set. We do have in the LISP WG charter to standards track the RFC-set and anticipate that this RFC will follow the same path. But of course, it is for the working group to decide.

> a full-fledged protocol document and the fact that it is only required to be subjected to a cursory review for Experimental status and can pass IESG review with one "YES" and everyone else "ABSTAIN"ing seems kinda ridiculous. But that's not a reason to stop this document.)

I’ll yield to others to comment on this.

> Nits/editorial comments:
> 
> Section 9, second to last paragraph: "Otherwise, the packet has been tampered with and is discarded." The "tampered with" is probably overstating the case. I would simply say "invalid”.

Fixed.

Thanks again,
Dino