Gen-ART LC review of draft-ietf-ospf-rfc6506bis-01.txt

Brian E Carpenter <brian.e.carpenter@gmail.com> Tue, 12 November 2013 18:44 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E04811E810F; Tue, 12 Nov 2013 10:44:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.532
X-Spam-Level:
X-Spam-Status: No, score=-102.532 tagged_above=-999 required=5 tests=[AWL=0.067, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HOtCw0nIJZzR; Tue, 12 Nov 2013 10:44:25 -0800 (PST)
Received: from mail-pb0-x22b.google.com (mail-pb0-x22b.google.com [IPv6:2607:f8b0:400e:c01::22b]) by ietfa.amsl.com (Postfix) with ESMTP id 816C111E810A; Tue, 12 Nov 2013 10:44:25 -0800 (PST)
Received: by mail-pb0-f43.google.com with SMTP id md4so7304793pbc.16 for <multiple recipients>; Tue, 12 Nov 2013 10:44:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:organization:user-agent:mime-version:to:cc :subject:content-type:content-transfer-encoding; bh=7ssNtFTCQs26LZGLo87KKq+E63Qm2ISyEPBtAbzichY=; b=Sm9qspk48ECZBGZ0m8MD/KyX4eBKpPu07xnNP+2Rvu8wHdorKOQlRhO9ptDawpyfSA zbYJFl2D1Bb5rDi8PyCnhpwQ77cA3O/8HdDb8cwF1ZE45LHY+E2IPp5eO8cjT5w3sE14 QLd9ZzX8j2f1ledx6lfYr9qfTTbLu/eprh4Opn6jmnyVcbEIsls1WCTVVvTc+FXxUib8 3uOKx4RJ3n4GAom0F+Fn1C8/AxO8WfcNCMOoU/PlN9MVZ8kNYQlbA/qPFFf9eVzpu7ol N1WpR79m00oA9AhZTNNxp+RIqanezFLct7u4Ghv9/FqOp8eLR2smtiFB30gT2Hiow1fg Ev/w==
X-Received: by 10.66.11.202 with SMTP id s10mr38266855pab.86.1384281865252; Tue, 12 Nov 2013 10:44:25 -0800 (PST)
Received: from [192.168.178.20] (94.200.69.111.dynamic.snap.net.nz. [111.69.200.94]) by mx.google.com with ESMTPSA id n10sm39085894pbg.28.2013.11.12.10.44.22 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Nov 2013 10:44:24 -0800 (PST)
Message-ID: <52827705.30601@gmail.com>
Date: Wed, 13 Nov 2013 07:44:21 +1300
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: draft-ietf-ospf-rfc6506bis-01.all@tools.ietf.org, General Area Review Team <gen-art@ietf.org>
Subject: Gen-ART LC review of draft-ietf-ospf-rfc6506bis-01.txt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: IETF discussion list <ietf@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ietf>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Nov 2013 18:44:26 -0000

[Resending with CC to the IETF list, since the ospf WG list
automatically rejects non-subscriber messages.]

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-ospf-rfc6506bis-01.txt
Reviewer: Brian Carpenter
Review Date: 2013-11-12
IETF LC End Date: 2013-11-26
IESG Telechat date:

Summary:  Ready with issues
--------

Major issue:
------------

The listed changes from RFC 6506 include:

>    2.  Section 3 previously advocated usage of an expired key for
>        transmitted OSPFv3 packets when no valid keys existed.  This
>        statement has been removed.

I cannot see where this has been removed. In the last paragraph of
Section 3, the text starting:

> In the event that the last key associated with an interface expires,...

has not been changed. Isn't that the text that should be removed? In fact,
shouldn't it be explicitly contradicted, to ensure that implementations
are changed to fail-secure rather than run-insecure?


Nits:
-----

"errata" is a plural, often misused in this draft as a singular. The singular
noun is "erratum".

	
> This document may contain material from IETF Documents or IETF	
> Contributions published or made publicly available before November	
> 10, 2008. The person(s) controlling the copyright in some of this	
  ...

This disclaimer logically cannot be needed, since RFC6506 was published
after Nov. 10, 2008.



> 6.  Security Considerations
...
>   It addresses all the security
>   issues that have been identified in [RFC6039].

and in [RFC6506] (judging by section 1.2).