Re: Gen-art LC (and telechat) review for draft-ietf-regext-epp-rdap-status-mapping-01

"Gould, James" <jgould@verisign.com> Mon, 10 October 2016 15:29 UTC

Return-Path: <jgould@verisign.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76E9812971C for <ietf@ietfa.amsl.com>; Mon, 10 Oct 2016 08:29:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.92
X-Spam-Level:
X-Spam-Status: No, score=-1.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=verisign-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TRHfg30F3ohZ for <ietf@ietfa.amsl.com>; Mon, 10 Oct 2016 08:29:44 -0700 (PDT)
Received: from mail-qt0-f227.google.com (mail-qt0-f227.google.com [209.85.216.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7842B129713 for <ietf@ietf.org>; Mon, 10 Oct 2016 08:29:44 -0700 (PDT)
Received: by mail-qt0-f227.google.com with SMTP id 12so10657061qtm.3 for <ietf@ietf.org>; Mon, 10 Oct 2016 08:29:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verisign-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :mime-version; bh=5FPb/k0+0zYboN3jbcIRTx0UxhfOGX7d8dLSh90hWtA=; b=d1UE0y/6UE736/CS55ieC9jm2gkxWHUnLK2L3Y+S0h/USmEKa3o8HNbGX0LLPvQCXR Nq59p4hFA7EurB4F8GLc6IrRabp8chBc2Kr2vpX4FTStAjgmQsCLndH6mKOk5IBb3qVH rMTvpojrK5zDUAhHzLkucdEKaa+B+om3QWAoVAtamlStxBfntzLgHIFyEZI2U1qYuX0z YMFRnozl0XWyuSgOoLfSh0TZm8X05w7yF5vTbNsAnJmly6mhqBGHZOU6eT9BjPrgeFi8 4sahVdYd/5pBoIXuck9PMsnK+A+S+flZW/1keegHVAaiq76E0GjGfhCILrcNqQglZbLX w78A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:mime-version; bh=5FPb/k0+0zYboN3jbcIRTx0UxhfOGX7d8dLSh90hWtA=; b=m3vN+gVUtOQnHKlDOmoTyWw+n6g7NNRdPBlfpmrV1yNzxOjBu6MJUXzuFr/anB+PF+ PsVxFtAJWQEmxeElZHZS07lEJYbiQo/Vzka5x5jpZ6Ca86lYdL5PMckDRVPs9Mu2LU/f 9AEAEmUlkKdU/N+YLefMW+NlF8hpySQTfYou8jaqZ5rEi4vV7kMAuvvu7tNs0SY/C1WI 5kjeMB6dav4rUtVSzTIT4udMO1pdsJceTjcg7rnEjNcYnMGFrJU9lUG8Bv0SYmTODDfQ /EqfP/vSULU5pEHVSZxOdDVouUquF7b3cVCK4GZBb1M2c33Q7rr1psSfztuIOeYUUj6y Ir8Q==
X-Gm-Message-State: AA6/9Rnlyj546PYN+CptkIrgpCyVFZqEYI9BEuIkfOwUh4eVGVvJB9euJbiVszfTY5HkgTWqH0PRQVCtDEtTpWy6wrtr4DzL
X-Received: by 10.55.159.138 with SMTP id i132mr33929651qke.172.1476113322663; Mon, 10 Oct 2016 08:28:42 -0700 (PDT)
Received: from brn1lxmailout02.verisign.com (brn1lxmailout02.verisign.com. [72.13.63.42]) by smtp-relay.gmail.com with ESMTPS id n76sm38568439qke.3.2016.10.10.08.28.42 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 10 Oct 2016 08:28:42 -0700 (PDT)
X-Relaying-Domain: verisign.com
Received: from BRN1WNEXCHM01.vcorp.ad.vrsn.com (brn1wnexchm01 [10.173.152.255]) by brn1lxmailout02.verisign.com (8.13.8/8.13.8) with ESMTP id u9AFSfB7015368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 10 Oct 2016 11:28:42 -0400
Received: from BRN1WNEXMBX01.vcorp.ad.vrsn.com ([::1]) by BRN1WNEXCHM01.vcorp.ad.vrsn.com ([::1]) with mapi id 14.03.0301.000; Mon, 10 Oct 2016 11:28:39 -0400
From: "Gould, James" <jgould@verisign.com>
To: Robert Sparks <rjsparks@nostrum.com>
Subject: Re: Gen-art LC (and telechat) review for draft-ietf-regext-epp-rdap-status-mapping-01
Thread-Topic: Gen-art LC (and telechat) review for draft-ietf-regext-epp-rdap-status-mapping-01
Thread-Index: AQHSH0s0QR2PphM9rkml+sbHfJkdnqCiGmkA
Date: Mon, 10 Oct 2016 15:28:39 +0000
Message-ID: <94AC877C-EE87-4425-8E00-95965F945BA1@verisign.com>
References: <1016282d-9f98-fc86-572d-ca80c10db3a5@nostrum.com>
In-Reply-To: <1016282d-9f98-fc86-572d-ca80c10db3a5@nostrum.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.173.152.4]
Content-Type: multipart/signed; boundary="Apple-Mail=_3270E702-86E9-488D-9011-B175A7BB7180"; protocol="application/pkcs7-signature"; micalg="sha1"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/aM1oP9SqyBsYA25h4MIcDQjabk4>
Cc: General Area Review Team <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, regext <regext@ietf.org>, "draft-ietf-regext-epp-rdap-status-mapping.all@ietf.org" <draft-ietf-regext-epp-rdap-status-mapping.all@ietf.org>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2016 15:29:47 -0000

Robert,

Thank you for your review and feedback.  I provide responses to your feedback below.

—

JG




James Gould
Distinguished Engineer
jgould@Verisign.com <applewebdata://AECD3A2D-1DB8-4EBB-8F64-F11BAFDE30EA/jgould@Verisign.com>

703-948-3271
12061 Bluemont Way
Reston, VA 20190

VerisignInc.com <http://verisigninc.com/>
> On Oct 5, 2016, at 4:58 PM, Robert Sparks <rjsparks@nostrum.com> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-regext-epp-rdap-status-mapping-01
> Reviewer: Robert Sparks
> Review Date: 5 Oct 2016
> IETF LC End Date: 10 Oct 2016
> IESG Telechat date: 13 Oct 2016
> 
> Summary: This draft is on the right track but has open issues, described in the review.
> 
> Major Issue:
> 
> Many of the descriptions describe only side-effects of the status instead of the status itself.
> 
> All of the descriptions for the new rdap status codes start with "For DNR that indicates". This implies that there is a "For not DNR" case that's not discussed. I don't think the phrase is necessary and each description should look more like the other descriptions already registered at http://www.iana.org/assignments/rdap-json-values/rdap-json-values.xhtml.
> 
> For instance, at 'auto renew period' the document currently says:
> 
> "For DNR that indicates if the object is deleted by the registrar during this period, the registry provides a credit to the registrar for the cost of the auto renewal"
> 
> That discusses something (and not the only thing) that can happen while the object is in that state. It does not describe the state.
> 
> I suggest it should instead say (based on the text in 3915 and the current registry entry style):
> 
> "The object instance is in a grace period provided between when its registration period expires and when its registration is automatically renewed by the registry."
> 
> I don't think it's important to include the commentary about providing a credit if the entity is deleted by the registrar during this period, but since that commentary exists in 3915, you can include it if you want. The _important_ part to convey is the actual status.


The “For DNR that indicates” can be removed from the descriptions.  For example, the "addPeriod = add period; For DRN that indicates if the object is …”  mapping could be "addPeriod = add period; If the object is …”.  The purpose of this draft is to map the statuses defined in EPP and RDAP, so the status descriptions included in the draft where taken from the EPP RFC’s.  There is no intent to redefine the statuses included in the EPP RFC’s in anyway.

> 
> All of the descriptions will need similar attention. Some of them (such as clientUpdateProhibited) currently have 2119 words in the description. That doesn't make sense - this is a status, not an protocol instruction, and trying to put normative language in a registry will lead to confusion about where the behavior you are trying to describe is actually defined. (To be fair, 5731 has this same problem). Again, I suggest following the style that's already in the registry and say something like "The client has requested that any requests to update this object instance be rejected."
> 
> 

The clientUpdateProhibited status is defined as:

clientUpdateProhibited = client update prohibited;  For DNR that
       indicates the client requested that requests to update the object
       (other than to remove this status) MUST be rejected.

Where do you see 2119 words in the clientUpdateProhibited description?  The status descriptions were taken from the EPP RFC’s with no intent on changing their meaning.  


> Minor Issues:
> 
> You're setting up a minor maintenance headache for any future work that might update this document by having the descriptions listed in two places. I don't think it's necessary to list the descriptions in section 2 (currently the bulk of page 4 and the beginning of page 5). Instead, stop after the paragraph that ends at the top of page 4, and note that the descriptions of each new status code are provided in section 3.

The desire was for section 2 to stand on its own to define the statuses and the mapping, and for section 3 to be used to register the statuses in registry.  I believe it would be cleaner to duplicate the descriptions in this instance.  

> 
> Nits:
> 
> Near the end of page 3, the document says "In the DNR, the client and server prohibited statuses are separate an RDAP MUST support the same separation." There are several nits to address with this. That MUST is not a good use of 2119. DNR hasn't been expanded (and "the DNR" is not particularly clear).
> 
> I suggest you replace that sentence, and the one immediately before it with:
> 
> "EPP provides status codes that allow distinguishing the case that an action is prohibited because of server policy from the case that an action is prohibited because of a client request. The ability to make this distinction needs to be preserved in RDAP.”
> 

This change will be made.  

>