RE: Gen-ART Last Call review of draft-ietf-isis-mi-bis-02

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Sat, 08 April 2017 23:23 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: ietf@ietfa.amsl.com
Delivered-To: ietf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF787127A90; Sat, 8 Apr 2017 16:23:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.623
X-Spam-Level:
X-Spam-Status: No, score=-12.623 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4UVmHQAUUMVV; Sat, 8 Apr 2017 16:23:06 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C7DDC12420B; Sat, 8 Apr 2017 16:23:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5408; q=dns/txt; s=iport; t=1491693785; x=1492903385; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8FK1GC9Lg27AK7zkXUbx56DPCoNvG7sqneG5+zvCszM=; b=BXdUYocZTmRG5YcrPkQ8Iu2kl5Pai5GeOvnIN1Enl/bAgMtlPmd4Id7W 2x0bw81tBSd8FnH9nCi+dkY0blQ17rOZuv64UZe4Y1ulCZMaerx/JkOo6 u2lYTqrs6dszRxcwPKb/u5Ob2mmoGUfLmwc76GqLKSn67jUuAcdeDBtrf 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AVAQBxcOlY/4ENJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1NhgQsHjXKRQJVXgg8shXgCg14/GAECAQEBAQEBAWsohRUBAQE?= =?us-ascii?q?BAgE6PwUHBAIBCBEDAQEBHwkHMhQJCAEBBAENBQiJfwgOqgWKXAEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAR2GUIRwhB2GHgEEiSqMdoZbAYZ/gyuIJYIIVYRZihSIY4s?= =?us-ascii?q?cAR84gQVbFUGEWxyBY3UBiB+BDQEBAQ?=
X-IronPort-AV: E=Sophos;i="5.37,175,1488844800"; d="scan'208";a="407745201"
Received: from alln-core-9.cisco.com ([173.36.13.129]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Apr 2017 23:23:04 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id v38NN4va029812 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 8 Apr 2017 23:23:04 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Sat, 8 Apr 2017 18:23:04 -0500
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1210.000; Sat, 8 Apr 2017 18:23:03 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Orit Levin <oritl@microsoft.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-isis-mi-bis.all@tools.ietf.org" <draft-ietf-isis-mi-bis.all@tools.ietf.org>
Subject: RE: Gen-ART Last Call review of draft-ietf-isis-mi-bis-02
Thread-Topic: Gen-ART Last Call review of draft-ietf-isis-mi-bis-02
Thread-Index: AdKvMQJviOL5quEPRPel7BR3psjAJABiHiqg
Date: Sat, 8 Apr 2017 23:23:03 +0000
Message-ID: <dc04ef63da5242d6a57386cb9d07b005@XCH-ALN-001.cisco.com>
References: <CY1PR0301MB21227CD18EA946CE8286711DAD0C0@CY1PR0301MB2122.namprd03.prod.outlook.com>
In-Reply-To: <CY1PR0301MB21227CD18EA946CE8286711DAD0C0@CY1PR0301MB2122.namprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.67.234]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ietf/zVVrU7J7T_i9F3gtQVHZw5CeZVE>
X-BeenThere: ietf@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF-Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ietf>, <mailto:ietf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ietf/>
List-Post: <mailto:ietf@ietf.org>
List-Help: <mailto:ietf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>, <mailto:ietf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Apr 2017 23:23:08 -0000

Orit -

Thanx for the review.
Responses inline.

> -----Original Message-----
> From: Orit Levin [mailto:oritl@microsoft.com]
> Sent: Thursday, April 06, 2017 8:27 PM
> To: gen-art@ietf.org
> Cc: ietf@ietf.org; draft-ietf-isis-mi-bis.all@tools.ietf.org
> Subject: Gen-ART Last Call review of draft-ietf-isis-mi-bis-02
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-isis-mi-bis-02
> Reviewer: Orit Levin
> Review Date: 2017-04-06
> IETF LC End Date: 2017-04-07
> IESG Telechat date: 2017-04-13
> 
> Summary: This draft is "ready with issues" for publication.
> 
> Major issues: None.
> 
> Minor issues:
> 
> 1. Add text explaining the reason (or reasons) for replacing the original RFC
> 6822 from 2012.
> Reason: It is a "bis" draft and there is no mention about it in the text.

[Les:] Note that the latest revision of the draft correctly identifies the draft as obsoleting RFC 6822. Previous versions had incorrectly identified this as an update to RFC 6822.
This is then the new Standard for the IS-IS MI support.

There are two classes of future readers of this document:

a)Readers who are unfamiliar with RFC 6822. For them what changed between RFC 6822 and this document is irrelevant. 

b)Readers who are familiar with RFC 6822. For them it is useful to know what changed - which is described in Appendix A.

In order not to distract readers of type "a" - as well as to provide an "uninterrupted" description of the normative behavior I believe placement of the change description in an Appendix improves the readability of the document.

Does this make sense to you?

> 2. In Abstract, state clearly that this standard introduces the support for
> instances vs. other already existing concepts also listed in the Abstract (i.e.,
> circuits, adjacencies,  topologies, etc.).

[Les:] The Abstract currently says:

"This draft describes a mechanism that allows a single router to share
   one or more circuits among multiple Intermediate System To
   Intermediate System (IS-IS) routing protocol instances."

Previous to this extension, a router could have multiple instances of the IS-IS protocol, but multiple instance could not be run over the same interface. 
So we are not introducing "instances", but we are introducing the ability to enable multiple instances on the same interface.

> Reason: The wording is not clear about what is the new feature vs. what are
> the new benefits vs. what was the original baseline 

>3. Throughout the
> document, use "standard instance" instead of "IID = 0" or "IID #0".
> Reason: Expressions "standard instance", "IID = 0" and "IID #0" are used
> interchangeably throughout the document. It seems that they all refer to the
> same thing - the implementation of the original protocol without the concept
> of instances. Please, correct me if I am wrong.

[Les:]  I don't think this is possible without seriously compromising the document. For example:

Section 2.1

" IID #0 is reserved for the standard instance supported by legacy
   systems. "

Changing this to  " Standard instance is reserved for the standard instance ..."

Is clearly nonsensical.

Later in Section 2.1

"When the IID = 0, the list of supported ITIDs MUST NOT be present."

What is being discussed here is what is the correct behavior when an MI-capable router sends a PDU associated IID #0 and includes the new IID TLV. 
Replacing this with "When the standard instance..." loses the important point that the value of the IID in the IID TLV in this case is "0".

Hope this helps clarify things.

> 4. In section 2 par 3, change "support" and "operates" to "MUST support" to
> use requirements language.

[Les:] I am on the fence as regards this change. Section 2 is an introduction to the following sub-sections - which define the normative behavior. But the introduction itself is not defining normative behavior - it is providing a context in which the protocol extensions defined in the following sub-sections can be understood. 

I am more inclined to change the "MAY" used later in the same paragraph you mention to "may" so it is consistent with the rest of this section.

???


> 5. In section 2 par 2, change "may" to either "can" or "MAY" to clarify the
> intent.

[Les:] Did you mean Section 2.1 para 2?
If so I agree to the change.

> 6. In section 2.1 par 3, clarify whether IID #0 is ever being used on the wire.

[Les:] There are numerous places in the document where the legal use of IID  #0 is discussed. I do not understand how a reader would conclude that IID #0 is never sent on the wire.

> Explain the concept of the "standard interface" (see previous comment)

[Les:] There is no mention of "standard interface" - did you mean "standard instance"?

If so, Section 1 paragraph 4 states:

"Legacy routers support the standard
   or zero instance of the protocol."

   Les