[Int-dir] Intdir telechat review of draft-ietf-sframe-enc-07

Suresh Krishnan via Datatracker <noreply@ietf.org> Fri, 29 March 2024 15:30 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Suresh Krishnan via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: draft-ietf-sframe-enc.all@ietf.org, last-call@ietf.org, sframe@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171172625624.49272.18301693085107891676@ietfa.amsl.com>
Reply-To: Suresh Krishnan <sureshk@cisco.com>
Date: Fri, 29 Mar 2024 08:30:56 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/HOQQiM3TfSBrml8-yNIUOR5zZo8>
Subject: [Int-dir] Intdir telechat review of draft-ietf-sframe-enc-07

Reviewer: Suresh Krishnan
Review result: Ready with Nits

I found the document well written and easy to understand. I did have two minor
comments to bring up:

* The draft seems to have a few (looks like Python) code blocks embedded in it.
Consider enclosing them within <CODE BEGINS> and <CODE ENDS> markers to
identify them as code components for licensing purposes.

* The draft seems to refer to an obsoleted version of the SDP spec RFC4566
which was obsoleted by RFC8866. Unless there is something specific in the old
SDP needed for this draft, it probably makes sense to refer to the newer RFC.

[Int-dir] Intdir telechat review of draft-ietf-sf… Suresh Krishnan via Datatracker
Re: [Int-dir] Intdir telechat review of draft-iet… Richard Barnes