Re: [Int-dir] Intdir telechat review of draft-ietf-detnet-mpls-over-tsn-05

Balázs Varga A <balazs.a.varga@ericsson.com> Tue, 16 February 2021 16:52 UTC

From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: Tim Chown <tim.chown@jisc.ac.uk>, "int-dir@ietf.org" <int-dir@ietf.org>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-mpls-over-tsn.all@ietf.org" <draft-ietf-detnet-mpls-over-tsn.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Intdir telechat review of draft-ietf-detnet-mpls-over-tsn-05
Thread-Index: AQHXAubNZFK1Rvi9DUW+z2mpaY0MYKpa+qgA
Date: Tue, 16 Feb 2021 16:52:10 +0000
Message-ID: <AM0PR0702MB3603D099446C81384562852EAC879@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <161331682374.13755.15439036471779607099@ietfa.amsl.com>
In-Reply-To: <161331682374.13755.15439036471779607099@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6896620c-aa60-475a-9a74-08d8d29b33ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2021 16:52:10.5284 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zoo7765NkO9sEtdNqO29hOVVYKZU7qL1gwFIF5SNDs/v7Q1YvhbEmfE3SMXohOqcAFM62E5Qgzek3oYDH56WLJx36KW9eE4jrXyo2e60jYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5986
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/pmkq7EGNz3KSuKiDTAGSUSb18NU>
Subject: Re: [Int-dir] Intdir telechat review of draft-ietf-detnet-mpls-over-tsn-05
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Feb 2021 16:52:19 -0000

Hi Tim,

Many thanks for the review and the nits.
Updates will be done according to comments added inline.

Thanks
Bala'zs

-----Original Message-----
From: Tim Chown via Datatracker <noreply@ietf.org> 
Sent: Sunday, February 14, 2021 4:34 PM
To: int-dir@ietf.org
Cc: detnet@ietf.org; draft-ietf-detnet-mpls-over-tsn.all@ietf.org; last-call@ietf.org
Subject: Intdir telechat review of draft-ietf-detnet-mpls-over-tsn-05

Reviewer: Tim Chown
Review result: Ready with Nits

Hi,

Re: INT-DIR review of draft-ietf-detnet-mpls-over-tsn-06

This draft details how a DetNet MPLS data plane can run over a TSN sub-network.

I have reviewed this document and believe it is Ready for publication, with Nits, as listed below.

Nits:

p.2
Loss rates -> loss rate
Provides congestion -> provide congestion For MPLS-based -> for an MPLS-based
<Bala'zs> OK.

p.3
Include MSRP and RSVP-TE?
<Bala'zs> OK.

p.4
And resources -> and resource
<Bala'zs> Already fixed in v06.

p.5
>From MPLS -> from the MPLS
Does not -> do not
In case of -> In the case of
<Bala'zs> OK.

As per the IP doc, not being familiar with DetNet in detail it might be useful to expand on the rationale for mapping to multicast given the “directed” flow.
<Bala'zs> OK. See IP doc reply.

p.7
As per the IP doc, I note it says there are no requirements stated for TSN-unaware MPLS DetNet nodes in the document, but is it worth adding something about requirements to ensure the TSN Relay can be reached?
<Bala'zs> OK. See IP doc reply.

p.8
Implementations -> implementation
<Bala'zs> OK. 

P.9
of the document -> of this document
challanges -> challenges
Are member -=> are members
Single hop -> a single hop
In some case -> in some cases
<Bala'zs> OK.

P.10
Regarding the more complicated triggering for TSN-unaware nodes, should further text be added about this?
<Bala'zs> I see your point, but that is more a control/management plane issue and not a data plane one.
Controller plane discussions recently started in DetNet, so I will keep this comment on the table. :--)))

--
Tim

[Int-dir] Intdir telechat review of draft-ietf-de… Tim Chown via Datatracker
Re: [Int-dir] Intdir telechat review of draft-iet… Eric Vyncke (evyncke)
Re: [Int-dir] Intdir telechat review of draft-iet… Balázs Varga A
Re: [Int-dir] Intdir telechat review of draft-iet… Tim Chown