Re: [Int-dir] Int-Dir Review of draft-ietf-softwire-dslite-multicast-12

<mohamed.boucadair@orange.com> Mon, 12 December 2016 06:45 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7AB9129A3F; Sun, 11 Dec 2016 22:45:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.815
X-Spam-Level:
X-Spam-Status: No, score=-3.815 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.896, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KyQCQ_DCEvlN; Sun, 11 Dec 2016 22:45:23 -0800 (PST)
Received: from relais-inet.orange.com (mta240.mail.business.static.orange.com [80.12.66.40]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EEE1E129A3A; Sun, 11 Dec 2016 22:45:22 -0800 (PST)
Received: from opfedar05.francetelecom.fr (unknown [xx.xx.xx.7]) by opfedar23.francetelecom.fr (ESMTP service) with ESMTP id C36C016018D; Mon, 12 Dec 2016 07:45:20 +0100 (CET)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.19]) by opfedar05.francetelecom.fr (ESMTP service) with ESMTP id A71D36006E; Mon, 12 Dec 2016 07:45:20 +0100 (CET)
Received: from OPEXCLILMA3.corporate.adroot.infra.ftgroup ([fe80::60a9:abc3:86e6:2541]) by OPEXCLILM44.corporate.adroot.infra.ftgroup ([fe80::b08d:5b75:e92c:a45f%18]) with mapi id 14.03.0319.002; Mon, 12 Dec 2016 07:45:20 +0100
From: mohamed.boucadair@orange.com
To: Zhen Cao <zhencao.ietf@gmail.com>, "draft-ietf-softwire-dslite-multicast@tools.ietf.org" <draft-ietf-softwire-dslite-multicast@tools.ietf.org>
Thread-Topic: Int-Dir Review of draft-ietf-softwire-dslite-multicast-12
Thread-Index: AQHSVD0oiJjpFHy4Q0S7zkDiafwGwqED2I5w
Date: Mon, 12 Dec 2016 06:45:19 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B933009DCBF87@OPEXCLILMA3.corporate.adroot.infra.ftgroup>
References: <CAFxP68zBZ5+X8nLhtTOEcrA6c_kYhObd-8M_qQjA+Qw0gzuLQQ@mail.gmail.com>
In-Reply-To: <CAFxP68zBZ5+X8nLhtTOEcrA6c_kYhObd-8M_qQjA+Qw0gzuLQQ@mail.gmail.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.1]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/bwWMc1QGbP9VLk64Cnwz9TF0nsg>
Cc: "int-ads@ietf.org" <int-ads@ietf.org>, "int-dir@ietf.org" <int-dir@ietf.org>
Subject: Re: [Int-dir] Int-Dir Review of draft-ietf-softwire-dslite-multicast-12
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 06:45:25 -0000

Dear Zhen,

Thank you for the review.

Please see inline.

Cheers,
Med

> -----Message d'origine-----
> De : Zhen Cao [mailto:zhencao.ietf@gmail.com]
> Envoyé : lundi 12 décembre 2016 07:01
> À : draft-ietf-softwire-dslite-multicast@tools.ietf.org
> Cc : int-ads@ietf.org; int-dir@ietf.org
> Objet : Int-Dir Review of draft-ietf-softwire-dslite-multicast-12
> 
> Hi, authors and editors,
> 
> I am an assigned INT directorate reviewer for this draft. These
> comments were written primarily for the benefit of the Internet Area
> Directors. Document editors and shepherds should treat these comments
> just like they would treat comments from any other IETF contributors
> and resolve them along with any other Last Call comments that have
> been received. For more details of the INT directorate, see
> <http://www.ietf.org/iesg/directorate.html>.
> 
> 
> I do not see any major reason to block the publication of this draft.
> Below are two comments for discussion.
> 
> a) uPrefix64 and mPrefix64
> 
> I was a bit confused when I encounter the name suffix -64, because
> they somehow imply only 64-bit long prefix could be used, while the
> fact may be not true.

[Med] Actually, 64 is not used to denote the prefix length but this is a practice widely used in transition mechanisms, you can see for instance: 
https://tools.ietf.org/html/rfc6146
https://tools.ietf.org/html/rfc6147  
https://tools.ietf.org/html/rfc7050
https://tools.ietf.org/html/rfc7225 
...

  If '64' means an IPv6-IPv4 mapping, it may make
> some sense.  So I highly encourage the editors to put some notes below
> the items in the terminology section.
> 

[Med] Makes sense. I added a note similar note that we have in https://tools.ietf.org/html/draft-ietf-softwire-multicast-prefix-option-11: 

         Note: "64" is used as an abbreviation for IPv6-IPv4
         interconnection.

> 
> b)
> 6.2.  Multicast Data Forwarding
> 
>   When the mB4 receives an IPv6 multicast packet, it MUST check the
>    group address and the source address.  If the IPv6 multicast group
>    prefix is mPrefix64 and the IPv6 source prefix is uPrefix64, the mB4
>    MUST decapsulate the IPv6 header and forward the IPv4 multicast
>    packet through each relevant interface.  Otherwise, the mB4 MUST
>    silently drop the packet.
> 
> comments: the mB4 not only needs to check the validity of mPrefix and
> uPrefix, but also needs to check if there exists an associated
> MLD/IGMP requests from that prefixes.  Only if there was an IGMP
> report associted with this transaction, it will forward such multicast
> packets.
> 
> 
[Med] This is actually the intent of the last part of the text you quoted:  

   prefix is mPrefix64 and the IPv6 source prefix is uPrefix64, the mB4
   MUST decapsulate the IPv6 header and forward the IPv4 multicast
   packet through each relevant interface. 
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

If no state is found, there won't be any "relevant interface". So the  traffic won't be forwarded.

> Thanks for draft the document.
> 
> -zhen