[Int-dir] Intdir telechat review of draft-ietf-detnet-ip-over-tsn-05

Tim Chown via Datatracker <noreply@ietf.org> Sun, 14 February 2021 15:22 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ACAA93A0DE1; Sun, 14 Feb 2021 07:22:03 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Tim Chown via Datatracker <noreply@ietf.org>
To: <int-dir@ietf.org>
Cc: detnet@ietf.org, draft-ietf-detnet-ip-over-tsn.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.25.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161331612359.11937.4500760907095871686@ietfa.amsl.com>
Reply-To: Tim Chown <tim.chown@jisc.ac.uk>
Date: Sun, 14 Feb 2021 07:22:03 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/fKUYTizlwdO8oX1QDoSytKVEcHQ>
Subject: [Int-dir] Intdir telechat review of draft-ietf-detnet-ip-over-tsn-05
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Feb 2021 15:22:04 -0000

Reviewer: Tim Chown
Review result: Ready with Nits

Hi,

Re: INT-DIR review of draft-ietf-detnet-ip-over-tsn-05

This draft details how a DetNet IP data plane can run over a TSN sub-network.

I have reviewed this document and believe it is Ready for publication, with
Nits.  Note I am not overly familiar with specifics of the DetNet architecture.
There are some hopefully simple questions that might be addressed and some
minor editorial nits as detailed below.

Nits:

p.2
Expand TSN on first use, rather than on page 4.

p.3
Is “6-tuple” well-defined?  Perhaps expand for clarity.

p.4
Is there a specific reason to show a multi-homed TSN node?
Are there implications if it is multi homed in TSN but not IP?

p.5
Not being familiar with DetNet in detail it might be useful to expand on the
rationale for mapping to multicast given the statement that the flow is
“directed”.

p.6
covers required -> covers the required
I note it says there are no requirements stated for TSN-unaware nodes in the
document, but is it worth adding something about requirements to ensure the TSN
Relay can be reached?

p.7
Implementations must -> implementation must (twice)
FRER function -> The FRER function

p.8
of the document -> of this document
challanges -> challenges
Are member -=> are members

p.9
In some case -> in some cases

--
Tim