Re: [Int-dir] Intdir telechat review of draft-ietf-detnet-mpls-over-ip-preof-09

Balázs Varga A <balazs.a.varga@ericsson.com> Tue, 20 February 2024 08:09 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: int-dir@ietfa.amsl.com
Delivered-To: int-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6081CC14F5E9; Tue, 20 Feb 2024 00:09:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.11
X-Spam-Level:
X-Spam-Status: No, score=-2.11 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fubEl1u-d5X6; Tue, 20 Feb 2024 00:09:45 -0800 (PST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6ED9AC14F5E5; Tue, 20 Feb 2024 00:09:44 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DPycAaj7QqpAkEA3/4WX5EWQ5y2n7Q6E2jCjHkAy6MAnsoSk+6vHhryOGxn5G46QiiklGT5jwlftw+P+jpOEsaAYtMtUNax0JhxFHSi5EdGFrI0cjeON1Og8ZTQyJhGiDoGWy1UPyjO/jVINRzOxXCANYasRiciXlRjJHFWd8x4IDYKOSbn6GUvuJGLLCWGFA+MWK90IjaE5W/rib99BvbojhID3JbE26A/LcBxwlOPsEHNBoluDdJnJROzMD06h0fKWDoFWeOAp2jrgb88GPRqsWaay7s8wKcuIj2T3uvmGM71hCJTpIVOHDmb4AX8d4dmWfFiGPRrWV5J33QmC4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59Slbah6hNOQ2PuKffe6QsNClh22FRstF4Xrwoq0bvk=; b=PlWvzSb3FeGGkd5MXoHBkS2dS2jk3HVOiuPAcw3aTinGcQMcXVFj3w+jTjuoFjDGZUMdJCXDbMcg9HfkRUfuWor2oXWgRyXg/1FyazO1av5SaZqotjJ2XdwHm4sSPItmiDMpR3skJQ5cfyAt8VmCMWBkw9oRi6Et+/cHkeALZstD2h14b3Guwuw2piGtKbiBaX4qq0l3DiDc4E5nEYzL3TIMnRmdxDBXBFd4WFjEolyoCZzeBxqvhEgPsSdGB38s7fLFZHaGKCnl6dVevucKe99BVGoJgJG6GWYX6INmPEK8+fjKS1IAHSB8PG3IRr9FBsy7JM8ylvQYzaCrCueAGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59Slbah6hNOQ2PuKffe6QsNClh22FRstF4Xrwoq0bvk=; b=sgx/ct6tXir5tYMob9Ct0Q3JoMOpJxjYCfxovhswgDgPh0iP1fTRFbpwANHpMUuYG4XNhV1JAy3U7qUkq1qd77mq1WWA1w9rvjsDCHojTSXlJbye8J3eMzRO/n/oApvojoyoWUOWQkqXnlOGXxtMXFKyNbiI9rdcLw9hPx25xpMt5kp+BLzYSIaHWodHzEJ0iy4gH2jRLtM2Xy09VGMnglTYi2Q2oswQFFydcV/fhteLS4hGMlj8Z7OpyyO3SHqCKD+hF9pHPKahsKPTMz+0UX/Z5aVoAadixaCwWzSSJRnIqj+ONVDjpHjc6UM6gRdP1j61Toq6A0M1HH9v3n/AMQ==
Received: from PA4PR07MB7214.eurprd07.prod.outlook.com (2603:10a6:102:fa::10) by PAVPR07MB9264.eurprd07.prod.outlook.com (2603:10a6:102:312::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.38; Tue, 20 Feb 2024 08:09:41 +0000
Received: from PA4PR07MB7214.eurprd07.prod.outlook.com ([fe80::2d73:e65:2300:5937]) by PA4PR07MB7214.eurprd07.prod.outlook.com ([fe80::2d73:e65:2300:5937%3]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 08:09:41 +0000
From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: Tatuya Jinmei <jinmei@wide.ad.jp>, "int-dir@ietf.org" <int-dir@ietf.org>
CC: "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-mpls-over-ip-preof.all@ietf.org" <draft-ietf-detnet-mpls-over-ip-preof.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Intdir telechat review of draft-ietf-detnet-mpls-over-ip-preof-09
Thread-Index: AQHaYFQJXaBRNLAgSUWbuO7X63bFOLES4vmg
Date: Tue, 20 Feb 2024 08:09:41 +0000
Message-ID: <PA4PR07MB72148F7D6551940B9891CFA3AC502@PA4PR07MB7214.eurprd07.prod.outlook.com>
References: <170803169395.5370.2493632031052819110@ietfa.amsl.com>
In-Reply-To: <170803169395.5370.2493632031052819110@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PA4PR07MB7214:EE_|PAVPR07MB9264:EE_
x-ms-office365-filtering-correlation-id: f9c8d2bf-a09b-4df8-810f-08dc31eb4a69
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hxPVLKLW6+x1hi+2iFrGFuntrMVbQF0RLghddagXAC7flT9VM3ZKUSY/Z+up+pcndsopqF2w8Hl6v2/QNI83/ILrpik0IK+S+nuxi7RZyjUiusEaHBZCUdFPr3lFGX1UIIe+r9vUIlnVFYGmnqKHYpKwSb4iknkbfjhKnx9h4NWjygjK0h+SLOk9oSWh8fRGBoGAn6qpa5xPC5LA7xPYTsePSbTcbcACylKi0r3e7V767wgyBKJ2bzw8wKDWlfjCHMIKAePb61NPf7n8pqjuCc+EZEtYIiIIKVrx38fwPolP1yq5o3S1ntmw87FG4b+AbtR/M7DaxLAwnftNtq+MsuqwTB3QJtNxf5Pl9Bzr6ydWvYfePJzDdHwt/+OGWDWWu5wlwr50VK9Fha+ppfaaXp6FGwqPf+91PfhQ9uAkOTaoFet8QPcpVsmPShZfQEDW9lxAK+3n6GKvvdcXSp2nrwOeHwnJ6cMDdlZOKs9JtCtgfeRcncRfsZ6kFlbxbIlg/fESrGQ16xEjDtaSw7K5t35qFUozN6hxGBt2o5n8aHpY1/m5W2Qi1QHF2mNeFjzaI/Hdswzdpdtv6285EJm3txTiwYhZIgNXZcnpn/FDC8M=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR07MB7214.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: d110N6js80CrbfIq87JRqwFCMm1KqXlnTB5PqayaflCsoNlFAqkcqbhlca4OQ9CaM2CEcWUmb01zh0VpnToGSwp2FkC7y/FhUzuT5GZ7tLwWc6qpVt8LzKIJHr45temmkfC0RZvRdcaxpJztQedZl+twnFKg2Wk4cT+bn2DGJtd4Xwgu3oR13BcEc6FVdnl4xcJWMYSj6T6cudifwpRfT44IBZkcWlCpj42pSGaeDjKaDtckkudI2nAaTn//5aBXoORS2oqzFt908zwoJZnJOFSiwEcKXsSPz/Myj76FC82S1Kx+OAGB3feegwesoknT9fTQN99Qn6VvjWSyFsdLX0Z805yNI2UHCS9hBp/E9OanLRu+KFM5BENxcCSg+KwUemJKQAGpGULeJD1vqHHI21sTZwogVQSu47Z/9hB84RBKfZ8NQVw/YMZgcbRCZ3R25ItmDfF2zkxI/0f1DgRIdj2NjTC3w2A4ud5+Jg/9S5Ajh3uTr1CLFUA1flx4uACwwmMm5cIozjd98txrCAEwHC0ivjrmRf1Lu72GifR/4BIELGqU3ePh8XXVqUu9IinyLJUoWjbIaxYtSk3Ff8axV3JOZ5A+5r9FpDazcCEXg3fClxqHh1zFdVA0yYH36AaIEOpYaL+pDUBH9ZtNhOCelGJbM2hOQEQPuY/qkTXekaql9SyLfNzBoSX3rOOPWbBREprIMHPm7ffclMTe9jCUuHe2fYIx7kd89jyCpJN+lOg5svFprhX9sFB0w7YrGLjWQXD32cr3EyxRrFIx4rNUtD3xa+3AeECh5z0ROGAB40oP9na+pIwNPU3ab/j5HvuxhyB6TRxLPM4JzDz30DQpVI8ddeJm+BCwgAHUPKDE79/lpj7kJaKTQUx1VDze+9pcGkLdwlsNtw1oMQfRFMp30k1zkSqf5ZUyzxHdgpqskAfWBsvKA/jb7zmnuRcuapqbVRWrsZf09Guk0+Lu0aqk92eX1Okui+HSu9u5J/Ao/Ou+tO1jgfzbwFqTE7RQtVgm2LSFiaaLb2xyW5xNTgDRJUHFeq1isqCzpC0LJ8dg8EOnni/EOZevUmnybq1GK00WNMMqnMuK6khJbq/+XZn7ROhqBWmX8tIFuEnDqAaUv7jzoFrNPLB0Gjs3jBg6uNYHYCNzVBk7pO34QPmvMgi21E+BuHkrCLO5/mB4upPWFTr2jQE2Sn1bW8362LGkVGa5Hlnbfd0/DAosuX5rrnj9fQX02ObiLe45GtrMIlTyKeS5jVqOZjY/mQtIFhKW4PV8sxdGDImZuUhPS3GaEfl3yWy3SC041PB+Mp9Nw3TGHcSFBlVJyLyVl1zNVHIWHohONN1cY0P5wUUEwAujYMovBmW707jeOAj1ALSJ0W1GQl4eoIOx87Gu/yEv1zZ/tHyTdRwsufdkjyp4X27QmcqgzDuRcJxw698X9CIdMIDDGaUHitnxG4yUn8vpkWwFwXs5HwZtgw3qVSbaAKOL7suELa8D7wlaA6VeZ9HYjYhqEE4nPZeE8u22dpXCGhTkrSinYw+I+OsVZKd73/XW/3nuNTgzERS1jHrgkkFsEWMGOXGRF8Jkjep3okF5wBS479mN
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR07MB7214.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9c8d2bf-a09b-4df8-810f-08dc31eb4a69
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 08:09:41.5046 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SGJuDgSsTPvRGJyT8FF45V69OWf8a2Ft+nsyZLKmSh0wyL3DuI9lqFE71LzNQ4l9dqvyUGmni0pV83lYMZ+g92mFtTOBaNoxNOH5vk0DlFw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR07MB9264
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/zol2JuZDCzLlfUIVebGZ8Fb20VE>
Subject: Re: [Int-dir] Intdir telechat review of draft-ietf-detnet-mpls-over-ip-preof-09
X-BeenThere: int-dir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/int-dir>, <mailto:int-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir/>
List-Post: <mailto:int-dir@ietf.org>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/int-dir>, <mailto:int-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2024 08:09:49 -0000

Hi Tatuya,
Many thanks for your review and proposed changes.
They were added to v10 of the draft, uploaded recently.
Regarding " Section 4.6 and Figure 5", the purpose is to
show the improvement compared to RFC8939. 
We have extended the text to highlight the improvement
and added an explicit reference to RFC8939.
Thanks & Cheers
Bala'zs

-----Original Message-----
From: Tatuya Jinmei via Datatracker <noreply@ietf.org> 
Sent: Thursday, February 15, 2024 10:15 PM
To: int-dir@ietf.org
Cc: detnet@ietf.org; draft-ietf-detnet-mpls-over-ip-preof.all@ietf.org; last-call@ietf.org
Subject: Intdir telechat review of draft-ietf-detnet-mpls-over-ip-preof-09

Reviewer: Tatuya Jinmei
Review result: Ready with Nits

I am an assigned INT directorate reviewer for <draft-ietf-detnet-mpls-over-ip-preof-09.txt>. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and
shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/.

Based on my review, if I was on the IESG I would ballot this document as NO OBJECTION.

This document is generally well-written, and it provides a straightforward solution to the stated motivation (specifying the encoding of sequence information in DetNet IP packets). To the extent of my limited understanding of DetNet and related technologies, I've not found any issue.

The following are minor issues (typos, misspelling, minor text improvements) with the document:

I have a few comments that might help improve readability of the document.

- Introduction:

   The DetNet Working Group has defined Packet Replication (PRF), Packet
   Elimination (PEF) and Packet Ordering (POF) functions to provide
   service protection by the DetNet service sub-layer [RFC8655].  The
   PREOF service protection method relies on copies of the same packet

  I'd suggest updating the first sentence to, e.g., "...functions (correctly
  represented as PREOF)...", so that readers won't be puzzled about the acronym
  when they read the second sentence. (abstract defines the term, but I think
  it's better if the main text is more self-contained).

- Section 4.1, Figure 2: what "d-CW" stands for is explained in Section 4.2, but not here or before. It's more reader friendly to note it when it first occurs.

- Section 4.4: it may be more reader friendly to explain what PW stands for
here:
   In the first case, the different DetNet PWs use the same UDP tunnel,

  perhaps it's obvious for readers with sufficient background, but this
  document generally seems to expand many acronyms, so it would be more
  consistent.

- Section 4.6 and Figure 5: the purpose of this section and the figure is not clear to me. Do we need this section at all?