[IPFIX] Gen-ART review of draft-ietf-ipfix-text-adt-07
"Black, David" <david.black@emc.com> Fri, 18 July 2014 01:35 UTC
Return-Path: <david.black@emc.com>
X-Original-To: ipfix@ietfa.amsl.com
Delivered-To: ipfix@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 407D21A011E; Thu, 17 Jul 2014 18:35:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.002
X-Spam-Level:
X-Spam-Status: No, score=-0.002 tagged_above=-999 required=5 tests=[BAYES_50=0.8, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cfli87-MviAf; Thu, 17 Jul 2014 18:35:24 -0700 (PDT)
Received: from mailuogwhop.emc.com (mailuogwhop.emc.com [168.159.213.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15C961A0115; Thu, 17 Jul 2014 18:35:23 -0700 (PDT)
Received: from maildlpprd03.lss.emc.com (maildlpprd03.lss.emc.com [10.253.24.35]) by mailuogwprd03.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s6I1ZKjW012342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 Jul 2014 21:35:22 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd03.lss.emc.com s6I1ZKjW012342
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1405647322; bh=gxPF90v13dypxLCqQ0bztYMHxik=; h=From:To:CC:Date:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=I5j2KkcwuyioUTt0ZXgH3ifAT9rg73+tdI/uILHpwu3vJIUuPvehXGa6X+5Dkm6+g N5l2Sm6HwWitxLjZT3rpvpciymVW9HatT9wm3q1pkdoHHzGz2sVyjq6sH2nFjzYrQ4 NbJP8FsplC4DTAW+tCcGY969dkSTsSGYhVk38Kqs=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd03.lss.emc.com s6I1ZKjW012342
Received: from mailusrhubprd01.lss.emc.com (mailusrhubprd01.lss.emc.com [10.253.24.19]) by maildlpprd03.lss.emc.com (RSA Interceptor); Thu, 17 Jul 2014 21:35:10 -0400
Received: from mxhub29.corp.emc.com (mxhub29.corp.emc.com [128.222.70.169]) by mailusrhubprd01.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s6I1Z9tE026144 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 17 Jul 2014 21:35:09 -0400
Received: from mx15a.corp.emc.com ([169.254.1.186]) by mxhub29.corp.emc.com ([128.222.70.169]) with mapi; Thu, 17 Jul 2014 21:35:09 -0400
From: "Black, David" <david.black@emc.com>
To: "ietf@trammell.ch" <ietf@trammell.ch>, "General Area Review Team (gen-art@ietf.org)" <gen-art@ietf.org>
Date: Thu, 17 Jul 2014 21:35:07 -0400
Thread-Topic: Gen-ART review of draft-ietf-ipfix-text-adt-07
Thread-Index: Ac+iKIAhuGCFxwJyQF+bD6JdAwx7vQ==
Message-ID: <8D3D17ACE214DC429325B2B98F3AE71207783F61A0@MX15A.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd01.lss.emc.com
X-RSA-Classifications: public, Resumes
Archived-At: http://mailarchive.ietf.org/arch/msg/ipfix/6_DutFWrITvpGNMPeCbFOaylgdI
X-Mailman-Approved-At: Thu, 17 Jul 2014 23:38:14 -0700
Cc: "Black, David" <david.black@emc.com>, "ietf@ietf.org" <ietf@ietf.org>, "ipfix@ietf.org" <ipfix@ietf.org>
Subject: [IPFIX] Gen-ART review of draft-ietf-ipfix-text-adt-07
X-BeenThere: ipfix@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IPFIX WG discussion list <ipfix.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipfix>, <mailto:ipfix-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipfix/>
List-Post: <mailto:ipfix@ietf.org>
List-Help: <mailto:ipfix-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipfix>, <mailto:ipfix-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2014 01:35:27 -0000
In reviewing the changes in the draft for Proposed Standard status (vs. the prior Informational status), I found one small nit: In section 4.2: Otherwise, the values of Information Elements of an unsigned integer type may be represented either as unprefixed base-10 (decimal) strings, as base-16 (hexadecimal) strings prefixed by "0x", or as base-2 (binary) strings prefixed by "0b". In the 2nd line: "type may be represented" -> "type are represented" idnits 2.13.01 misinterpreted [WSP] in the ABNF for octetArray as a reference - the resulting warning should be ignored. Thanks, --David > -----Original Message----- > From: Black, David > Sent: Tuesday, June 24, 2014 5:41 PM > To: Black, David; ietf@trammell.ch; General Area Review Team (gen- > art@ietf.org) > Cc: ietf@ietf.org; ipfix@ietf.org > Subject: Gen-ART review of draft-ietf-ipfix-text-adt-06 > > With correct subject line this time ... > > > -----Original Message----- > > From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Black, David > > Sent: Tuesday, June 24, 2014 5:14 PM > > To: ietf@trammell.ch; General Area Review Team (gen-art@ietf.org) > > Cc: ietf@ietf.org; ipfix@ietf.org > > Subject: Re: [Gen-art] Gen-ART review of draft-ietf-ipfix-text-adt-05 > > > > The -06 version of this draft addresses all of the comments in the > > Gen-ART review of the -05 version. > > > > Nit: I suggest one minor clarification in the added text (insertion > > of the word "comparing" is the primary purpose of this change, feel > > free to edit to taste): > > > > OLD > > See > > [RFC6885] and [I-D.ietf-precis-framework] for more on the dangers of > > Unicode strings.. > > NEW > > See > > [RFC6885] and [I-D.ietf-precis-framework] for more on possible > > unexpected results and related risks in comparing Unicode strings. > > > > Thanks, > > --David > > > > > -----Original Message----- > > > From: Black, David > > > Sent: Friday, May 23, 2014 10:11 PM > > > To: ietf@trammell.ch; General Area Review Team (gen-art@ietf.org) > > > Cc: ipfix@ietf.org; ietf@ietf.org; Black, David > > > Subject: Gen-ART review of draft-ietf-ipfix-text-adt-05 > > > > > > I am the assigned Gen-ART reviewer for this draft. For background on > > > Gen-ART, please see the FAQ at > > > > > > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > > > > > Please resolve these comments along with any other Last Call comments > > > you may receive. > > > > > > Document: draft-ietf-ipfix-text-adt-05 > > > Reviewer: David L. Black > > > Review Date: May 23, 2014 > > > IETF LC End Date: May 28, 2014 > > > > > > Summary: This draft is on the right track, but has open issues > > > described in the review. > > > > > > This is a relatively short draft defining textual representations of > > > IPFIX data elements. It's clear and easy to read. > > > > > > I assume that all the ABNF has been checked. The open issues involve > > > use of Unicode. > > > > > > Minor issues: > > > > > > Section 4.7 string > > > > > > As Information Elements of the string type are simply UTF-8 encoded > > > strings, they are represented directly, subject to the escaping and > > > encoding rules of the Enclosing Context. > > > > > > There's nothing "simply" about use of UTF-8 encoded strings :-). > > > > > > There appear to be no restrictions on Unicode codepoint usage and no > > > requirements for string normalization or other preparation either in this > > > draft or RFC 7011. This can be a formula for all sorts of mischief, so > > > some warnings about what's possible should be added somewhere - some of > > > these comments may be raising Unicode concerns in RFC 7011 that would > > > be better addressed there. > > > > > > A general warning about unreliability of Unicode string comparison > > > is in order. This also applies if an identifier that is not limited > > > to ASCII characters is substituted for an integer as described in > > > Section 4.2. In addition, the concerns around visually similar > > > characters discussed in section 10.5 of the précis framework draft > > > (draft-ietf-précis-framework) apply; a short summary and pointer > > > to that section of that draft should suffice. > > > > > > Section 4.1.5 of the précis framework draft warns against use of mixed- > > > direction Unicode strings, as "there is currently no widely accepted and > > > implemented solution for the processing and safe display of mixed- > > > direction strings." That warning deserves repetition here. > > > > > > Lots of mischief is possible with non-printing and control characters - > > > I would expect that the Enclosing Context contains sufficient restrictions > > > on use of Unicode to deal with most of this concern, and would state that > > > expectation. This comment is definitely specific to this draft. > > > > > > Nits/editorial comments: > > > > > > Section 4.4 float32 and float64 > > > > > > exponent = ( "e" / "E" ) [sign] 1*3DIGIT > > > > > > Please explain why no more than 3 digits are ever required. > > > > > > Section 4.8 dateTime* > > > > > > The '*' in the section title, dateTime* is clever, but it's meaning is not > > > obvious. I suggest "The dateTime Data Types" as a better section title. > > > > > > Section 5 Security Considerations > > > > > > The security considerations for the IPFIX Protocol [RFC7011] apply; > > > this document presents no additional security considerations. > > > > > > That's ok, although adding a direct mention of the [UTF8-EXPLOIT] TR > > > cited in RFC 7011 would be helpful. > > > > > > idnits 2.13.01 warns that the JSON reference (RFC 4627) is obsolete, and > > > needs to be replaced with one or two current RFC references. > > > > > > Thanks, > > > --David > > > ---------------------------------------------------- > > > David L. Black, Distinguished Engineer > > > EMC Corporation, 176 South St., Hopkinton, MA 01748 > > > +1 (508) 293-7953 FAX: +1 (508) 293-7786 > > > david.black@emc.com Mobile: +1 (978) 394-7754 > > > ---------------------------------------------------- > > > > > > > _______________________________________________ > > Gen-art mailing list > > Gen-art@ietf.org > > https://www.ietf.org/mailman/listinfo/gen-art
- [IPFIX] Gen-ART review of draft-ietf-ipfix-text-a… Black, David