Re: [IPFIX] [Technical Errata Reported] RFC7011 (7875)

Benoit Claise <benoit.claise@huawei.com> Tue, 02 April 2024 10:43 UTC

Return-Path: <benoit.claise@huawei.com>
X-Original-To: ipfix@ietfa.amsl.com
Delivered-To: ipfix@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C90EC14F6AC for <ipfix@ietfa.amsl.com>; Tue, 2 Apr 2024 03:43:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.258
X-Spam-Level:
X-Spam-Status: No, score=-6.258 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-2.064, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WyrQzvjaiDd0 for <ipfix@ietfa.amsl.com>; Tue, 2 Apr 2024 03:43:25 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54F96C14F6A2 for <ipfix@ietf.org>; Tue, 2 Apr 2024 03:43:25 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V849d16Bgz67SnG; Tue, 2 Apr 2024 18:38:45 +0800 (CST)
Received: from frapeml500001.china.huawei.com (unknown [7.182.85.94]) by mail.maildlp.com (Postfix) with ESMTPS id 4E32A14065C; Tue, 2 Apr 2024 18:43:21 +0800 (CST)
Received: from [10.48.156.223] (10.48.156.223) by frapeml500001.china.huawei.com (7.182.85.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 12:43:14 +0200
Content-Type: multipart/alternative; boundary="------------evFh2V1yTNPsDFX028l0W4SZ"
Message-ID: <000a9a55-9c2b-a09a-3057-9a5694f1ed0b@huawei.com>
Date: Tue, 02 Apr 2024 12:43:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1
Content-Language: en-US
To: "Brian Trammell (IETF)" <ietf@trammell.ch>, Warren Kumari <warren@kumari.net>
CC: RFC Errata System <rfc-editor@rfc-editor.org>, paitken@cisco.com, ipfix@ietf.org, prevost1@cert.org, mjethanandani@gmail.com, n.brownlee@auckland.ac.nz, trammell@tik.ee.ethz.ch, me <benoit.claise@huawei.com>, Benoit <benoit@claise.be>
References: <CAHw9_iJ5gzqjkOyddwmhCvQ0zpVzOJif6SsWqU0Q4XYzCVhVOw@mail.gmail.com> <B197E164-C330-4D25-A97B-5B5F3719C6B6@trammell.ch>
From: Benoit Claise <benoit.claise@huawei.com>
In-Reply-To: <B197E164-C330-4D25-A97B-5B5F3719C6B6@trammell.ch>
X-Originating-IP: [10.48.156.223]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To frapeml500001.china.huawei.com (7.182.85.94)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipfix/sBsLy-XYH8sQCEjnPSGoEKsRL9Y>
Subject: Re: [IPFIX] [Technical Errata Reported] RFC7011 (7875)
X-BeenThere: ipfix@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IPFIX WG discussion list <ipfix.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipfix>, <mailto:ipfix-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipfix/>
List-Post: <mailto:ipfix@ietf.org>
List-Help: <mailto:ipfix-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipfix>, <mailto:ipfix-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Apr 2024 10:43:29 -0000

Hi Warren,

Yes, this one can be verified.

A little bit of formatting might be required: a sentence between 
parentheses in the middle of no where (after the dot of the previous 
sentence)) is not ideal.

Corrected Text
--------------
Reduced-size encoding MAY be applied to the following integer types: 
unsigned64, signed64, unsigned32, signed32, unsigned16, and signed16. 
The signed versus unsigned property of the reported value MUST be 
preserved. The reduction in size can be to any number of octets smaller 
than the original type if the data value still fits, i.e., so that only 
leading zeroes are dropped. (Or, in the case of negative signed values, 
so that only leading ones are dropped.) For example, an unsigned64 can 
be reduced in size to 7, 6, 5, 4, 3, 2, or 1 octet(s).

Proposed Corrected Text
--------------
Reduced-size encoding MAY be applied to the following integer types: 
unsigned64, signed64, unsigned32, signed32, unsigned16, and signed16. 
The signed versus unsigned property of the reported value MUST be 
preserved. The reduction in size can be to any number of octets smaller 
than the original type if the data value still fits, i.e., so that only 
leading zeroes are dropped (Or, in the case of negative signed values, 
so that only leading ones are dropped). For example, an unsigned64 can 
be reduced in size to 7, 6, 5, 4, 3, 2, or 1 octet(s).

Regards, Benoit

On 4/2/2024 6:30 AM, Brian Trammell (IETF) wrote:
> Yep, this one can be verified.
>
> Sent from my iPhone
>
>> On 1 Apr 2024, at 18:02, Warren Kumari <warren@kumari.net> wrote:
>>
>> 
>> [ - Trammel@tik, +ietf@trammell.ch ; -Benoit@cisco, + 
>> benoit.claise@huawei.com ]
>>
>>
>> Heyya.
>>
>> I'm inclined to mark this as Verified, unless y'all think that that 
>> would violate what the consensus was at the time?
>>
>> Please let me know by the end of the week…
>>
>> W
>>
>> On Thu, Mar 28, 2024 at 3:16 PM, RFC Errata System 
>> <rfc-editor@rfc-editor.org> wrote:
>>
>>     The following errata report has been submitted for RFC7011,
>>     "Specification of the IP Flow Information Export (IPFIX) Protocol
>>     for the Exchange of Flow Information".
>>     --------------------------------------
>>     You may review the report below and at:
>>     https://www.rfc-editor.org/errata/eid7875
>>     <https://www.rfc-editor.org/errata/eid7875>
>>     --------------------------------------
>>     Type: Technical
>>     Reported by: Katherine Prevost <prevost1@cert.org
>>     <mailto:prevost1@cert.org>>
>>
>>     Section: 6.2
>>
>>     Original Text
>>     -------------
>>     Reduced-size encoding MAY be applied to the following integer
>>     types: unsigned64, signed64, unsigned32, signed32, unsigned16,
>>     and signed16. The signed versus unsigned property of the reported
>>     value MUST be preserved. The reduction in size can be to any
>>     number of octets smaller than the original type if the data value
>>     still fits, i.e., so that only leading zeroes are dropped. For
>>     example, an unsigned64 can be reduced in size to 7, 6, 5, 4, 3,
>>     2, or 1 octet(s).
>>     Corrected Text
>>     --------------
>>     Reduced-size encoding MAY be applied to the following integer
>>     types: unsigned64, signed64, unsigned32, signed32, unsigned16,
>>     and signed16. The signed versus unsigned property of the reported
>>     value MUST be preserved. The reduction in size can be to any
>>     number of octets smaller than the original type if the data value
>>     still fits, i.e., so that only leading zeroes are dropped. (Or,
>>     in the case of negative signed values, so that only leading ones
>>     are dropped.) For example, an unsigned64 can be reduced in size
>>     to 7, 6, 5, 4, 3, 2, or 1 octet(s).
>>     Notes
>>     -----
>>     As written, the specification suggests that integer values may
>>     only be encoded using a reduced-size encoding if they have a run
>>     of zeroes at the beginning. However, the specification also
>>     describes being able to use reduced-size encoding for signed
>>     integer values—and only non-negative values of signed integers
>>     have a representation that begins with zeroes.
>>
>>     Either the text should clarify that negative values may never be
>>     expressed using a reduced-size encoding (which is what the
>>     strictest reading of the current text would suggest), or it
>>     should specify that leading ones may also be dropped for signed
>>     values, which makes it clear that they should be interpreted via
>>     sign extension of the high bit.
>>
>>     A quick survey of existing IPFIX implementations suggests that
>>     those which decode reduced-size encoding of integers at all
>>     produce the semantic equivalent of sign extension when they
>>     encounter a reduced-size encoding of a signed integer value.
>>
>>     Instructions:
>>     -------------
>>     This erratum is currently posted as "Reported". (If it is spam,
>>     it will be removed shortly by the RFC Production Center.) Please
>>     use "Reply All" to discuss whether it should be verified or
>>     rejected. When a decision is reached, the verifying party will
>>     log in to change the status and edit the report, if necessary.
>>     --------------------------------------
>>     RFC7011 (draft-ietf-ipfix-protocol-rfc5101bis-10)
>>     --------------------------------------
>>     Title : Specification of the IP Flow Information Export (IPFIX)
>>     Protocol for the Exchange of Flow Information Publication Date :
>>     September 2013
>>     Author(s) : B. Claise, Ed., B. Trammell, Ed., P. Aitken Category
>>     : INTERNET STANDARD
>>     Source : IP Flow Information Export
>>     Stream : IETF
>>     Verifying Party : IESG
>>
>>
>> _______________________________________________
>> IPFIX mailing list
>> IPFIX@ietf.org
>> https://www.ietf.org/mailman/listinfo/ipfix
>
> _______________________________________________
> IPFIX mailing list
> IPFIX@ietf.org
> https://www.ietf.org/mailman/listinfo/ipfix