Re: [IPFIX] Fwd: I-D Action: draft-ietf-ipfix-text-adt-08.txt

Paul Aitken <paitken@cisco.com> Mon, 04 August 2014 08:04 UTC

Return-Path: <paitken@cisco.com>
X-Original-To: ipfix@ietfa.amsl.com
Delivered-To: ipfix@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7A8DE1B28B4 for <ipfix@ietfa.amsl.com>; Mon, 4 Aug 2014 01:04:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HvQpsFbzB0fC for <ipfix@ietfa.amsl.com>; Mon, 4 Aug 2014 01:04:34 -0700 (PDT)
Received: from aer-iport-1.cisco.com (aer-iport-1.cisco.com [173.38.203.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6B3881B28B0 for <ipfix@ietf.org>; Mon, 4 Aug 2014 01:04:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3081; q=dns/txt; s=iport; t=1407139473; x=1408349073; h=message-id:date:from:mime-version:to:subject:references: in-reply-to; bh=c7HZdlK4ZVsxVeqMDTl6Bl8uEC5YtjEi9TIYWhp0Or8=; b=P6FmxkRgW2oYldj0vVsqHVpzsR7i3lJ2C7dGKIm3OX6n/rhufkE5hYQx EFZhfJGs6BW9Ga+Jb4tCeTeJYJIyA4BBi1zLcNx8VeAIdt6ziYHbX0fxJ FxHsn5mze9sdKkVV0iLWkrMgwrLTYJtK3g4FRN3DnEsrn4MyYzCqoFQ/U 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AqAEANw931OtJssW/2dsb2JhbABb2CYBgS13hAQBAQMBeAYLCwQKExYPCQMCAQIBRQYBDAgBAYg2CMQ2F49ThEsBBJwGhyONPINOPA
X-IronPort-AV: E=Sophos;i="5.01,796,1400025600"; d="scan'208,217";a="132498853"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-1.cisco.com with ESMTP; 04 Aug 2014 08:04:31 +0000
Received: from [10.61.109.110] (dhcp-10-61-109-110.cisco.com [10.61.109.110]) by aer-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id s7484UaQ002134; Mon, 4 Aug 2014 08:04:31 GMT
Message-ID: <53DF3E8E.5050905@cisco.com>
Date: Mon, 04 Aug 2014 09:04:30 +0100
From: Paul Aitken <paitken@cisco.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Brian Trammell <ietf@trammell.ch>, "ipfix@ietf.org Group" <ipfix@ietf.org>
References: <20140804050737.28858.12663.idtracker@ietfa.amsl.com> <0CBA48F7-719E-482C-968C-10C00CF57882@trammell.ch>
In-Reply-To: <0CBA48F7-719E-482C-968C-10C00CF57882@trammell.ch>
Content-Type: multipart/alternative; boundary="------------050800010208060007090609"
Archived-At: http://mailarchive.ietf.org/arch/msg/ipfix/vDViNPKOVaafvaNVmi3bLgSs1Jg
Subject: Re: [IPFIX] Fwd: I-D Action: draft-ietf-ipfix-text-adt-08.txt
X-BeenThere: ipfix@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IPFIX WG discussion list <ipfix.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipfix>, <mailto:ipfix-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ipfix/>
List-Post: <mailto:ipfix@ietf.org>
List-Help: <mailto:ipfix-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipfix>, <mailto:ipfix-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2014 08:04:35 -0000

Brian,

> This revision addresses final IETF LC comments on extensibility and copy/paste errors in the examples (thanks, Paul)!

You missed tcpControlBits: since it's defined as unsigned16 in [IANA], 
you should either use unsigned16 or explain why unsigned8 is being used 
(eg, say that reduced-size encoding is being used).

Recall:

>> And tcpControlBits:
>>
>>           tcpControlBits(6)<unsigned8>[1]
>>
>> - has been revised to unsigned16 [RFC7125]. Changing this would also make Figure 2 align more neatly.
>
> It'll probably still be exported as 1 byte everywhere, but the type is indeed unsigned16
>

It would be useful to discuss reduced size encoding and show a specific 
example. eg, if I'm collecting ingressInterface which is nominally a 
u32, but I'm a small device so I only export a u8, should I export:

ingressInterface(10)<unsigned32>[1]

or

ingressInterface(10)<unsigned8>[1]

P.