[ippm] Lars Eggert's No Objection on draft-ietf-ippm-otwamp-on-lag-07: (with COMMENT)

[Lars Eggert via Datatracker <[e-mail]>]

Lars Eggert has entered the following ballot position for
draft-ietf-ippm-otwamp-on-lag-07: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ippm-otwamp-on-lag/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-ippm-otwamp-on-lag-07

CC @larseggert

Thanks to Stewart Bryant for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/1ps0WlynMuNXtHU73X9ulB3K_Ws).

## Comments

### Section 5, paragraph 3
```
     For micro TWAMP sessions, the similar set up procedure as micro OWAMP
     sessions is used.  Then the micro TWAMP Session-Sender sends micro
     Session-Sender packets with the Sender Micro-session ID and the
     Reflector Micro-session ID.  The micro Session-Reflector checks
     whether a test packet is received from the member link associated
     with the correct micro TWAMP session, if the Reflector Micro-session
     ID field is set.  When reflecting, the micro TWAMP Session-Reflector
     copies the Sender Micro-session ID from the received micro Session-
     Sender packet to the micro Session-Reflector packet, and sets the
     Reflector Micro-session ID field with the member link identifier that
     is associated with the micro TWAMP session.  When receiving the micro
     TWAMP Session-Reflector packet, the micro Session-Sender uses the the
     Sender Micro-session ID to check whether the packet is received from
     the member link associated with the correct micro TWAMP session.  The
     micro Session-Sender also use the Reflector Micro-session ID to
     validate the Reflector's behavior.
```
Some critical pieces of the process seem to not be described here. At
the very least, I would have expected to see some text requiring at
least one session needing to be established per member link to
utilize the LAG fully. Are there other such considerations?

### Boilerplate

This document uses the RFC2119 keywords "SHALL", "MAY", "SHOULD",
"RECOMMENDED", "MUST", "NOT RECOMMENDED", "MUST NOT", "SHOULD NOT", "OPTIONAL",
"SHALL NOT", and "REQUIRED", but does not contain the recommended RFC8174
boilerplate. (It contains some text with a similar beginning.)

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Typos

#### Section 2, paragraph 4
```
-    sessions estabilished on member links of a LAG, test packets of micro
-                  -
```

#### Section 6.1, paragraph 0
```
- 6.1.  Mico OWAMP-Control Command
+ 6.1.  Micro OWAMP-Control Command
+          +
```

#### Section 6.2, paragraph 0
```
- 6.2.  Mico TWAMP-Control Command
+ 6.2.  Micro TWAMP-Control Command
+          +
```

### Grammar/style

#### Section 1, paragraph 1
```
ics of every member link of a LAG. Hence the measured performance metrics ca
                                   ^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Hence".


#### Section 4.2.3, paragraph 9
```
 micro TWAMP sessions, the similar set up procedure as micro OWAMP sessions
                                   ^^^^^^
```
When "set-up" is used as a noun or modifier, it needs to be hyphenated.

#### Section 4.2.3, paragraph 12
```
ket, the micro Session-Sender uses the the Sender Micro-session ID to check w
                                   ^^^^^^^
```
Possible typo: you repeated a word.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool