Re: [ippm] Lars Eggert's No Objection on draft-ietf-ippm-ioam-conf-state-07: (with COMMENT)
xiao.min2@zte.com.cn Thu, 27 October 2022 06:13 UTC
Return-Path: <xiao.min2@zte.com.cn>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAD48C1527A8; Wed, 26 Oct 2022 23:13:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.904
X-Spam-Level:
X-Spam-Status: No, score=-1.904 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38F4Mo3VxIBx; Wed, 26 Oct 2022 23:12:56 -0700 (PDT)
Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B1EEC1527A0; Wed, 26 Oct 2022 23:12:53 -0700 (PDT)
Received: from mxct.zte.com.cn (unknown [192.168.251.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Myb2C5g5Vz4xVnf; Thu, 27 Oct 2022 14:12:51 +0800 (CST)
Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4Myb1d53w4z4xq26; Thu, 27 Oct 2022 14:12:21 +0800 (CST)
Received: from njxh01app01.zte.com.cn ([10.41.132.205]) by mse-fl2.zte.com.cn with SMTP id 29R6CGbB052256; Thu, 27 Oct 2022 14:12:17 +0800 (+08) (envelope-from xiao.min2@zte.com.cn)
Received: from mapi (njxh01app01[null]) by mapi (Zmail) with MAPI id mid201; Thu, 27 Oct 2022 14:12:18 +0800 (CST)
Date: Thu, 27 Oct 2022 14:12:18 +0800
X-Zmail-TransId: 2af9635a2142ffffffffb8125b5c
X-Mailer: Zmail v1.0
Message-ID: <202210271412185670392@zte.com.cn>
In-Reply-To: <166677439318.47443.9336754270993402678@ietfa.amsl.com>
References: 166677439318.47443.9336754270993402678@ietfa.amsl.com
Mime-Version: 1.0
From: xiao.min2@zte.com.cn
To: lars@eggert.org
Cc: iesg@ietf.org, draft-ietf-ippm-ioam-conf-state@ietf.org, ippm-chairs@ietf.org, ippm@ietf.org, marcus.ihlar@ericsson.com
Content-Type: multipart/mixed; boundary="=====_001_next====="
X-MAIL: mse-fl2.zte.com.cn 29R6CGbB052256
X-Fangmail-Gw-Spam-Type: 0
X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 635A2163.000 by FangMail milter!
X-FangMail-Envelope: 1666851171/4Myb2C5g5Vz4xVnf/635A2163.000/192.168.251.13/[192.168.251.13]/mxct.zte.com.cn/<xiao.min2@zte.com.cn>
X-Fangmail-Anti-Spam-Filtered: true
X-Fangmail-MID-QID: 635A2163.000/4Myb2C5g5Vz4xVnf
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/Ii9Vlfl2i2zd77eQbCgyIhqhmqo>
Subject: Re: [ippm] Lars Eggert's No Objection on draft-ietf-ippm-ioam-conf-state-07: (with COMMENT)
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Oct 2022 06:13:01 -0000
Hi Lars, Thank you for the review and thoughtful comments. Please check inline the proposed changes that will be incorporated into the next revision. Best Regards, Xiao Min Original From: LarsEggertviaDatatracker <noreply@ietf.org> To: The IESG <iesg@ietf.org>; Cc: draft-ietf-ippm-ioam-conf-state@ietf.org <draft-ietf-ippm-ioam-conf-state@ietf.org>;ippm-chairs@ietf.org <ippm-chairs@ietf.org>;ippm@ietf.org <ippm@ietf.org>;marcus.ihlar@ericsson.com <marcus.ihlar@ericsson.com>;marcus.ihlar@ericsson.com <marcus.ihlar@ericsson.com>; Date: 2022年10月26日 16:53 Subject: Lars Eggert's No Objection on draft-ietf-ippm-ioam-conf-state-07: (with COMMENT) Lars Eggert has entered the following ballot position for draft-ietf-ippm-ioam-conf-state-07: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-ippm-ioam-conf-state/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- # GEN AD review of draft-ietf-ippm-ioam-conf-state-07 CC @larseggert Thanks to Gyan S. Mishra for the General Area Review Team (Gen-ART) review (https://mailarchive.ietf.org/arch/msg/gen-art/wA_8u8-xjQ7sl29P3Qul3W_U_aw) ## Comments ### Section 5.1, paragraph 3 ``` 0b01 - 0b11 are available for assignment via RFC Required process as per [RFC8126]. ``` Since there are only three codepoints remaining, would a stricter assignment policy not make sense? [XM]>>> Yes, a stricter assignment policy make sense to me. Propose to change it as below. NEW 0b01 - 0b11 are available for assignment via IETF Review process as per [RFC8126]. ### Section 5.2, paragraph 3 ``` 0b11 is available for assignment via RFC Required process as per [RFC8126]. ``` Since there is only a single codepoint remaining, would a stricter assignment policy not make sense? [XM]>>> Yes, a stricter assignment policy make sense to me. Propose to change it as below. NEW 0b11 is available for assignment via IETF Review process as per [RFC8126]. ## Nits All comments below are about very minor potential issues that you may choose to address in some way - or ignore - as you see fit. Some were flagged by automated tools (via https://github.com/larseggert/ietf-reviewtool) so there will likely be some false positives. There is no need to let me know what you did with these suggestions. [XM]>>> Understood. Will take care of them, thanks. ### Typos #### Section 3.1, paragraph 4 ``` - begining of the list of IOAM Namespace-IDs. The IOAM encapsulating + beginning of the list of IOAM Namespace-IDs. The IOAM encapsulating + + ``` #### Section 6, paragraph 9 ``` - Except for what's described above, the securiy issues discussed in + Except for what's described above, the security issues discussed in + + ``` ### Grammar/style #### Section 3.2.2, paragraph 9 ``` C9197]. This document defines SoP as follow: 0b00 means 64-bit "PktID" and 6 ^^^^^^^^^ ``` Did you mean "as follows"? #### Section 3.2.6, paragraph 1 ``` th TTL equal to 2 to reach the second nearest node, which also may be an IOAM ^^^^^^^^^^^^^^ ``` It appears that a hyphen is missing. #### Section 4, paragraph 1 ``` s per [RFC8126]. The subsequent sub-sections detail the registries herein co ^^^^^^^^^^^^ ``` This word is normally spelled as one. ## Notes This review is in the ["IETF Comments" Markdown format][ICMF], You can use the [`ietf-comments` tool][ICT] to automatically convert this review into individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT]. [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md [ICT]: https://github.com/mnot/ietf-comments [IRT]: https://github.com/larseggert/ietf-reviewtool
- [ippm] Lars Eggert's No Objection on draft-ietf-i… Lars Eggert via Datatracker
- Re: [ippm] Lars Eggert's No Objection on draft-ie… xiao.min2