[ippm] Tsvart telechat review of draft-ietf-ippm-explicit-flow-measurements-03

Colin Perkins via Datatracker <noreply@ietf.org> Sat, 20 May 2023 13:08 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ippm@ietf.org
Delivered-To: ippm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A45FC151995; Sat, 20 May 2023 06:08:06 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Colin Perkins via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-ippm-explicit-flow-measurements.all@ietf.org, ippm@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 10.4.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168458808616.25500.15425717808464643752@ietfa.amsl.com>
Reply-To: Colin Perkins <csp@csperkins.org>
Date: Sat, 20 May 2023 06:08:06 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/OMrRG_0CG8uRHVz0o6ivqRD8T6g>
Subject: [ippm] Tsvart telechat review of draft-ietf-ippm-explicit-flow-measurements-03
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 May 2023 13:08:06 -0000

Reviewer: Colin Perkins
Review result: Almost Ready

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Thank you for a well-written, well-organised, and clearly motivated draft. This
is a well-specified mechanism that looks appropriate to the intended task. I
have only a few transport-related comments.

§2.2.3: The mechanism to calculate T_max_c is fine, and I’m not suggesting a
change, but I note that protocols such as TCP compute a retransmission timeout
value that is similarly some multiple of the RTT, with a comparable magnitude.
It might be helpful for the draft to discuss why such an existing
protocol-specific value (e.g., Trto in TCP) was not adopted for T_max.

The delay bit mechanism presumably fails if the delay suddenly increases to
more than T_max. Such temporary delay spikes can certainly occur in practise
(e.g., I’ve seen them on poor-quality WiFi links). The draft would benefit from
a discussion of the limitations of the mechanism in detecting edge cases such
as this.

§3.5: The use of an unreported ECN-Echo counter looks appropriate for CE marks
generated in response to ECT(0)-marked traffic following RFC 3168 that generate
CE marks at a rate comparable to that of packet loss. However, flows using L4S
marking with ECT(1), as described in RFC 9331, generate CE marks at a much
higher rate. Would it make sense for the ECN-Echo Event Bit to either
distinguish the two types of CE marking in reports, based on the ECT value of
other packets in the flow, or to be restricted to CE marks generated in
response to ECT(0)-marked packets?  Does the ECN-Echo counter produce usable
results for L4S flows?

Section 6 suggests ways in which additional signals, as described in this
draft, can be included in QUIC or TCP. While I agree that the approaches
suggested could be plausible ways of carrying such additional signals, their
inclusion here could be misinterpreted as specifying an approach rather than
giving examples of possible approaches. It might be more appropriate to either
remove this section, and leave the discussion of how to incorporate these
signals into the protocols to the QUIC and TCPM working groups, or to limit the
discussion of those protocols to noting that there are sufficient unused bits
in their headers to allow these additional signals to be carried.

In the entire draft, there’s an assumption that the paths taken by flows are
stable, or at least traverse the same measurement point, for the duration of
the measurements. It may be helpful to note this.