IETF Logo Mail Archive

Re: [ippm] Last Call: <draft-ietf-ippm-twamp-yang-07.txt> (Two-Way Active Measurement Protocol (TWAMP) Data Model) to Proposed Standard

Mahesh Jethanandani <mjethanandani@gmail.com> Mon, 16 April 2018 14:58 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0984912DA0D; Mon, 16 Apr 2018 07:58:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wTTl6iECpuVh; Mon, 16 Apr 2018 07:58:25 -0700 (PDT)
Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 10E95124319; Mon, 16 Apr 2018 07:58:25 -0700 (PDT)
Received: by mail-pf0-x232.google.com with SMTP id l27so10648303pfk.12; Mon, 16 Apr 2018 07:58:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=VWkIalHZemxeEkreL3R0ONaIKw85HEe1i4/Ro7w9Xiw=; b=jXk/LfdNZzrtdAH0ZKt5zxwcecIrjrWeqiFTtr2gzqROeWXzlWuK8MBIlFy7ZnnHFI J/NC50ZqlD6rLH7Qz2T1wCmMqioTozVpTpAFyikTfZ7inyiSOFOsBCxYXXvKX79WFYUp iG0RiZJOGfmMXhtzHmJIUDAGpBKLiih+hI/Uz48etJuW2kRpJrxwkVX9wuERxMotdYtC Kv+N5IXJo5b09K3xIgcDJYmdgm0F00eQydHdY6hHtvSoH1c8Hcv7TF+xANOiXvVWgi1j jCMWdYm6TUTV598fLbJWdoJWoWpG1X3jvkd/pp2SxXSRcszekjOtMS8XaQsxBi5jFFYS VhNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=VWkIalHZemxeEkreL3R0ONaIKw85HEe1i4/Ro7w9Xiw=; b=inulP9duw6LSicHYoS+86YPEEtNfHSWWpQC6kZmYcGH6Sb/LT+UJllT2lb1oWtFC9U d+RY06TbgVwksYNMZCMsZiaxG3uSLSQUmW754G9Zrzd2PLl+Xx1sEvk3uKEwOKwBJH5L Av1lqmahqzO+MriSmjfycbEkD+VRj9nzqsw04Jxj2j1KIp11rjv7X90Wze4T68/4Mu4I zralhgdoNaWdCda81PxflE+7HKuOxOrgHBGkIAC+5F76dKrtUQYhp4iloR0KfvthKr2W VEEKe1fEdE8EtYLwjFU1IBEvWW5PINxWIqdzRHv09Cv+imr0IfN1OCWhZMKpBqmLYKIW 3iJg==
X-Gm-Message-State: ALQs6tClg/HPnqx0JEdiPwlUh2Mlxo8PjJqBpWhCNGUcgHdYy4iZN6wg lLbHSkelyxh0HAlQXyklWzxnjYcm
X-Google-Smtp-Source: AIpwx48K5+8S6/zWuzwLeSkBAiYETsuv51CDNI51PfpKg0liuQ6zEqk+JqcRajrPJn9EWZwZrX1N/A==
X-Received: by 10.167.134.12 with SMTP id p12mr21987068pfn.183.1523890704604; Mon, 16 Apr 2018 07:58:24 -0700 (PDT)
Received: from ?IPv6:2601:647:4700:1280:1d45:d6e1:6a5e:4f6e? ([2601:647:4700:1280:1d45:d6e1:6a5e:4f6e]) by smtp.gmail.com with ESMTPSA id q62sm31467909pfd.61.2018.04.16.07.58.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 07:58:22 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_21E4E8F4-E6AB-4BD5-83C8-D0A8DE470CF7"
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
From: Mahesh Jethanandani <mjethanandani@gmail.com>
X-Priority: 3
In-Reply-To: <E8B358C4-39EC-4EC2-A1C0-55F292A2177B@gmail.com>
Date: Mon, 16 Apr 2018 07:58:21 -0700
Cc: ietf@ietf.org, ippm-chairs@ietf.org, draft-ietf-ippm-twamp-yang@ietf.org, ippm@ietf.org
Message-Id: <21835DE5-FCE7-44D8-95B4-33B02C8F477F@gmail.com>
References: <008401d3d1ab$2ee8d520$4001a8c0@gateway.2wire.net> <E8B358C4-39EC-4EC2-A1C0-55F292A2177B@gmail.com>
To: "tom p." <daedulus@btconnect.com>
X-Mailer: Apple Mail (2.3445.6.18)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/djy8aTS7zE-2OnplvpqtciYMIkY>
Subject: Re: [ippm] Last Call: <draft-ietf-ippm-twamp-yang-07.txt> (Two-Way Active Measurement Protocol (TWAMP) Data Model) to Proposed Standard
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 14:58:27 -0000

Tom,

On this particular comment ….

> On Apr 12, 2018, at 5:13 PM, Mahesh Jethanandani <mjethanandani@gmail.com> wrote:
> 
>> 
>> 
>> "container session-sender {
>>        if-feature session-sender;
>>        presence  "Enables TWAMP Session-Sender functionality.";
>>        description
>>          "Configuration of the TWAMP Session-Sender logical entity";
>>        leaf admin-state {
>>          type boolean;
>>          mandatory true;
>>          description
>>            "Indicates whether the device is allowed to operate
>>             as a TWAMP Session-Sender.";
>> "
>> 
>> A presence container is a boolean so I am unclear what it is that the
>> admin-state boolean adds here since the presence container "Enables
>> TWAMP Session-Sender functionality.”;
> 
> [mj] Good catch. Will remove the presence statement.

[[mj]] In addition to removing the presence statement, we decided to change the ‘mandatory true' statement to a ‘default true’ statement. Just removing the presence statement results in the following error:

Validating yang/ietf-twamp@2018-04-08.yang <mailto:yang/ietf-twamp@2018-04-08.yang>
yang/ietf-twamp@2018-04-08.yang <mailto:yang/ietf-twamp@2018-04-08.yang>:445: error: RFC 6087: 4.9: top-level node twamp must not be mandatory

Cheers.


Mahesh Jethanandani
mjethanandani@gmail.com

v2.23.0 | Report a Bug | By Email