Re: [ippm] Working Group Last Call on draft-ietf-ippm-stamp-05

David Ball <daviball@cisco.com> Tue, 05 March 2019 16:26 UTC

Return-Path: <daviball@cisco.com>
X-Original-To: ippm@ietfa.amsl.com
Delivered-To: ippm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 729A413105F for <ippm@ietfa.amsl.com>; Tue, 5 Mar 2019 08:26:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.499
X-Spam-Level:
X-Spam-Status: No, score=-14.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FAKE_REPLY_A1=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jw5Wm-UDHE1v for <ippm@ietfa.amsl.com>; Tue, 5 Mar 2019 08:26:02 -0800 (PST)
Received: from aer-iport-4.cisco.com (aer-iport-4.cisco.com [173.38.203.54]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D3EF2131301 for <ippm@ietf.org>; Tue, 5 Mar 2019 08:26:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4325; q=dns/txt; s=iport; t=1551803162; x=1553012762; h=to:from:subject:message-id:date:mime-version; bh=I3vm9OlmkIz8f+Se/Bb+i9dFf8gNgQq8MHPGTXd2Mck=; b=kYRaA4IuuH1aNZCGYSRHxayEy+fK6R8tjfoI8iF4Y3FlQlePM2/eeB7x BMzvhkswFax1IWng7X9cy3GLPa4YRaEpqTb8Bfcrt9Nt1cMudg9wRl0Q9 hS0wn8XpxUoEEPuhIglPI6WvzDiOLAj1umSn3ZASrEE5m5c72xcGVRGIl s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AkAABIon5c/xbLJq1kHAEBAQQBAQcEAQGBUQcBAQsBgndxEieECIgaX4xTklOFc4F7DSWJFzQJDQEBAwEBAwEDAm0cDIV0cQQ+AmwGAgEBgx4BgXUPqlGBLx+FJYRmBYEvAYY3hQeBQD+BEScMgl+DHgEBAgGBSGOCPYJXAqMqXQmHQ4srBhmKeogtkEGFP4cygUc4KIEuMxoIGxWDJ4sMhT8/AzABkRQBAQ
X-IronPort-AV: E=Sophos; i="5.58,444,1544486400"; d="scan'208,217"; a="10500208"
Received: from aer-iport-nat.cisco.com (HELO aer-core-4.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 16:25:59 +0000
Received: from [10.63.23.102] (dhcp-ensft1-uk-vla370-10-63-23-102.cisco.com [10.63.23.102]) by aer-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id x25GPw9S013527 for <ippm@ietf.org>; Tue, 5 Mar 2019 16:25:59 GMT
To: ippm@ietf.org
From: David Ball <daviball@cisco.com>
Message-ID: <3600b860-32f8-0636-7093-eaddd2fb380d@cisco.com>
Date: Tue, 05 Mar 2019 16:25:58 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------C0BA51C5CE377E093B010B17"
Content-Language: en-US
X-Outbound-SMTP-Client: 10.63.23.102, dhcp-ensft1-uk-vla370-10-63-23-102.cisco.com
X-Outbound-Node: aer-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/nAOnkGH9vD60hF4vcFAEqxVWLnI>
Subject: Re: [ippm] Working Group Last Call on draft-ietf-ippm-stamp-05
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2019 16:26:08 -0000

Hi,

I have reviewed the document and am fine with it progressing.

A few nits:

  * The text at the start of Sn 4.1.1 should be before the 4.1.1 heading
    (after the 4.1 heading).
  * Sn 4.1.1 - the bullet about Server Octets has a spurious extra
    part-sentence: "The Reflect Octets capability defined in [RFC6038]."
    - this should be deleted.
  * Fig 4 shows a min length of 112 (if I counted right); but text at
    the start of 4.1.1 says the min length in authenticated mode is 48.
  * The wording/grammar in the paragraph after bullets in Sn 4.4 is a
    little awkward - suggested edits below:

   "In the former case,the  Session-Sender MAY not be aware that its Session-
    Reflector does not support STAMP.  For example,a  TWAMP Light Session-
    Reflector may not support the use of UDP port 862 as defined in
    [I-D.ietf-ippm-port-twamp-test  <https://tools.ietf.org/html/draft-ietf-ippm-stamp-05#ref-I-D.ietf-ippm-port-twamp-test>].  Thus, the  STAMP Session-Sender MUST be
    able to send test packets to destination UDP port numbers  taken  from the
    Dynamic and/or Private Ports range 49152-65535. The  test management
    system should finda  port number that both devices can use.If any
    ofthe  TLV-based STAMP extensions are used, the TWAMP Light Session-
    Reflector will view them as Packet Padding field.  The Session-Sender
    SHOULD use the default format for its timestamps(NTP) but  it MAY
    use PTPv2 timestamp format."


     David


-- 
David Ball
<daviball@cisco.com>