[ippm] Intdir telechat review of draft-ietf-ippm-ioam-direct-export-09

Bernie Volz via Datatracker <noreply@ietf.org> Thu, 23 June 2022 15:34 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ippm@ietf.org
Delivered-To: ippm@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D913C1858FD; Thu, 23 Jun 2022 08:34:01 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Bernie Volz via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: draft-ietf-ippm-ioam-direct-export.all@ietf.org, ippm@ietf.org, last-call@ietf.org, int-ads@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.4.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165599844163.34879.1097143633239570847@ietfa.amsl.com>
Reply-To: Bernie Volz <bevolz@gmail.com>
Date: Thu, 23 Jun 2022 08:34:01 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ippm/zvK1ovk7ucTe8hz1sEp31q-ex-E>
Subject: [ippm] Intdir telechat review of draft-ietf-ippm-ioam-direct-export-09
X-BeenThere: ippm@ietf.org
X-Mailman-Version: 2.1.39
List-Id: IETF IP Performance Metrics Working Group <ippm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ippm>, <mailto:ippm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ippm/>
List-Post: <mailto:ippm@ietf.org>
List-Help: <mailto:ippm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ippm>, <mailto:ippm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jun 2022 15:34:01 -0000

Reviewer: Bernie Volz
Review result: Ready with Nits

I am an assigned INT directorate reviewer for
draft-ietf-ippm-ioam-direct-export. These comments were written primarily for
the benefit of the Internet Area Directors. Document editors and shepherd(s)
should treat these comments just like they would treat comments from any other
IETF contributors and resolve them long with any other Last Call comments that
have been received. For more details on the INT Directorate, see
https://datatracker.ietf.org/group/intdir/about/.

Based on my review of the 09 version of draft-ietf-ippm-ioam-direct-export, if
I was on the IESG I would ballot this document as YES or NO OBJECTION.

I did not find any significant issues.

I do have the following minor issues that I suggest the authors review and
potentially address:

- Section 1, Introduction:
—- Correct the name of the Edge-to-Edge Option-Type to include (E2E) as per
registry and the Proof of Transit option.

- Section 3.2, The DEX Option-Type Format
—- What MUST (or SHOULD) an implementation do if the length of the option
doesn’t match the required multiple of 4 or is either too short or too long
(likely the minimum option size and multiple of 4 may already addressed in
RFC9197), but what if the too few or too many flag bits are set in the
Extension-Flags field given the size of the option? Likely the option should be
ignored?

- Section 4.2, IOAM DEX Flags
—- Would indicating that there are no allocations at present be useful? Perhaps
“Bits 0-7 are available for assignment.” Or something similar?

- Appendix A, Hop Limit in DIrect Exporting
—- The text “The Hop Limit would starts from 0” seems odd. Perhaps “The Hop
Limit starts at 0”?

Thank you for your work on this document.