RE: [Ips] MIB Doctor review: draft-ietf-ips-fcip-mib-08.txt (fwd)

"Wijnen, Bert (Bert)" <bwijnen@lucent.com> Tue, 18 October 2005 13:43 UTC

Received: from localhost.localdomain ([127.0.0.1] helo=megatron.ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1ERrkJ-0006d3-VL; Tue, 18 Oct 2005 09:43:15 -0400
Received: from odin.ietf.org ([132.151.1.176] helo=ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1ERrkI-0006cm-A3 for ips@megatron.ietf.org; Tue, 18 Oct 2005 09:43:14 -0400
Received: from ietf-mx.ietf.org (ietf-mx [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id JAA00260 for <ips@ietf.org>; Tue, 18 Oct 2005 09:43:06 -0400 (EDT)
Received: from ihemail2.lucent.com ([192.11.222.163]) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1ERrvp-0005VZ-Sa for ips@ietf.org; Tue, 18 Oct 2005 09:55:10 -0400
Received: from nl0006exch001h.wins.lucent.com (h135-85-76-62.lucent.com [135.85.76.62]) by ihemail2.lucent.com (8.12.11/8.12.11) with ESMTP id j9IDguXP003397; Tue, 18 Oct 2005 08:43:00 -0500 (CDT)
Received: by nl0006exch001h.nl.lucent.com with Internet Mail Service (5.5.2657.72) id <SQW8Y0WY>; Tue, 18 Oct 2005 15:42:56 +0200
Message-ID: <7D5D48D2CAA3D84C813F5B154F43B15508568621@nl0006exch001u.nl.lucent.com>
From: "Wijnen, Bert (Bert)" <bwijnen@lucent.com>
To: Keith McCloghrie <kzm@cisco.com>
Subject: RE: [Ips] MIB Doctor review: draft-ietf-ips-fcip-mib-08.txt (fwd)
Date: Tue, 18 Oct 2005 15:42:52 +0200
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2657.72)
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 42e3ed3f10a1d8bef690f09da16f507a
Cc: anil@charter.net, ips@ietf.org, "Allison Mankin (E-mail)" <mankin@psg.com>
X-BeenThere: ips@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IP Storage <ips.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/ips>, <mailto:ips-request@ietf.org?subject=unsubscribe>
List-Post: <mailto:ips@ietf.org>
List-Help: <mailto:ips-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/ips>, <mailto:ips-request@ietf.org?subject=subscribe>
Sender: ips-bounces@ietf.org
Errors-To: ips-bounces@ietf.org

OK, so it sounds Allison can mark this doc as "REvised ID needed"

I think I now used the correct email address for ravi

Bert

> -----Original Message-----
> From: Keith McCloghrie [mailto:kzm@cisco.com]
> Sent: Monday, October 17, 2005 11:30
> To: bwijnen@lucent.com
> Cc: ips@ietf.org; ravin@lightsand.com; anil@charter.net
> Subject: [Ips] MIB Doctor review: draft-ietf-ips-fcip-mib-08.txt (fwd)
> 
> 
> Bert,
> 
> You mention several nits which can be fixed by minor edits.  You also
> point out this issue:
> 
> > > - Table fcipLinkErrorsTable contains a lot of Counter32 columns.
> > >   Each of the DESCRIPTION clauses is supposed to describe if there
> > >   can be discontinuity situations, and if so, which timer is to
> > >   be used to detect that.
> >
> > I know Keith has some disagreement with me, but I prefer that
> > it is made clear to the readers/implementors as to do/expect.
> > At least I'd like to see in the Table or Entry DESCRIPTION clause
> > that all counters have "xxx as discontinuity indicator"
> 
> In reviewing the issue for this particular MIB, I do agree with you
> because the Counter32's are in a table INDEX-ed by fcipLinkIndex, and
> the values of fcipLinkIndex are controlled by fcipLinkStatus which has
> a syntax of RowStatus.  Thus, there is a potential for the re-use of a
> previously-used value of fcipLinkIndex to apply to a different link.
> So, these counters definitely need a discontinuity timestamp. 
> I suggest a xxxCreateTime object needs be added in the fcipLinkTable,
> e.g.,:
> 
>     fcipLinkCreateTime OBJECT-TYPE
>         SYNTAX      TimeStamp
>         MAX-ACCESS  read-only
>         STATUS      current
>         DESCRIPTION
>                "The value of sysUpTime when this entry was 
> last created."
>         ::= { fcipLinkEntry 12 }
> 
> so that each of the DESCRIPTIONs for the Counter32's in the
> fcipLinkErrorsTable can include this sentence:
> 
>            The last discontinuity of this counter is indicated by
>            fcipLinkCreateTime.
> 
> (and TimeStamp will need to be IMPORTed from SNMPv2-TC.)
> 
> My apologies to Anil & Ravi that I didn't catch this earlier.
> Also, while the document is being updated, can I suggest that 
> the Authors'
> Addresses section be checked to ensure it has correct email addresses.
> 
> Keith.
> -------------
> Forwarded message:
> > From: "Wijnen, Bert (Bert)" <bwijnen@lucent.com>
> > Date: Mon, 17 Oct 2005 04:01:38 +0200
> > To: "'ravin@lightsand.com'" <ravin@lightsand.com>
> > Cc: "'Ipswg \(E-mail\)'" <ips@ietf.org>
> > Subject: [Ips] MIB Doctor review: draft-ietf-ips-fcip-mib-08.txt
> > Message-ID: 
> <7D5D48D2CAA3D84C813F5B154F43B15508568167@nl0006exch001u.nl.lu
> cent.com>
> > 
> > OK, I have re-checked the new revision (08) of this document.
> > 
> > Here are my findings:
> > 
> > When you revise a MIB module, then both the LAST-UPDATED
> > and REVISION clauses must be kept in sync.
> > 
> >   C:\bwijnen\smicng\work>smicng fcip.inc
> >   W: f(fcip.mi2), (39,21) The first revision should match the
> >      last update for MODULE-IDENTITY fcipMIB
> > 
> > 
> > There still seem to be citation/reference issues:
> > 
> >   !! Missing citation for Normative reference:
> >   P029 L052: [FC-SW-3]   Fibre Channel Switch Fabric -3 
> (FC-SW-3), T11/03-018v4,
> > 
> > I see it is used in a REFERENCE clause in the MIB
> > See below at problem with RFC2571
> > 
> >   !! Missing citation for Normative reference:
> >   P030 L030: [RFC2474]   Nichols, K., Blake, S., Baker, F., 
> and D. Black, "Definition
> > 
> >   !! Missing citation for Normative reference:
> >   P030 L018: [RFC2571]   Harrington, D., Presuhn, R., and 
> B. Wijnen, "An
> > 
> > RFC2571 has been obsoleted by the way by RFC3411.
> > I think you IMPORT from RFC3411
> > Further your IMPORT from RFC4001, which causes a normative reference
> > that I am missing.
> > 
> > Normally you add some text just before the MIB module starts aka
> > 
> >   The following MIB modules has IMPORTS from [RFC3411] and [RFC4001]
> >   and refers  to [FC-SW-3] in REFERENCE clauses.
> > 
> > 
> > Below is my revision 7 review, and I am commenting on the ones that
> > have (as far as I can tell) not been addressed yet:
> > 
> > Following has not been addressed.
> > > - Table fcipLinkErrorsTable contains a lot of Counter32 columns. 
> > >   Each of the DESCRIPTION clauses is supposed to describe if there
> > >   can be discontinuity situations, and if so, which timer is to
> > >   be used to detect that.
> > > 
> > I know Keith has some disagreement with me, but I prefer that
> > it is made clear to the readers/implementors as to do/expect.
> > At least I'd like to see in the Table or Entry DESCRIPTION clause
> > that all counters have "xxx as discontinuity indicator"
> > 
> > > - I think the Security COnsiderations section is weak.
> > >   It lists sensitive objects, but it does not describe much about
> > >   why they are sensitive and what kind of damage can happen if 
> > >   improperly changed.
> > >   The security guidelines on www.ops.ietf.org  explains how it
> > >   should be done in an acceptable manenr
> > > 
> > 
> > I don't think I see any change to the security considerations.
> > Oh well... we'll see what security ADs will have to day about it.
> > 
> > Bert
> > 
> > _______________________________________________
> > Ips mailing list
> > Ips@ietf.org
> > https://www1.ietf.org/mailman/listinfo/ips
> > 
> 

_______________________________________________
Ips mailing list
Ips@ietf.org
https://www1.ietf.org/mailman/listinfo/ips