Re: [IPsec] Benjamin Kaduk's No Objection on draft-ietf-ipsecme-implicit-iv-08: (with COMMENT)

Benjamin Kaduk <kaduk@mit.edu> Fri, 18 October 2019 19:43 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2ABB120817; Fri, 18 Oct 2019 12:43:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5CBTLcJS9lb9; Fri, 18 Oct 2019 12:43:38 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 812E51208DE; Fri, 18 Oct 2019 12:43:38 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x9IJhTIt009810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Oct 2019 15:43:32 -0400
Date: Fri, 18 Oct 2019 12:43:29 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Daniel Migault <daniel.migault@ericsson.com>
Cc: The IESG <iesg@ietf.org>, IPsecME WG <ipsec@ietf.org>, ipsecme-chairs@ietf.org, draft-ietf-ipsecme-implicit-iv@ietf.org, Tero Kivinen <kivinen@iki.fi>
Message-ID: <20191018194329.GK43312@kduck.mit.edu>
References: <157128300620.9968.15171563029563358723.idtracker@ietfa.amsl.com> <CADZyTknmOH=WV-ET8mjr+99sawcgt6H+5aooJvwz_hS+idAM3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CADZyTknmOH=WV-ET8mjr+99sawcgt6H+5aooJvwz_hS+idAM3Q@mail.gmail.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/5YZYzCSEPkacqmfwxdN45kxJDG0>
Subject: Re: [IPsec] Benjamin Kaduk's No Objection on draft-ietf-ipsecme-implicit-iv-08: (with COMMENT)
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Oct 2019 19:43:41 -0000

On Thu, Oct 17, 2019 at 10:37:10PM -0400, Daniel Migault wrote:
>    Hi Benjamin,
>    Thanks you for the comments. Please see in line my responses.  
>    Yours, 
>    Daniel
>    On Wed, Oct 16, 2019 at 11:30 PM Benjamin Kaduk via Datatracker
>    <noreply@ietf.org> wrote:
> 
>      Benjamin Kaduk has entered the following ballot position for
>      draft-ietf-ipsecme-implicit-iv-08: No Objection
> 
>      When responding, please keep the subject line intact and reply to all
>      email addresses included in the To and CC lines. (Feel free to cut this
>      introductory paragraph, however.)
> 
>      Please refer to
>      https://www.ietf.org/iesg/statement/discuss-criteria.html
>      for more information about IESG DISCUSS and COMMENT positions.
> 
>      The document, along with other ballot positions, can be found here:
>      https://datatracker.ietf.org/doc/draft-ietf-ipsecme-implicit-iv/
> 
>      ----------------------------------------------------------------------
>      COMMENT:
>      ----------------------------------------------------------------------
> 
>      Thanks for addressing my Discuss!
> 
>      A few new comments on the -08:
> 
>      Abstract
> 
>      If we're going to differentiate between nonce and IV, I think that
>      the algorithms require a unique but not necessarily unpredictable
>      *nonce*,
>      rather than *IV*.
> 
>    I would preferred to have IV instead of nonce is that IPsec provides
>    constraints on the IV, not the nonce. I expected to have switched from
>    algorithms to their implementations by writing "when used with IPsec" in
>    the previous sentence. In order to flip-flop from algorithm to their
>    implementations with IPsec, I propose to clarify this as follows:
>    OLD:
>    These
>    algorithms require a unique IV but do not require an unpredictable IV.
>    NEW:
>    This IV must be unique but can be predictable.  

Thanks!

> 
>      Section 2
> 
>      nit: s/Initialize/Initialization/
> 
>    Fixed 
> 
>      nit: s/similar mechanism/similar mechanisms/ plural
> 
>    Fixed 
>     
> 
>      Section 7
> 
>      My previous ballot was trying to note that the sender/receiver counters
>      MUST be reset (as noted here) even without this document, as part of
>      the core ESP requirements.  So we don't need to use the "MUST" here as
>      if it's a new requirement; we can just say that this behavior is already
>      present due to the preexisting requirements
> 
>    Well, the reason I included it was that - at least my reading of ESP - ESP
>    seems to require key to be rekeyed when the SN reaches its limit only when
>    anti-replay is activated. In our case, we need to have this property even
>    without anti replay protection. Here is the text I considered rfc4303
>    section 2.2  
>    """
> 
>  The sender's counter and the receiver's counter are initialized to 0
>     when an SA is established.  (The first packet sent using a given SA
>     will have a sequence number of 1; see Section 3.3.3 for more details
>     on how the sequence number is generated.)  If anti-replay is enabled
>     (the default), the transmitted sequence number must never be allowed
>     to cycle.  Thus, the sender's counter and the receiver's counter MUST
>     be reset (by establishing a new SA and thus a new key) prior to the
>     transmission of the 2^32nd packet on an SA.
> 
>    """

Ah, it seems I was reading too quickly and missed the precondition.
Thanks for the attention to detail!

-Ben