Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-rfc8229bis-06

Tero Kivinen <kivinen@iki.fi> Fri, 03 June 2022 16:23 UTC

Return-Path: <kivinen@iki.fi>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4A45C14F723; Fri, 3 Jun 2022 09:23:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.986
X-Spam-Level:
X-Spam-Status: No, score=-3.986 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.876, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=iki.fi
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kz_wwyzYaw7W; Fri, 3 Jun 2022 09:23:12 -0700 (PDT)
Received: from meesny.iki.fi (meesny.iki.fi [IPv6:2001:67c:2b0:1c1::201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 435D9C14F73D; Fri, 3 Jun 2022 09:22:35 -0700 (PDT)
Received: from fireball.acr.fi (fireball.acr.fi [83.145.195.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kivinen@iki.fi) by meesny.iki.fi (Postfix) with ESMTPSA id 1863B20050; Fri, 3 Jun 2022 19:22:31 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1654273351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBoopBNCUnh5q7dDhsqHgud90MMoj6nbgycfz5X30RU=; b=kHOHJCbZXEKB8qr8lIXEyhQUuKoToBzHQEiX7yHbr+nED4KLeF3tZwUFZd6YXkvNZJI4L+ EV8l+NyU9wBUd4UhrYWhpeOQkL267KZft6dfF4gZ/eejWbVdPMUxBHfYMzWVEVNAw4/+c7 aYaThglx5DHtGEnl5d4BvhErMmH4Csw=
Received: by fireball.acr.fi (Postfix, from userid 15204) id 554E525C12B7; Fri, 3 Jun 2022 19:22:30 +0300 (EEST)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-ID: <25242.13638.246694.258002@fireball.acr.fi>
Date: Fri, 03 Jun 2022 19:22:30 +0300
From: Tero Kivinen <kivinen@iki.fi>
To: Valery Smyslov <svan@elvis.ru>
Cc: 'Christian Huitema' <huitema@huitema.net>, secdir@ietf.org, draft-ietf-ipsecme-rfc8229bis.all@ietf.org, ipsec@ietf.org, last-call@ietf.org
In-Reply-To: <0b4301d875b9$ae525320$0af6f960$@elvis.ru>
References: <165377251630.6282.16767658545384357479@ietfa.amsl.com> <077301d8741b$c0fe9b40$42fbd1c0$@elvis.ru> <25237.6715.619617.181961@fireball.acr.fi> <08f501d874df$90e95750$b2bc05f0$@elvis.ru> <25238.13419.293263.562580@fireball.acr.fi> <0a1601d8750e$051083f0$0f318bd0$@elvis.ru> <25239.24036.317688.539399@fireball.acr.fi> <0b4301d875b9$ae525320$0af6f960$@elvis.ru>
X-Mailer: VM 8.2.0b under 26.3 (x86_64--netbsd)
X-Edit-Time: 0 min
X-Total-Time: 0 min
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1654273351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBoopBNCUnh5q7dDhsqHgud90MMoj6nbgycfz5X30RU=; b=g+ki8IZwmUKkHJjjGEh6E/jauSA7A1h+rsyikQk5bTntdjwmau4NBLnY84PfphWNZzXMjv N+tY1JOIU49hU/EboHzulC2wD8OWKdZ+V/f+bv3MHCpAKdn6JJ0oLR2zXq11xK6SaN5fwn Rdgu4jN2vLZm8NNFzC0l9o0Onrez8cw=
ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=kivinen@iki.fi smtp.mailfrom=kivinen@iki.fi
ARC-Seal: i=1; s=meesny; d=iki.fi; t=1654273351; a=rsa-sha256; cv=none; b=IIrYbwb2NqNAOLHDDQwxknUfivgL49faTA/V4EWUB93J2QvkWJ/0VPFzNs6fAPqr/aYtD5 OlckqiZdrr0B/iiTAtdbGgxlRxG//jFmUDeCxx8X3+HUgvHuwVW10Kb7ApzVq2Nm0N9hjX dM4jaN6S25HajdN1XIhJ0N8nxQ9bW5w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/W3YsvXdkQyJWMd0T0KCFOb1OBuE>
Subject: Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-rfc8229bis-06
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jun 2022 16:23:14 -0000

Valery Smyslov writes:
> I still think that it's better to put the text about resync into the
> Security considerations. I think this method is specific for Length
> corruption which most probably will happen as a result of injection
> attack. So, the new para in the Security considerations would look
> like:
> 
>    If an attacker successfully mounts an injection attack on a TCP
>    connection encapsulating IPsec traffic, and a Length field in the TCP
>    stream is changed as a result of this attack, then the receiver in
>    most cases will not be able to correctly identify the boundaries of
>    the following packets in the stream, because it will try to parse an
>    arbitrary data (the result of encryption) as ESP (or IKE) header.
>    This will fail and for this reason all the following packets will be
>    dropped.  Eventually the situation should self-recover, but it may
>    take several minutes and may result in IKE SA deletion and re-
>    creation.  To speed up the recovery implementations are advised to
>    follow recommendations in Section 6.1 and to reset TCP connection in
>    case incoming packets contain an ESP SPI which doesn't correspond to
>    any incoming ESP SA they have.  Once the TCP connection is reset it
>    will be re-created by TCP Originator as described in Section 6.1.
>    Alternatively, implementations MAY try to re-sync after they received
>    unknown SPI by searching the TCP stream for a 64 bit binary vector
>    consisting of a combination of some SPI they know (first 32 bits) and
>    a valid (E)SN for this SPI (another 32 bits) and try to validate the
>    ICV of a packet candidate taking the preceding 16 bits as a Length
>    field.  They can also search for 4 bytes of zero (non-ESP marker)
>    followed by 128 bits of IKE SPIs of IKE SA associated with this
>    stream and try to validate ICV of this IKE message candidate taking
>    the preceding 16 bits as a Length field.

Works for me.
-- 
kivinen@iki.fi