Re: [IPsec] Shepherd review of the draft-ietf-ipsecme-add-ike

mohamed.boucadair@orange.com Tue, 31 January 2023 14:12 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: ipsec@ietfa.amsl.com
Delivered-To: ipsec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86286C14F74F; Tue, 31 Jan 2023 06:12:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sR9xYNMvB_zz; Tue, 31 Jan 2023 06:12:13 -0800 (PST)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9716BC14F693; Tue, 31 Jan 2023 06:12:13 -0800 (PST)
Received: from opfednr03.francetelecom.fr (unknown [xx.xx.xx.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfednr21.francetelecom.fr (ESMTP service) with ESMTPS id 4P5n6z1q7Sz5vbT; Tue, 31 Jan 2023 15:12:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1675174331; bh=LTiX0P4J/ASm3zLfkCe0m/fCq7yE6C18HK8IWndwznE=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=FO9d4pIgKwYC+fM6NXkmh45+AHuuJGjrruU4IMN4j5DXRupWgcx8FNz2hXeU5uIm0 q3+izRn3+I9a/QHEAvnM0JlBiqSXvCA4071JdHuAdK3RfrjOyVxUGtpWPgxqps8q22 l1j/fF0mKTFFxKt7tVbTL8qD9t9g62aGNhCROC6d1lkCeTT48ZLFzswI5zOihb8pW5 EEAxRNFV5GIWOgq8TeAf0lQ/DnP1bYkG6Zg1H++2yWTcS2244kRYMAtQj6sdeer6By bZanPGmygWLyP4bPLq41P0smCwCN6sVPxKCXVieUlEZsWDXP8lp5pn/UKPSg3WmHJ1 4FZ03+h5gsjeQ==
From: mohamed.boucadair@orange.com
To: Tero Kivinen <kivinen@iki.fi>
CC: Valery Smyslov <smyslov.ietf@gmail.com>, "draft-ietf-ipsecme-add-ike@ietf.org" <draft-ietf-ipsecme-add-ike@ietf.org>, "ipsec@ietf.org" <ipsec@ietf.org>
Thread-Topic: [IPsec] Shepherd review of the draft-ietf-ipsecme-add-ike
Thread-Index: AQHZNXrE3elFEGrbSkS8w7HD4zOvqa64jLlg
Content-Class:
Date: Tue, 31 Jan 2023 14:12:10 +0000
Message-ID: <18000_1675174331_63D921BB_18000_434_1_795d7bff776e4ff7a6812da3dd6d9f6c@orange.com>
References: <25560.18262.145478.996578@fireball.acr.fi> <013a01d9354c$c1fe37b0$45faa710$@gmail.com> <31961_1675155778_63D8D942_31961_164_1_567425c5d78042df9598eeadda785f7c@orange.com> <25561.7242.527268.796400@fireball.acr.fi>
In-Reply-To: <25561.7242.527268.796400@fireball.acr.fi>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2023-01-31T13:56:55Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=89a8bad3-4397-4b15-bd15-e1d7142652de; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.27.51]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipsec/yEuR_GkHgGtbi64maQ0qRCzvn0E>
Subject: Re: [IPsec] Shepherd review of the draft-ietf-ipsecme-add-ike
X-BeenThere: ipsec@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Discussion of IPsec protocols <ipsec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipsec>, <mailto:ipsec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipsec/>
List-Post: <mailto:ipsec@ietf.org>
List-Help: <mailto:ipsec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipsec>, <mailto:ipsec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jan 2023 14:12:18 -0000

Re-,

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Tero Kivinen <kivinen@iki.fi>
> Envoyé : mardi 31 janvier 2023 14:49
> À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucadair@orange.com>
> Cc : Valery Smyslov <smyslov.ietf@gmail.com>; draft-ietf-ipsecme-
> add-ike@ietf.org; ipsec@ietf.org
> Objet : RE: [IPsec] Shepherd review of the draft-ietf-ipsecme-add-
> ike
> 
> mohamed.boucadair@orange.com writes:
> > > > Also the text in Num Addresses indicate that it would be
> valid
> > > to send
> > > > CFG_REQUEST with proposed Service Priority, but having Num
> > > Addresses
> > > > set to zero?
> > > >
> > > > Is this intended? I.e., is the client allowed to request
> data,
> > > but not
> > > > propose IP address? If so, perhaps add sentence to Num
> Addresses
> > > > explaining that it can be 0 for CFG_REQUEST when no specific
> > > address
> > > > is request, but other parameters are requested.
> > >
> > > Hm... I think my co-authors can comment on this.
> > >
> >
> > [Med] This is intended. The requestor can suggest any of the
> > parameters in a request. That is already covered by the
> following:
> >
> > * " 0 if the Configuration payload has types CFG_REQUEST (if no
> > * specific DNS resolver is requested) ..."
> > * "If the initiator does not want to request specific DNS
> resolvers,
> > * it sets the Length field to 0 ..."
> > * "For a given attribute type, the initiator MAY send either an
> > * empty attribute or a list of distinct suggested resolvers."
> 
> This is different case.
> 
> I.e., there are (possibly) 3 different formats of CFG_REQUEST:
> 
>   CP(CFG_REQUEST) =
>      ENCDNS_IP6()
> 
> i.e., length = 0, initiator just request responder to send us
> informationfor ENCDNS_IP6.

[Med] Yes.

> 
>   CP(CFG_REQUEST) =
>      ENCDNS_IP6(Service Priority = 0, Num Addresses = 0,
>      		ADN Length = 16, IP addresses = (),
> 		Authentication Domain Name = "doh1.example.com",
> 		Service Paramters = "???")
> 
> i.e., initiator requesting the responder to return information for
> Authentication Domain Name of doh1.example.com, and not providing
> priority or address of it, but perhaps including some service
> parameters it want the that server to have.

[Med] Yes, the initiator may include a suggested ALPN (protocol) for example to specifically indicate it is looking for DoT (or another protocol). The initiator may omit the ADN, but only include service parameters (typically, ALPN) to indicate a preferred transport protocol. 

> 
>   CP(CFG_REQUEST) =
>      ENCDNS_IP6(23, 1, 16,
>                 (2001:DB8:99:88:77:66:55:44),
>      	        "doh1.example.com",
>  	        "???")
> 
> initiator requesting the responder for specific information, most
> likely something that it got last time, and initiator proposes it
> to the responder, in case it is still valid, and responder can
> send that same information back if it is valid, or return
> something else.

[Med] Yeah, but still this is just a suggested value and it is up to the responder to decide to honor it or not. If a preference does not make sense, the response will simply ignore it. 

> 
> Btw, for the second use case where the initiator fills in some of
> the information about the server it wants to talk to, it would be
> usefull to allow Service Priority to be 0, and explictly mention
> that this is not AliasMode, this is meaning that initiator does
> not care about the exact priority or does not know the priority,
> so it used 0 as placeholder.

[Med] The initiator can use any non-null value for the priority in such case. No need to relax the constraint imposed on svcpriority.  

> 
> > > > In IP Address(es) explictly mention that it is field contain
> 4
> > > octet
> > > > IPv4 addresses, or 16 octet IPv6 address without any
> delimeters
> > > etc.
> > > > This can be derived from the calculation of the length
> field,
> > > but I
> > > > think it should be mentioned here, even when it is obvious.
> > >
> > > OK.
> >
> > [Med] Actually, no. We don't have a mix. The AF is determined by
> the
> > attribute type. This is why we have the following: "One or more
> IPv4
> > (for ENCDNS_IP4) or IPv6 (for ENCDNS_IP6)."
> 
> Yes, I know, but it does not say how those IP-addresses are
> encoded in that field. They could be sent out as 16-octet values
> for both IPv4 and IPv6 addresses, where the IPv4 address would
> only use last 4 octets :-) Only way to know that this is not true
> is to check the formula in Length calculation...
> 
> It is obvious that they are encoded as 4 octets for each IPv4
> address and there is nothing between them, and same for IPv6
> addresses, except each address takes 16 octets, but I think it
> would be good to explain it here.
> 
> Something like this:
> 
>    For ENCDNS_IP4 this field contains one or more 4 octet IPv4
>    address, and for ENCDNS_IP6 this field contains one or more 16
>    octet IPv6 address. Address in this field can be used to reach
> ...
> 

[Med] OK, will be fixed. 

> --
> kivinen@iki.fi

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.