IETF Logo Mail Archive

Re: Last Call: <draft-ietf-6man-rfc4941bis-10.txt> (Temporary Address Extensions for Stateless Address Autoconfiguration in IPv6) to Proposed Standard

Fernando Gont <fgont@si6networks.com> Fri, 11 September 2020 04:11 UTC

Return-Path: <fgont@si6networks.com>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44FC13A13C9; Thu, 10 Sep 2020 21:11:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.845
X-Spam-Level:
X-Spam-Status: No, score=-2.845 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.948, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oovjrq_dQvlK; Thu, 10 Sep 2020 21:11:13 -0700 (PDT)
Received: from fgont.go6lab.si (fgont.go6lab.si [91.239.96.14]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 025223A13C6; Thu, 10 Sep 2020 21:10:57 -0700 (PDT)
Received: from [IPv6:2800:810:464:1088:21cc:b3cd:c612:b5ea] (unknown [IPv6:2800:810:464:1088:21cc:b3cd:c612:b5ea]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by fgont.go6lab.si (Postfix) with ESMTPSA id CDAAB280348; Fri, 11 Sep 2020 04:10:52 +0000 (UTC)
Subject: Re: Last Call: <draft-ietf-6man-rfc4941bis-10.txt> (Temporary Address Extensions for Stateless Address Autoconfiguration in IPv6) to Proposed Standard
To: Brian E Carpenter <brian.e.carpenter@gmail.com>, 神明達 哉 <jinmei@wide.ad.jp>
Cc: IETF IPv6 Mailing List <ipv6@ietf.org>, draft-ietf-6man-rfc4941bis@ietf.org, last-call@ietf.org, 6man Chairs <6man-chairs@ietf.org>
References: <159969199185.9541.8823907519726516405@ietfa.amsl.com> <CAKD1Yr1fVnhr3ZM64vLxtXg-9WAKemDuzW2gMupviv-i9V-GiA@mail.gmail.com> <39f91a88-c15d-88d2-5bf4-66168fd61a67@si6networks.com> <c6515826-4849-e128-35c5-37569bf43881@gmail.com> <CAJE_bqexKOjCvBiC4R8hELrVx208ahaEPBOQTMYh--Orioa9NA@mail.gmail.com> <cd8a8cc8-25da-29a4-a6e7-3654e6ba2f04@si6networks.com> <705d2d00-4509-326f-04e6-b04b404f48e9@gmail.com>
From: Fernando Gont <fgont@si6networks.com>
Message-ID: <d175ac36-844b-4a95-ae2d-5cfd24df9687@si6networks.com>
Date: Fri, 11 Sep 2020 00:51:38 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <705d2d00-4509-326f-04e6-b04b404f48e9@gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/W13ogS-TAaWnIyuVpmt7c0dud6Y>
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2020 04:11:17 -0000

On 11/9/20 00:36, Brian E Carpenter wrote:
> Just a detail:
> 
>> (if this was code, you'd do a #define in a single place, and just use
>> that constant)
> 
> Technically, I think it needs to be defined separately for each interface.

Yep. What I was trying to mean is that you don't plage the source code 
with a hard-coded value that is a parameter. That's bad practice.


> So defined in the driver source code, most likely. I have no idea whether
> real implementations do that.
> 
> Apart from that: I agree with Jinmei-san's approach.

wfm, too. Lorenzo?

Thanks,
-- 
Fernando Gont
SI6 Networks
e-mail: fgont@si6networks.com
PGP Fingerprint: 6666 31C6 D484 63B2 8FB1 E3C4 AE25 0D55 1D4E 7492

v2.23.0 | Report a Bug | By Email