Re: Validation of Packet Too Big Payload using Echo Request

Timothy Winters <tim@qacafe.com> Wed, 29 July 2020 20:15 UTC

Return-Path: <tim@qacafe.com>
X-Original-To: ipv6@ietfa.amsl.com
Delivered-To: ipv6@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D10C33A0EC8 for <ipv6@ietfa.amsl.com>; Wed, 29 Jul 2020 13:15:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=qacafe.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sXGOnWGtC5oU for <ipv6@ietfa.amsl.com>; Wed, 29 Jul 2020 13:15:47 -0700 (PDT)
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B4A13A0EC6 for <6man@ietf.org>; Wed, 29 Jul 2020 13:15:46 -0700 (PDT)
Received: by mail-lj1-x22d.google.com with SMTP id x9so26449349ljc.5 for <6man@ietf.org>; Wed, 29 Jul 2020 13:15:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qacafe.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U/Zu3eAvSA3Sa5ImPXVQV4z4csuoeT4aCLC8Akq9F/U=; b=LimbxHgmIURgKxGoABvQqMnNT9xnK+jrTtVEc6H6MFlcG+Ztug6WJXfKG9cQOicHIL yqmUZvJvKfwiLajUSaIiBkOpYGeRXyc9KegiHx38m31dpV0DJfO4H8iJuxKRQSyPoAvN hz+AqFbDuywKIgFoQs9NLWOhaCo6qDvVUvGI4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U/Zu3eAvSA3Sa5ImPXVQV4z4csuoeT4aCLC8Akq9F/U=; b=ERh/q0VKWJ80CPB1iUrHImhOKMB2DF9ljMiqzNVfcVKrNH5Z0k/r1qlJ4ArcRC+ac9 W2BOanp8LgdIFITMfr1onFABoxEGCrOK0LPpAec1ioZt/9VST4htXddkNS0ruW1ysY3A /bi/AiEALeJ/oSP8fh4MJc54ZRx2Dzr4NuY+xRdgaYlwz3ZbPy3YdznUKP1r4u3uUlcT +cDv44A8jA8nujOk3CUoASzjDWYkjUj6DKmWEx2LOCznRXas2QPDn8tlY1IDZZVNsPux xut3LaaCoKOozcSrcYeYbbDPbeNBY7Yem9CttqmQ7+XgwKew/IAPBu1PmWGfLDDkUBgZ hd/g==
X-Gm-Message-State: AOAM532pNcb5tIwG7ef/NSarUGC8UkfKkXHxPaeit1jRulC2dfhMlsl4 JUlWgr0D6XIHktWBchzLGN2vc6650/9WK568LhRT4Q==
X-Google-Smtp-Source: ABdhPJxRWJSmFnHdzKRuKRteVRcB+GSGYgNA/rNhX6l1LZNFG8c2GzLndORRjcDEiNbkwUPEMTUhAlrr0318FoM5eXg=
X-Received: by 2002:a2e:8ed6:: with SMTP id e22mr69912ljl.426.1596053744917; Wed, 29 Jul 2020 13:15:44 -0700 (PDT)
MIME-Version: 1.0
References: <26C02BD5-96CC-44D1-9CCB-00DE059D40D9@employees.org> <20200728114355.GF39464@shawns-mbp.lan> <CAJgLMKuzreN7Er5yebbxtZWwp-A1EXuqAYaF6ZgqF6NyhaPaFA@mail.gmail.com> <CAKD1Yr0MWME0Te6Sek5Kyi_TZT2sPo_HPoZce5rrU1oJSxsYBw@mail.gmail.com> <DE991374-96A4-4CCC-9D5B-CC97CC5B361F@apple.com>
In-Reply-To: <DE991374-96A4-4CCC-9D5B-CC97CC5B361F@apple.com>
From: Timothy Winters <tim@qacafe.com>
Date: Wed, 29 Jul 2020 16:15:33 -0400
Message-ID: <CAJgLMKsX=+cUbfpfWxnxVNbV9GUSdtX5v0hog_yLFGdmvgb=Lg@mail.gmail.com>
Subject: Re: Validation of Packet Too Big Payload using Echo Request
To: Prabhakar Lakhera <plakhera@apple.com>
Cc: Shawn Zhang <yuanshan_zhang=40apple.com@dmarc.ietf.org>, 6MAN <6man@ietf.org>, Timothy Winters <twinters@iol.unh.edu>, Lorenzo Colitti <lorenzo@google.com>
Content-Type: multipart/alternative; boundary="00000000000082afc005ab9a3812"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ipv6/fHh0y0TW8quzpfXvrZBO7RHH5aI>
X-BeenThere: ipv6@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "IPv6 Maintenance Working Group \(6man\)" <ipv6.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ipv6>, <mailto:ipv6-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ipv6/>
List-Post: <mailto:ipv6@ietf.org>
List-Help: <mailto:ipv6-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ipv6>, <mailto:ipv6-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 20:15:51 -0000

I think we are discussing two different things here. One is about IPv6
Ready Logo SHOULD position and another about the RFC clause in question.

As a reminder SHOULD is defined in RFC 2119 as:

"This word, or the adjective "RECOMMENDED", mean that there
   may exist valid reasons in particular circumstances to ignore a
   particular item, but the full implications must be understood and
   carefully weighed before choosing a different course "

IPv6 Ready Logo has been required SHOULD/MUST based on this definition for
the last 15 years.  The reason for this is we want devices to support these
interoperable standards, if they have a good reason for not implementing
it, they can state it.  We've had several companies with security reasons
not implement a SHOULD.  Also we allow for Advanced features, for things
such a ping since not all devices have a method for initiating a ping.

For this clause in particular, it's also a security risk to accept all
Packet Too Big messages without checking if the offending packet was
valid.   Currently the line applies to all traffic, maybe we can all work
on a draft to update this language to not apply to traffic but something
more realistic?

~Tim

On Wed, Jul 29, 2020 at 2:16 PM Prabhakar Lakhera <plakhera@apple.com>
wrote:

> Specially, given the proposed test expects node to be stateful with ICMPv6
> Echo Replies.
> That just opens up another window of exploit.
>
> It is also not great that one can only provide “best effort” checks. That
> is do one thing for ICMPv6, check for tuple for UDP, additionally check for
>  sequence numbers for TCP.
>
> Given the MTU has lower bound of 1280, the requirement should *not* be
> part of IPv6 ready logo as a must. The spec says it is a should, and that’s
> how it needs to be read.
>
> Thanks!
>
> On Jul 29, 2020, at 5:02 AM, Lorenzo Colitti <lorenzo@google.com> wrote:
>
> I'm not sure that the desired behaviour is reasonably implementable.
> Wouldn't it require the sending node to keep state on all packets it had
> ever sent? For how long?
>
> The implementation can relatively easily check if a PTB matches an
> *existing* socket. But what if the following happens?
>
> 1. App opens UDP socket, sends packet.
> 2. App closes socket.
> 3. PTB arrives for packet in step #1.
> 4. App opens socket on same port again, sends identical packet again.
>
> If the stack rejects the packet in #3, arguably it makes things worse. But
> accepting it is difficult without keeping state on sockets after they are
> closed, which is both ill-defined (how long do you need to keep the state?)
> and potentially expensive / exposing a DoS vector.
>
> On Tue, Jul 28, 2020, 21:00 Timothy Winters <tim@qacafe.com> wrote:
>
>> Hi Shawn,
>>
>> If you are referring to the IPv6 Ready Logo Core Test Specification for
>> this, we have a possible problem for this validation test case for devices
>> that don't track ICMPv6 connections.
>>
>> *"Possible Problems: * If the device under test does not support
>> tracking connections for ICMPv6 this test case may be omitted."
>>
>> If you have other questions about IPv6 Ready please feel free to take
>> this to the info@ipv6ready.org.
>>
>> ~Tim
>>
>> On Tue, Jul 28, 2020 at 7:48 AM Shawn Zhang <yuanshan_zhang=
>> 40apple.com@dmarc.ietf.org> wrote:
>>
>>> Hi Ole,
>>>
>>> I am reviving this thread.
>>>
>>> >> Frankly, I think for compliance this should be treated as a *SHOULD*
>>> and not as a MUST.
>>>
>>> > Yes, I think that's a correct interpretation.
>>> > That's what 8201 says too. "Nodes should appropriately validate..."
>>>
>>> Since RFC8201 says “SHOULD” instead of “MUST”, should this test be
>>> removed from the compliance test as it is not a mandatory behavior?
>>>
>>> IMHO, since the smallest packet size is capped at 1280, it won't cause
>>> too much risk  even if we don't verify it using Echo Request here.
>>>
>>> Bests,
>>> Shawn
>>>
>>> --------------------------------------------------------------------
>>> IETF IPv6 working group mailing list
>>> ipv6@ietf.org
>>> Administrative Requests: https://www.ietf.org/mailman/listinfo/ipv6
>>> --------------------------------------------------------------------
>>>
>> --------------------------------------------------------------------
>> IETF IPv6 working group mailing list
>> ipv6@ietf.org
>> Administrative Requests: https://www.ietf.org/mailman/listinfo/ipv6
>> --------------------------------------------------------------------
>>
>
>