Re: [Isis-wg] AD review of draft-ietf-isis-mi-bis-01

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Fri, 17 March 2017 20:05 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E774E129519; Fri, 17 Mar 2017 13:05:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fnUOFl-YfR1r; Fri, 17 Mar 2017 13:05:09 -0700 (PDT)
Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 539B6129529; Fri, 17 Mar 2017 13:05:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=46320; q=dns/txt; s=iport; t=1489781109; x=1490990709; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=/tYXQBZDn1rLTBmsQ1ToJkx3DJdMbKqIXuKF52xDwzQ=; b=DG1SzFDy2BvnEUP5scZS3a+XL/GLyuLUrtYJpqhMtpCirhFA2atCf7NJ ZJ7a63agBYFdRZsf6YxBN+iFD05i1ktNfP8tBAUUT5S98Y+wcOvosrOP2 E2IzqvETGj8U5uKUFVz15azyOxahsD1NbI7OSQCsLSeAB+okStPCphyLR w=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CxAQAGQcxY/4YNJK1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBgm45KmGBCgeDW4oPkVuIEo0wgg6GIgIagmc/GAECAQEBAQEBAWs?= =?us-ascii?q?ohRUBAQEBAx0GClwCAQYCEQQBASEBBgMCAgIfERQJCAIEARIIE4lNAxWUep1bg?= =?us-ascii?q?iaHMw2DCQEBAQEBAQEBAQEBAQEBAQEBAQEBAR2GToRvglGCGh+CUIJfBYoDi36?= =?us-ascii?q?GDjoBiiCDJkqEKIIEGI8YiE6CEohyAR84gQRYFYUYHYFjdYhKgQ0BAQE?=
X-IronPort-AV: E=Sophos;i="5.36,178,1486425600"; d="scan'208,217";a="395708794"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Mar 2017 20:05:08 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id v2HK585X016565 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 17 Mar 2017 20:05:08 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 17 Mar 2017 15:05:07 -0500
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1210.000; Fri, 17 Mar 2017 15:05:07 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Uma Chunduri <uma.chunduri@huawei.com>, Alia Atlas <akatlas@gmail.com>, "isis-wg@ietf.org" <isis-wg@ietf.org>, "draft-ietf-isis-mi-bis@ietf.org" <draft-ietf-isis-mi-bis@ietf.org>
Thread-Topic: AD review of draft-ietf-isis-mi-bis-01
Thread-Index: AQHSnzW2SbE6C4ZbzUa6gBdVacKo6KGZTDKwgABd8AD//6/X0IAAWLKA//+wBhA=
Date: Fri, 17 Mar 2017 20:05:07 +0000
Message-ID: <66747b32bd0a4bb5a920736eca0b491a@XCH-ALN-001.cisco.com>
References: <CAG4d1reSNUyDZwUN1tB4zJAJcfs40618_x5DpFofr99cQc3B0g@mail.gmail.com> <43be9b6ac3fa41708303a2a352360ab4@XCH-ALN-001.cisco.com> <25B4902B1192E84696414485F572685401886050@SJCEML703-CHM.china.huawei.com> <d35ee990ce104caaad61bd389c941dc4@XCH-ALN-001.cisco.com> <25B4902B1192E84696414485F57268540188607C@SJCEML703-CHM.china.huawei.com>
In-Reply-To: <25B4902B1192E84696414485F57268540188607C@SJCEML703-CHM.china.huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.83.223]
Content-Type: multipart/alternative; boundary="_000_66747b32bd0a4bb5a920736eca0b491aXCHALN001ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/isis-wg/DM8HX9XBEZ14zoIosHNGw4oP3HQ>
Subject: Re: [Isis-wg] AD review of draft-ietf-isis-mi-bis-01
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Mar 2017 20:05:12 -0000

Uma –

I am not aware of any requirement to have the original set of authors be authors of a bis document – and there are certainly other examples where authorship has changed. And there are obvious practical reasons why authorship may change.

The authors of the bis draft are the ones who actively participated in the writing of the bis draft. The fact that some of the authors of RFC 6822 did not participate in the writing of the bis draft  in no way diminishes their past contributions which are permanently recorded in RFC 6822.

I’ll let Alia take it from here from an official IETF process standpoint.

   Les


From: Uma Chunduri [mailto:uma.chunduri@huawei.com]
Sent: Friday, March 17, 2017 11:45 AM
To: Les Ginsberg (ginsberg); Alia Atlas; isis-wg@ietf.org; draft-ietf-isis-mi-bis@ietf.org
Subject: RE: AD review of draft-ietf-isis-mi-bis-01

Les,

Thx for the clarification.

I too agree on this (couldn’t notice this earlier more thoroughly..) and in that case why original authors were completely replaced with new set of folks as opposed to adding?

W.r.t. this, why we how to do this differently while numerous other WGs just do the addition and the ratified changes to the original document.

My view is we need not be different here but would be happy to listen from you, AD and other esteemed members of this group.

--
Uma C.

From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com]
Sent: Friday, March 17, 2017 11:30 AM
To: Uma Chunduri <uma.chunduri@huawei.com<mailto:uma.chunduri@huawei.com>>; Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>; isis-wg@ietf.org<mailto:isis-wg@ietf.org>; draft-ietf-isis-mi-bis@ietf.org<mailto:draft-ietf-isis-mi-bis@ietf.org>
Subject: RE: AD review of draft-ietf-isis-mi-bis-01

Uma –

I agree w Alia’s evaluation that this replaces RFC 6822.

   Les


From: Uma Chunduri [mailto:uma.chunduri@huawei.com]
Sent: Friday, March 17, 2017 11:15 AM
To: Les Ginsberg (ginsberg); Alia Atlas; isis-wg@ietf.org<mailto:isis-wg@ietf.org>; draft-ietf-isis-mi-bis@ietf.org<mailto:draft-ietf-isis-mi-bis@ietf.org>
Subject: RE: AD review of draft-ietf-isis-mi-bis-01

>4) In the IANA considerations, the references should be updated to point to this document, and most particularly if it obsoletes RFC 6822.
>[Les:] Agreed. I did not think I had to state that – I assumed IANA would just do that – but I am happy to add a line in IANA section stating that all references to RFC 6822 should be updated to point to this document.

Quick comment:

Currently document says it updates 6822 – which is correct?

-          I can guess but want to hear author thoughts..


--
Uma C.

From: Isis-wg [mailto:isis-wg-bounces@ietf.org] On Behalf Of Les Ginsberg (ginsberg)
Sent: Friday, March 17, 2017 10:57 AM
To: Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>; isis-wg@ietf.org<mailto:isis-wg@ietf.org>; draft-ietf-isis-mi-bis@ietf.org<mailto:draft-ietf-isis-mi-bis@ietf.org>
Subject: Re: [Isis-wg] AD review of draft-ietf-isis-mi-bis-01

Alia –

Thanx for meticulous review.
Inline.

From: Alia Atlas [mailto:akatlas@gmail.com]
Sent: Friday, March 17, 2017 8:47 AM
To: isis-wg@ietf.org<mailto:isis-wg@ietf.org>; draft-ietf-isis-mi-bis@ietf.org<mailto:draft-ietf-isis-mi-bis@ietf.org>
Subject: AD review of draft-ietf-isis-mi-bis-01

As is customary, I have done my AD review of draft-ietf-isis-mi-bis-01.  First, I would like to thank the authors - Les, Stefano, and Wim - for their work on this document.

I do have a few minor issues that need to be fixed ASAP.   I will, however, go ahead and issue a 3 week IETF Last Call for it so that, if the authors act promptly, it can be on the April 13 telechat.


1) This draft pretty clearly should obsolete RFC 6822, but the header claims to merely
update it.

[Les:] OK

 2) Sec 2.6.2: " Point-to-point adjacency setup MUST be done through the use of the
         three-way handshaking procedure as defined in [RFC5303] in order to
         prevent a non-MI capable neighbor from bringing up an adjacency
         prematurely based on reception of an IIH with an IID-TLV for a non-
         zero instance."
     While obviously the 3-way handshake in RFC5303 is fine, given that different MAC addresses are used, I don't see how a non-MI capable neighbor would receive and process an IIH with an IID-TLV where IID != 0.

[Les:] Section 2.6.2 is only talking about true pt-pt media – hence MAC multicast addresses are not relevant. In Section 2.6.1 we discuss the case of operating in Pt-Pt mode on a broadcast circuit:

“When operating in point-to-point mode on a broadcast circuit
   [RFC5309]…”


3) In Appendix A:" Clarification that the IID-TLV is only included in Pt-Pt IIHs
   associated with non-zero instances has been added.  This addresses
   Errata ID #4519."
   In Sec 2.6.2, it says "The presence or absence of the IID-TLV in an IIH indicates that the
   neighbor does or does not support this extension, respectively.
   Therefore, all IIHs sent on a point-to-point circuit by an MI-RTR
   MUST include an IID-TLV.  This includes IIHs associated with IID #0." which is a direct
   contradiction and needed since the IID-TLV is used as a capability indication.  The
   simplest solution is to remove the claim from the Appendix.
[Les:] Again, you are confusing Pt-Pt media with Pt-Pt operation on a Broadcast media. Errata 4519 is concerned with Pt-Pt operation on a LAN – and some modest clarifications in Section 2.6.1 were made to more completely cover the latter case.
In the Pt-Pt operation on a LAN case it IS illegal to send IID-TLV in hellos for the zero instance – which Section 2.6.1 explicitly states.

Perhaps the Appendix should say:

“Clarification that when operating in point-to-point mode on a broadcast circuit the IID-TLV is only included in Pt-Pt IIHs
   associated with non-zero instances has been added. ..”

Will this address your concern?

4) In the IANA considerations, the references should be updated to point to this document, and most particularly if it obsoletes RFC 6822.

[Les:] Agreed. I did not think I had to state that – I assumed IANA would just do that – but I am happy to add a line in IANA section stating that all references to RFC 6822 should be updated to point to this document.


Let me know if the above changes will suffice and I will spin a new version.

   Les

Regards,
Alia