Re: [ipwave] Patching Linux Kernel with OCB

Sara el hamdani <saraelhamdani@gmail.com> Sun, 23 June 2019 23:33 UTC

Return-Path: <saraelhamdani@gmail.com>
X-Original-To: its@ietfa.amsl.com
Delivered-To: its@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32D11120165 for <its@ietfa.amsl.com>; Sun, 23 Jun 2019 16:33:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxhhHBHA60j7 for <its@ietfa.amsl.com>; Sun, 23 Jun 2019 16:33:09 -0700 (PDT)
Received: from mail-yw1-xc2b.google.com (mail-yw1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3AC1B12001A for <its@ietf.org>; Sun, 23 Jun 2019 16:33:09 -0700 (PDT)
Received: by mail-yw1-xc2b.google.com with SMTP id b143so5129638ywb.7 for <its@ietf.org>; Sun, 23 Jun 2019 16:33:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yg2ZmD09c8ilfnBfmKYF6h8CDXkF1LdOpU9gk30NCbA=; b=abMsXDvGtyM0XheTlSrr5LixT649jrUEolsQ++JsgAu9ckJ7CLWfneraXJBUG+zcrl Oh7pWOt+DtfW0AHQK97jcjUO/0xehln3nzWsUkqeHBmTMdm2zj6VB+62/O671xDsqter f1n1Zff213tA6dQ4BFqqC8oKiLZX+dI8tCvy5XB7fs2kp07CtD9KvIwagkGZI+W8r9V0 ir/zf2oFbhehtB/cFUjMw4/rvgk4sj0jxpdpOost+NrFHlZNo4aNOyptXqYMjX+rtl3/ GKckcxXkr4GiacoMcVknmPlcyKmaewvDHjH3zJuZGWqsy9HUxfImpVxyJhWDDiXQ2VHP x5bw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yg2ZmD09c8ilfnBfmKYF6h8CDXkF1LdOpU9gk30NCbA=; b=q5eZe2Se2WkUrQQ2z4TDhtPXk0hN63p4qooXhe62E34r9wl1+JddiyBqD9ZurbNUEn K17Q1tgCIhex+M/qHwNiaX8EPxoKTLCU1X+bxc+b1sKnYzlLpkVghDYN2+v0dIDwUMn7 kGayTmbsi1LMEV0i9pPWdjcAVjJk4gviS7ZOZvd4Blv5XxNAwd/JfBJOEq0e0eGRaedf 7s9UPys90lWv5Jrgcfj91yEhMTKVKl61J74eBwtKDfVqfOx3qhNaFw9f4+EE0jaxQdhQ 3GzOa71qxnokNazNIK1QBRha3ztZEXQ4O4GgZH7ZcyBm8KET+QH18LOmfdMuUl15/P+T 4yfg==
X-Gm-Message-State: APjAAAUEdn6EO0HgX4+TOQfbLiVSt2zf7HJlFR8BAUpOJQYNk/Mldw+G Z+a3hMgxE2VWljX79v56MPOBAUHabS7PIaWh8LeuxDQE
X-Google-Smtp-Source: APXvYqylKRdmcoXmzOARJ7djuLfZNMTQxAMkViyBiPok/5qAv/6run3M/K/7zjMBhQMx7FbZtSQ1n8AfS20ZlEW6Puc=
X-Received: by 2002:a81:838d:: with SMTP id t135mr70658846ywf.56.1561332786872; Sun, 23 Jun 2019 16:33:06 -0700 (PDT)
MIME-Version: 1.0
References: <CAM9JMHPbfhNgvDgJP3kMj7VG2DRGa6-t1bbfSrqHeGH62kW1Zg@mail.gmail.com> <d592be28-1160-eeef-7239-2878c35bc2a1@gmail.com> <CAMugd_UzXo_1Usu8k7jR0TjbSEMSnprAFcD4R7Lz8Hwx1g7rqA@mail.gmail.com>
In-Reply-To: <CAMugd_UzXo_1Usu8k7jR0TjbSEMSnprAFcD4R7Lz8Hwx1g7rqA@mail.gmail.com>
From: Sara el hamdani <saraelhamdani@gmail.com>
Date: Mon, 24 Jun 2019 00:32:28 +0100
Message-ID: <CAJ0NgkDGd83nxqw=BiNCQR1MieFgMVneV=rKbgTUBQzZ=d1m2w@mail.gmail.com>
To: its@ietf.org
Cc: Alexandre Petrescu <alexandre.petrescu@gmail.com>, Nabil Benamar <benamar73@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000234592058c061e79"
Archived-At: <https://mailarchive.ietf.org/arch/msg/its/OOZICBPYeUiloSH9Myr_u_QRQoU>
Subject: Re: [ipwave] Patching Linux Kernel with OCB
X-BeenThere: its@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IPWAVE - IP Wireless Access in Vehicular Environments WG at IETF <its.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/its>, <mailto:its-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/its/>
List-Post: <mailto:its@ietf.org>
List-Help: <mailto:its-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/its>, <mailto:its-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jun 2019 23:33:12 -0000

Hello Alex,

Many thanks for sharing your insights.

Indeed, we knew during the hackathon that we should better patch the
kernel in its newest version 5.1.12. However, we couldn't create a new
patch because of the lack of time as mentioned Mr, Nabil. In fact, we
didn't have the right adapter for the physical OCBcard we had. So, we whole
first day spent the the first day trying to install the card on the desktop
including creating manually the adequate antenas.  Then, we had  only six
hours in the next day to capture IPv6 packets patching and recompiling the
kernel ect.

We have recommended to the organizers the reserve more time to this truck
in future hackathons. We think also that creating a new patch for the
current linux of the kernel is worth to be the object of an independent
truck in the hackathon.

Concerning the parameters, we have tested the connectivity using ath9k
driver successfully, and we were about to do the same for ath10k but it was
the already presentation time (as we aforementioned a lack of time).

For the patch creator, we don't know honestly who he is, but we have found
the link mentioned on a previous email of you in the link:
https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view. Thus, we
decided to fix it and to make it work.

Besides, even if we arrived to patch the kernel with ath9k, the report in
the terminal showed that it was not completely successful (not 100%) and it
seems that this is what happens usually. So based on your big in you
experience, Mr. Alex, on creating and patching the kernel, we would know if
it is common for you to patch the kernel successfully 100%?


Sara

Le ven. 21 juin 2019 à 12:41, Nabil Benamar <benamar73@gmail.com> a écrit :

> Hi Alex,
>
> Thank you for your comments.
> This is exactly what the hackathon participants put in future work!
>
> 2 days were not enough to build the testbed and test different drivers and
> parameters...
>
> On Fri, Jun 21, 2019, 14:01 Alexandre Petrescu <
> alexandre.petrescu@gmail.com> wrote:
>
>> Hello Mr. Seur,
>>
>> I would like to ask you whether you can apply that patch to ath10k also?
>> (instead of ath9k).
>>
>> If you do, you risk being the first to achieve 1Gbps on OCB, hopefully
>> with IPv6.
>>
>> Alex
>>
>> Le 20/06/2019 à 15:25, John Seur a écrit :
>> > Hello IPWavers,
>> >
>> > During the Hackathon@AIS2019
>> > (https://hackathon.internetsummitafrica.org/), the team in IPWave
>> track
>> > (led by Nabil Benamar) was patching the Linux kernel 4.9.61 with OCB
>> > mode and discovered the following bugs in the patch file
>> > (https://drive.google.com/file/d/0BxK6WTQZ97QVWF9tRURjOGhBU2c/view).
>> >    drivers/net/wireless/ath/ath9k/main.c:961:2: error: duplicate case
>> value
>> >    case NL80211_IFTYPE_OCB:
>> >    drivers/net/wireless/ath/ath9k/hw.c:1241:2: error: duplicate case
>> value
>> >    case NL80211_IFTYPE_OCB:
>> >
>> > The duplicated lines of code were commented out and the patch file
>> works!
>> >
>> > _______________________________________________
>> > its mailing list
>> > its@ietf.org
>> > https://www.ietf.org/mailman/listinfo/its
>> >
>>
>> _______________________________________________
>> its mailing list
>> its@ietf.org
>> https://www.ietf.org/mailman/listinfo/its
>>
> _______________________________________________
> its mailing list
> its@ietf.org
> https://www.ietf.org/mailman/listinfo/its
>


-- 
*Best regards*


*Sara EL HAMDANI*
*Phd student -Umi University.*