Re: [Jmap] Call for adoption draft-murchison-jmap-sieve-01

Alexey Melnikov <alexey.melnikov@isode.com> Fri, 31 July 2020 17:17 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EA61B3A0B96 for <jmap@ietfa.amsl.com>; Fri, 31 Jul 2020 10:17:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4HPipfmUbyeJ for <jmap@ietfa.amsl.com>; Fri, 31 Jul 2020 10:16:59 -0700 (PDT)
Received: from waldorf.isode.com (waldorf.isode.com [62.232.206.188]) by ietfa.amsl.com (Postfix) with ESMTP id B06C43A0B90 for <jmap@ietf.org>; Fri, 31 Jul 2020 10:16:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1596215818; d=isode.com; s=june2016; i=@isode.com; bh=KFuor/4JRQJrA/Lk5Pww9gaF0Z0VNWo6KiF6LdgoA8w=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=K+wjZYucawBsoyCirP5Bul92sfyPBMbIQoxM2D/fe0uZjrRa5as1lcH4FAVkklrMRTvBQA I4K2n2DCr8Aq+uGIQEthFxdMgBPmh0fMwW7fD66wMEmH7ix8enAXjHcGzwrns3Q3gUapqH sUKo9W2t/p/D8OaJEtOZq1fMq42crM0=;
Received: from [192.168.0.5] (97e1f4dd.skybroadband.com [151.225.244.221]) by waldorf.isode.com (submission channel) via TCP with ESMTPSA id <XyRSCgAkBhnW@waldorf.isode.com>; Fri, 31 Jul 2020 18:16:58 +0100
To: Ken Murchison <murch@fastmail.com>, jmap@ietf.org
References: <4b219ec8-cd7e-496a-b81f-ae08e7837ad2@beta.fastmail.com>
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <b5fa925b-d921-302c-f725-8d0186824f85@isode.com>
Date: Fri, 31 Jul 2020 18:16:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
In-Reply-To: <4b219ec8-cd7e-496a-b81f-ae08e7837ad2@beta.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------CF163D6905E97D24ABE2AE87"
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/1-RKp_Ms2h7JTxRycQQ5Nds4BY8>
Subject: Re: [Jmap] Call for adoption draft-murchison-jmap-sieve-01
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2020 17:17:02 -0000

Hi,

On 31/07/2020 15:44, Bron Gondwana wrote:

> Hi All,
>
> As discussed in the meeting at IETF108, this is a formal call for 
> adoption for a document for managing sieve scripts via JMAP.  Please 
> send any comments on the adoption by August 14th (2 weeks from now).
>
> https://datatracker.ietf.org/doc/draft-murchison-jmap-sieve/

I support adopting this document and will work on it.


Some specific comments:

> Open Issues
>
>    o  How should doing /set{create} with an existing script name be
>       handled?  Should it fail or overwrite the existing script?  Should
>       the /set request include an 'overwrite' boolean argument?
RFC 5804 overwrites scripts by default, as long as they are valid. I 
would do the same here.

So maybe add boolean "nooverwrite" instead?

>
>    o  Should setting isActive==true on a script automatically deactivate
>       any other existing active script, or should the client have to do
>       so itself (as is currently documented)?
I think being able to activate the uploaded script in one operation 
would be handy. So yes, I agree with diactivating other scripts.
>
>    o  Do we want/need a SieveScript/copy method?
I am not sure this is needed. It is not like we support CATENATE for 
Sieve scripts ;-).
>    o  Do we want to leverage draft-ietf-jmap-quotas to query Sieve
>       script storage quotas?
Yes.
> 2.  Sieve Scripts
>
>    o  *content*: "String" The Sieve code in the script.  Note that any
>       double (") quote or backslash (\) characters appearing in the
>       script content MUST be escaped by prefixing them with a backslash
>       (\).
If this text is staying, it should explain that escaping is due to JSON 
rules. (Similar text when setting script)

Also, RFC 5804 has the following text:
  "A script of zero length SHOULD be disallowed."

So it is probably good to mention this in 2.2 and 2.3?

> 2.3.  SieveScript/validate
>
>    o  *errorDescription*: "String" A description of the error to show to
>       the user, or an empty string if the Sieve code is valid.
No strong preference, but should this be null when not set?

Best Regards,

Alexey