Re: [Jmap] Feedback on the quota draft

René CORDIER <rcordier@linagora.com> Wed, 04 March 2020 06:41 UTC

Return-Path: <rcordier@linagora.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39CE33A1003 for <jmap@ietfa.amsl.com>; Tue, 3 Mar 2020 22:41:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.621
X-Spam-Level:
X-Spam-Status: No, score=-1.621 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, HTML_MIME_NO_HTML_TAG=0.377, MIME_HTML_ONLY=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=linagora.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q3ez9xhCfBQJ for <jmap@ietfa.amsl.com>; Tue, 3 Mar 2020 22:41:56 -0800 (PST)
Received: from outgoing.linagora.com (outgoing.linagora.com [51.75.198.246]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9CF3A3A1002 for <jmap@ietf.org>; Tue, 3 Mar 2020 22:41:55 -0800 (PST)
Received: from linagora.com (unknown [10.233.69.48]) by outgoing.linagora.com (Postfix) with ESMTP id 93CEB3B for <jmap@ietf.org>; Wed, 4 Mar 2020 06:41:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linagora.com; s=s20181122; t=1583304113; bh=qp8WlVf7uVxOvVTvC5wEdYSOPAp5uJGUSDeURpqPsww=; h=From:Reply-To:To:Subject:Date:References:From; b=ltELKqsFSrxf5+Xp6jE+w7jFJxeer34i+5pCenXur8yzfTBeyLhSbQ9+YpkGVzau4 wK/OW3WFosxDBsn21j9P4muT/SgTpqbm5gsi1omn+DHlyKs2ewrFOz4ksc8jRZxkol XiHQno93YH4JLNlMwZZeaWQtqVHdiBruk88+WG4ylLg1uCOQovA9WM0uQEwUO/mdaj fA92hHTDN5dsohARwuBWV95FbwM9Te2sVtf+Mo3Zh97qkOT0rJIs/6s2b12DLM3xbR 92IrTUM7PlgKFwYj2613T7n4ZZZInvLddGHwOID9X0HeT5VeahJ4ocBoRx07+lfuov 3lAzx93CYUcLA==
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: René CORDIER <rcordier@linagora.com>
Sender: René CORDIER <rcordier@linagora.com>
Reply-To: rcordier@linagora.com
To: "jmap@ietf.org" <jmap@ietf.org>
Message-ID: <Mime4j.3.58c3e338a4b2000c.170a44777c3@linagora.com>
Date: Wed, 04 Mar 2020 06:41:52 +0000
References:
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/5cFBv89tXKBB-vOkuDLdmLlL-CU>
Subject: Re: [Jmap] Feedback on the quota draft
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2020 06:41:59 -0000

Hi all,

First of all, I would like to apologize for the time spent on this. I will try to fix comments faster in the future.

Then, I am happy to say that I finally released the new draft version of JMAP quotas specs. Please have a look at the ietf tracker: https://datatracker.ietf.org/doc/draft-ietf-jmap-quotas

I also did a github PR with the code change: https://github.com/jmapio/jmap/pull/318

I tried to answer inline below as well to the feedback mashup generously made by Bron last time. Please don't hesitate to have a look.

I would like to add an extra note as well, regarding the "quotaIds", it made little sense to add a field in "Mailbox" object indeed. I moved it as a property of the additional account's capability "urn::ietf::params::jmap::quota", as I think it makes more sense to have the quotas bounded to the account.

I would like to discuss an other idea as well (that is not represented in this draft). Some properties seem likely to be repeated many times. I thought of adding a new Object for that, called "QuotaResource", that would be defined by a "name", "resourceType", "warnLimit", "softLimit", "limit" and "scope". Probably we want those to be the same for a group of users or all users, repeating it for each Quota sounds redundant? Something like that:

"QuotaResource": {
  "id": "re01",
  "name": "normal user quota resource",
  "resourceType": "count",
  "warnLimit": 1600,
  "softLimit": 1800,
  "limit": 2000,
  "scope": "account"
}

"Quota": {
  "id": "qu01",
  "quotaResourceId": "re01",
  "used": 1056,
  "name": "bob@example.com",
  "description": "Personal account usage",
  "datatypes": [ "Mail", "Calendar" ]
}

With maybe methods like /get, /set, /query ?

Do you feel like it could be a good idea? Or does it make the all thing too complex and unnecessary?

Cheers,

Rene.

Le 20 novembre 2019 18:20, de brong@fastmailteam.com

Hi,

This is a combination of feedback collected from the meeting yesterday as well as my own suggestions!  These suggestions only come with my own personal weight, and are not a "you must", they are an "I suggest" - please feel free to offer counter proposals or even outright rejections of my suggestions, there is no "chair weight" attached.

With that said, here's the suggestions :)

Scope

I'm not sure if there's any point to it, but so long as it can be null (which might be the same thing as "account") then I don't see a problem in having it available for those who want it.

I would just call the key "scope" rather than "usedScope".  I don't see the point of putting different scopes on it, that seems unworkable.  Instead, if you have quotas in multiple scopes I would expect a quota entry per scope with the amount that was used and the limit - e.g. "you're using 400Mb of 1Gb account quota, and your domain is using 34Gb of 100Gb allocated to the domain" - there's no point having "you're using 400Mb of your domain's 100Gb", because your domain could be using 99.9Gb and you'd have no way to see - so the "limit" needs to be the total minus what everyone else is using to be meaningful for calculating what you can do.


Agreed, one scope is simpler and more logical.


Datatypes

At the moment there's no way to tie datatypes to quotas.  I would like to add an array of datatypes to each object (example below).  As an example, you may have a different quota for Calendars than for Mail - or they may be shared.  This is somewhat different from scope (server, domain, user, ...).


I liked that idea. Allows to apply Quota to more than just mails, so to other defined jmap objects defined by the specs, or even custom server ones.


Quota/query

At the moment the only way to get the list of quotas is "Quota/get#ids: null".  I think in the interests of consistency we should allow a /query as well (probably don't need a /queryChanges, just have a canCalculateChanges; false, but we could allow that too if a server finds it easy with their general model).


I did add the "/query", and also the "/queryChanges". I don't have a strong opinion on this but maybe it can be useful for a server to have "/queryChanges" too.


Quota/changes

Like with Mailbox/changes - I could see value in having a updatedProperties which can be either null or a list of properties, such that you could issue:

[["Quota/changes", { "sinceState": ... }, "1"],
 ["Quota/get", {
   "#ids": { "resultOf": "1", "name": "Quota/changes", "path": "/updated" },
   "#properties" : { "resultOf": "1", "Quota/changes", "path": "/updatedProperties" },
"2"]]

Which might only need to fetch the "used" most of the time.


I agree that "used" is probably gonna changed a lot compared to other fields, and that we are probably most interested by this field on a regular basis.


Push

There should be a nod towards Push and mention that Quota state changes are pushed like other state changes.


+1


Description

Do we need to provide for both a short "name" and a longer "description" field on each quota?


+1


Soft limits

Does anybody care about soft vs hard limits?  Soft limit being "you won't be blocked, but you'll be told off any maybe charged more", hard limits being "your changes will be rejected".  Should we have an optional second limit field in the spec?

Something of this sort was raised on mailing list by John van der Kamp - in fact he talked of 3 levels.  Perhaps they could be something like:

warnLimit
softLimit
limit

Where obviously warnLimit and softLimit are optional (and must each be lower than the next level up).  This is more complexity, but it's optional complexity at both ends: servers don't need to set them, and clients don't need to display them.


+1


Resource Types

The IMAP quota draft defines three types of resources for quotas, and also a registry where more can be described.  The initial types are "STORAGE" (units 1024 octets), "MESSAGE" (number of individual emails) and "MAILBOX" (number of mailboxes).  It maybe viable to use the same registry.

Of course, then you get issues like what should you call it for Calendar or Addressbook?  Should the limits be given DAVish names like "COLLECTION" and "RESOURCE" such that MESSAGE becomes "RESOURCE" and "MAILBOX" becomes "COLLECTION"? in JMAP quotas?

Also: should we do storage in bytes, or do 1024 octets for our storage numbers in JMAP as well so they map identically to the definition in the registry?


I would agree to Neil's comment on that one, that suggested that if we have the "datatypes" property, then we just need to have types like "count" or "size". Then for the "what do we count or calculate the size of?" question, the answer would be in the declared data types. 

Regarding the size, I put it in bytes by default, but still precised that it's up to the server to choose (maybe some server wants octets?). But that might be confusing for the client... Or should we have more granular resource types here, like "bytes" and "octets", or "sizeBytes" and "sizeOctets"?


EXAMPLE:

As promised, a Quota object for my example:

{
     "id": "2a06df0d-9865-4e74-a92f-74dcc814270e",
     "type": "storage",
     "used": 105645,
     "scope": "account",
     "limit": 200000,
     "description": "Personal account usage",
     "name": "brong@brong.net",
     "datatypes" : [ "Mail", "Calendar", "Contact", "Todo" ],
}

And this would be displayed in a a box called "Quota Use":

Something like that :)

Cheers,

Bron.
--
  Bron Gondwana, CEO, Fastmail Pty Ltd