[Jmap] Comments on draft-ietf-jmap-websocket-03

Jim Fenton <fenton@bluepopcorn.net> Mon, 04 November 2019 20:55 UTC

Return-Path: <fenton@bluepopcorn.net>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A520712002E for <jmap@ietfa.amsl.com>; Mon, 4 Nov 2019 12:55:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=bluepopcorn.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 33qUM-zElXYB for <jmap@ietfa.amsl.com>; Mon, 4 Nov 2019 12:55:28 -0800 (PST)
Received: from v2.bluepopcorn.net (v2.bluepopcorn.net [IPv6:2607:f2f8:a994::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D4ED120018 for <jmap@ietf.org>; Mon, 4 Nov 2019 12:55:28 -0800 (PST)
Received: from steel.local (sfosf0017s350801.wiline.com [64.71.6.2] (may be forged)) (authenticated bits=0) by v2.bluepopcorn.net (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id xA4KtMZM022161 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 4 Nov 2019 12:55:23 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bluepopcorn.net; s=supersize; t=1572900923; bh=Ex55I798fAGkMxctm4kNay4pUM+zu5jWbk6NcIazqUw=; h=To:From:Subject:Date; b=Ohg18ZLHifpptdVlS60Lww3v97BuafYHokzIS6VYaXeQc11zFFuuHkDYLALu987jd JoBefvGKVRy3aIUXg8Qq/VELng3IZjt1xt51vDnyI404lhGQCotXsQlB2HgHbA5dVW U0cSu7R1dj6qndD4mwr7xjUJimkXa9C9VOovM2W0=
To: jmap@ietf.org, Ken Murchison <murch@fastmailteam.com>
From: Jim Fenton <fenton@bluepopcorn.net>
Message-ID: <652de948-53ba-ddb4-1c40-25df28b1c42e@bluepopcorn.net>
Date: Mon, 04 Nov 2019 12:55:17 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/65p-wyAl89YhvbWBdVmcmTvwGvo>
Subject: [Jmap] Comments on draft-ietf-jmap-websocket-03
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2019 20:55:30 -0000

A few minor comments on the websocket-03 draft, currently in WGLC:

- Section 2: I'm not sure what the reference [1] is about (and 
correspondingly, the URIs section 8.3). I'd suggest leaving that out; it 
seems to be confusing the idnits tool as well.

- Section 3: supportsWebSocketPush: The value is shown as "Boolean", 
which would lead me to perhaps believe that it would be something like 
"supportsWebSocketPush": "true" while the example doesn't have quotes 
around "true". My inclination would be to leave off the quotes around 
Boolean, but I'm not a JSON syntax expert by any stretch of the 
imagination so decide accordingly.

- Sections 4.2.2 and 4.2.3: requestId is shown as optional in the 
response, and may only be included if there was a requestId in the 
request. If there is a requestId in the request, should the requestId be 
mandatory in the response? I think it should.

- Next time you're making an update, please change the reference to 
jmap-mail to RFC 8621.

-Jim