Re: [Jmap] Working group last call: draft-ietf-jmap-mdn-03

"Neil Jenkins" <neilj@fastmailteam.com> Fri, 22 November 2019 04:52 UTC

Return-Path: <neilj@fastmailteam.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D849C120103 for <jmap@ietfa.amsl.com>; Thu, 21 Nov 2019 20:52:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmailteam.com header.b=SSpQTCLD; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=e//u66Pc
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WqqeLCtWYp9h for <jmap@ietfa.amsl.com>; Thu, 21 Nov 2019 20:52:14 -0800 (PST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B78912002F for <jmap@ietf.org>; Thu, 21 Nov 2019 20:52:14 -0800 (PST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 85033101C for <jmap@ietf.org>; Thu, 21 Nov 2019 23:52:13 -0500 (EST)
Received: from imap99 ([10.202.2.99]) by compute6.internal (MEProxy); Thu, 21 Nov 2019 23:52:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= fastmailteam.com; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type; s=fm1; bh=hlh48cY xevsKSs1B+PK31MARObjxmyzFo/MmXmt2mkU=; b=SSpQTCLDAmT73KKUOk1JVxT I2HWZ/KyWW4IiahqHq5GSkI0NRRvTRyD1B39JkPM63rDpBsG5aZH1cZYi0R1/Gyd lXM3mAdmfwzfL46QVXLCX58Rb+MjyqPqkagdDtBfiVCxFVoxC2JuPvC3ZLdrUCeF m6UIBsyZKD2wgWePAkCCmLrjLLuP4O2sYsDQ4YLPPdq7dl7gb3YFGNMysB7YrUoN 1fqX/CUKLqb6+lIE0Ik6aSVMWZYU7xPlAmvtxdG9Lyks5yXN61dwPU9X2W3GnRaF JjmccWqXSEsm725yaob/6KZpSky3A6COYyToHm6zyujYS9y/k8drivgHO05km8Q= =
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hlh48c YxevsKSs1B+PK31MARObjxmyzFo/MmXmt2mkU=; b=e//u66PcMZp9o5QaJ/mgbN Kf5rIMg1YiWJ8qEdfKSaP+m1Kf/7Kzp9ocjmQtkLW+npjXVkIf5n0qVMOQI9dJqN ET0Nj1tD51QCpiYGxyAV7TylBAny2e4t1OftdGyaWNsPkiAIu+lcqEiIf8/Tyeiy EuY8EJnJJIAHfsFjNXxCwZPsdQg1TegLP+YhXb2+NNTdFunUyZFKOnH6fnQFthvb /umChX4g+NZoBFnIDFRSlMUH2z5vECFQoFjS/LapDHRBUPkyXUVqVsUk4wPgZY52 Dvjba7TDNJ4z7BL4BhJ+2hyU2DpnxYtk8y4dzgBhPmjlWR906+vOLfMVrQn8WMvw ==
X-ME-Sender: <xms:fGnXXb4vFHIesjPc-wS5img2bqPESauDBvMLM9UBmii_gNLVkkhOKg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehfedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreertdenucfhrhhomhepfdfpvghi lhculfgvnhhkihhnshdfuceonhgvihhljhesfhgrshhtmhgrihhlthgvrghmrdgtohhmqe enucffohhmrghinhepihgvthhfrdhorhhgnecurfgrrhgrmhepmhgrihhlfhhrohhmpehn vghilhhjsehfrghsthhmrghilhhtvggrmhdrtghomhenucevlhhushhtvghrufhiiigvpe dt
X-ME-Proxy: <xmx:fGnXXetkEYHXz8tiW_xt1-wJxTx6WgXJ7MK33fb8qo9Xugn0eR2DmA> <xmx:fGnXXTWZmYj05hXl8Y00wqZ4A2-BhWWRletDHLJUtTfK7AW1fIAqKA> <xmx:fGnXXXHgv7IKXvV_qpChm8flNIlCZSsvkuhWKA8pJjNTczPIfmVgAA> <xmx:fWnXXWFySOX5AGr-rJV-mHoPZ1bNN74eiC5N20IsEJiPWS-ad06oMw>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id AE8D1300DCB; Thu, 21 Nov 2019 23:52:12 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1
Mime-Version: 1.0
Message-Id: <ed66abcb-b2e5-4032-b809-f7534e3318d8@dogfood.fastmail.com>
In-Reply-To: <1776898c-03ee-4d34-b254-a9c638dd3741@dogfood.fastmail.com>
References: <1776898c-03ee-4d34-b254-a9c638dd3741@dogfood.fastmail.com>
Date: Fri, 22 Nov 2019 12:51:52 +0800
From: Neil Jenkins <neilj@fastmailteam.com>
To: IETF JMAP Mailing List <jmap@ietf.org>
Content-Type: multipart/alternative; boundary="9d99670f60c64a978cc398bd1c44f75f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/bWE205c6hOL8LgTqKu2E3Q8a_Kk>
Subject: Re: [Jmap] Working group last call: draft-ietf-jmap-mdn-03
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Nov 2019 04:52:16 -0000

Overall I think this doc is good. A few nits:

> o  forEmailId: "String" Email Id of the received email this MDN is
   relative to.

This needs to be nullable, as described in MDN/parse.

> o  originalMessageID: "String|null" (server-set)

I think this should be *originalMessageId* (lowercase d on the end) for consistency.

> *
> 2.1 <https://tools.ietf.org/html/draft-ietf-jmap-mdn-03#section-2.1>.  MDN/set

*
> 
   Standard "/set" method as described in [RFC8620 <https://tools.ietf.org/html/rfc8620>] where only the
   _create_ parameter is supported.

This is not quite right: the "accountId" and "ifInState" arguments are fine. I think this text should say something like:

> Only create is supported; any attempt to update/destroy MUST be rejected with a "forbidden" SetError.

And as a general comment, in the final versions of RFC8620/8621 we cleaned up the formatting so it worked better in the plain text version of the RFCs; I suggest adopting the same. So we use "quote" for a property name reference (not _underscore_) and remove the *asterisks* around the property names in the definitions.

Cheers,
Neil.