[Jmap] draft-ietf-jmap-blob-05 Review
Ken Murchison <murch@fastmail.com> Mon, 01 November 2021 12:58 UTC
Return-Path: <murch@fastmail.com>
X-Original-To: jmap@ietfa.amsl.com
Delivered-To: jmap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E9B63A12B4 for <jmap@ietfa.amsl.com>; Mon, 1 Nov 2021 05:58:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.119
X-Spam-Level:
X-Spam-Status: No, score=-2.119 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmail.com header.b=RHDddo+Y; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=W47ONC4w
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zyne4RYkjO1n for <jmap@ietfa.amsl.com>; Mon, 1 Nov 2021 05:58:22 -0700 (PDT)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1290B3A1292 for <jmap@ietf.org>; Mon, 1 Nov 2021 05:58:22 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 78E315C01CF for <jmap@ietf.org>; Mon, 1 Nov 2021 08:58:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Nov 2021 08:58:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= message-id:date:mime-version:to:from:subject:content-type :content-transfer-encoding; s=fm1; bh=2zFfYgUBozB5/nlstTyOcHUtjU v9iAX7RlbGv0GWXDA=; b=RHDddo+YpCw4kchFn+DjN849HBhkTM+7RdE32bnrJ8 me4FhJNiP3eDaREE3w/XRCvpKULHkhNXH8zsI9fwz36KqUHr7DFtsycM7I7tmClg k00auuexSp3bcDJ7xTfqRiHCdjNm6Ss/yhBnncp+rRNDTy4CtKtkxNxoGdMYB0vE GlqUgdESA842XpHmTg/VgIyf5nP+PR5lJK/8CejWrb6dIqsmjAZRQ/v8sQhXsjnk FghYSkFL0jxulZzMuojKaATRcc4aZBSdkNuHW0iP9+ct4v3FfGHAokNsnShjZ6uA QQ1J4GLCCBTU1xRiE8+3TnGvJPOnTHby8L6SI0euoa8A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2zFfYg UBozB5/nlstTyOcHUtjUv9iAX7RlbGv0GWXDA=; b=W47ONC4wldXjgGuWz2Koib R5tyi3ghOxfG1Klcg/sMIrJ0+CG/Tly35nKv5y2BxY0lHz3DakUp6gaVfj7yj+0K lCcd1CnsOuFU9lt1FexpeOS0r0PXl9LBmMNhuEybqBt/Hqtf+jZ+OFpk8Hdz0a06 JK5emFnJ5l+hDQw633egsrst9XaCugLqe4OjJhCDmOOork87GDT5Gol0JG+u6MGL V5ncAI00mpxGv8DEopZ0NLqSQTm7iEbvQl5iDucwHlVefjHTWRWNwwIWi6gJReYU V+2tLKCM6r8Q/0dE5qvml/ScrcxkvP070UlAx6dQrFfqUirgLYsY3U/R3lNcqqTg ==
X-ME-Sender: <xms:beR_YTNF2oMpcYUrvtKOFT_qy7C7EkkZ045-GMNL_WRHiVgZGTz_JQ> <xme:beR_Yd9kFYsTgoGB0c7_6QOk-70oQuCFyuHfz-iS3N8zX-MFl0RG8BTzw63Zo5bx2 Ohq-Zg0ot7aPg>
X-ME-Received: <xmr:beR_YSSlsMf-yHHsPrRvFW9HftG38Wp1m7fx_UL9oJjZZO74oreiWinc6BJdirAugXrOVTZOTGRSWVuMcEeW2P3iipa40dtgV0czNqjlSg84Uxbl>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdehvddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfvffhufhotgfgsehtjeertddtfeejnecuhfhrohhmpefmvghnucfo uhhrtghhihhsohhnuceomhhurhgthhesfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeekveetgeetjedtjefggfffvddtudelffdvjedvhefffedtueejuedtueej vdekudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmuhhrtghhsehfrghsthhmrghilhdrtghomh
X-ME-Proxy: <xmx:beR_YXsUqHQZ8FXgU9R4ESLZKpxoHOmsABxidau8YmJQMG5jgrz-GA> <xmx:beR_Ybf-nnWbc6SJ9w-E88Y9GT_2K0z0PJIJ2GqGWPVeBU4OhjzMSw> <xmx:beR_YT16JfE105fE__0bHMRxXFMNTz2tmbTBvtJRBLCaUu-8j3ZLyQ> <xmx:beR_YZq0Z7xvcQi0DunTE8v9IctOr2SMwxjfFhQY-w6ml5VWPwg59Q>
Received: by mail.messagingengine.com (Postfix) with ESMTPA for <jmap@ietf.org>; Mon, 1 Nov 2021 08:58:20 -0400 (EDT)
Message-ID: <792d2e7c-4486-8c3d-ec4a-4b6b718380a1@fastmail.com>
Date: Mon, 01 Nov 2021 08:58:14 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0
Content-Language: en-US
To: IETF JMAP Mailing List <jmap@ietf.org>
From: Ken Murchison <murch@fastmail.com>
Organization: FastMail US LLC
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/jmap/tjEEQDFDWySpPWO-R_mStxM7DQg>
Subject: [Jmap] draft-ietf-jmap-blob-05 Review
X-BeenThere: jmap@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: JSON Message Access Protocol <jmap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/jmap>, <mailto:jmap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/jmap/>
List-Post: <mailto:jmap@ietf.org>
List-Help: <mailto:jmap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/jmap>, <mailto:jmap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Nov 2021 12:58:28 -0000
Overall, this look good.
General comment: probably should fully expand "spec" to "specification"
throughout
Specific nits:
- Abstract: "defined endpoint" -> "defined endpoints"
- Section 4.1.1: I think the Blob/set{create} response elements should
be in list format rather than packed together in a single paragraph.
- Section 4.1.3: It is not clear to me whether Blob/set{destroy} is a
valid method.
- Section 4.1.3: Since the examples are for Blob/set{create}, I think
they either belong in Section 4.1.1 or in a new 4.1.4.
--
Kenneth Murchison
Senior Software Developer
Fastmail US LLC
- [Jmap] draft-ietf-jmap-blob-05 Review Ken Murchison